Harden installer and add Copilot instructions#1087
Conversation
- add repo-specific Copilot instructions under .github\n- harden install.sh arg parsing, checksum handling, and Windows binary install\n- align test-infrastructure Dockerfile comment with actual deps\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Selfish666420 <jumper420666@proton.me>
|
Thanks for the installer fixes. The checksum lookup, Windows executable handling, and missing directory-argument validation are useful, but this PR mixes installer behavior, a Copilot instruction file, and a test-container documentation change. Please split the installer hardening into a focused bug PR with regression coverage and move the instruction/documentation work into a separate contribution. Installer and agent-instruction changes receive separate security review. |
Revert unrelated documentation-only changes so this PR focuses only on install.sh reliability fixes. Signed-off-by: Selfish666420 <jumper420666@proton.me>
Done. I split this PR to installer hardening only and removed the Copilot-instructions and test-container comment changes from this branch. The remaining diff is focused on install.sh reliability and cross-platform handling. |
What does this PR do?
This updates contributor ergonomics and installer reliability so setup is more predictable across environments.
It adds a new
.github/copilot-instructions.mdwith repo-specific build/test/lint/security commands, architecture notes, and key conventions for future coding sessions. It also hardensinstall.shby validating--dirusage, supporting wget fallback for checksum fetches, matching checksum entries by exact filename, and handling Windows.exeextraction/target naming correctly. In addition, it fixes a mismatched comment intest-infrastructure/Dockerfileso the documented dependencies align with what the image actually installs.Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
make -f Makefile.cbm test)make -f Makefile.cbm lint-ci)