fix(mcp): return structured compact results#1043
Open
WarGloom wants to merge 2 commits into
Open
Conversation
Tools advertise an object outputSchema, so strict MCP clients reject compact TOON responses that omit structuredContent. Signed-off-by: wargloom <wargloom@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Every MCP tool advertises an object
outputSchema, but compact TOON andplain-text results omitted
structuredContent. Strict MCP clients thereforerejected otherwise successful tool calls with
-32600.This change keeps JSON-object results unchanged and adds an object for every
other result:
{"text":"..."}{"error":"..."}The existing text
contentblock remains for model visibility and backwardscompatibility.
Validation
ASAN_OPTIONS=detect_leaks=0 make -f Makefile.cbm test— 6,009 passed,1 skipped
make -f Makefile.cbm lint-cisearch_graphresponses plus unit coveragefor plain-text and error results
Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
make -f Makefile.cbm test)make -f Makefile.cbm lint-ci)