Open
Conversation
Application was crashing due to unhandled exceptions when game directory was not set: - ArgumentNullException from null Perks/Buffs collections in XmlService - DirectoryNotFoundException in IconService looking for pak files Fixes: - Initialize Perks and Buffs collections with empty lists in XmlService - Add GameDirectory and file existence checks in IconService.GetBase64Icon - Validate game directory in NewMod.StartModding with user-friendly error - Add null-safe access to XmlService collections in all ModItem components
Game installations don't have a Mods folder by default. Added checks to: - Create the folder in InitiateModCollections if missing - Skip enumeration in DeleteMod if folder doesn't exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix application crash when user clicks "Start Modding" without having configured the game directory.
When the application is first downloaded, the game directory is not configured by default. Additionally, fresh game installations don't have a "Mods" folder. Attempting to create a new mod in this state caused the application to crash due to:
ArgumentNullExceptionfrom null Perks/Buffs collections in XmlServiceDirectoryNotFoundExceptionin IconService looking for pak files in wrong locationDirectoryNotFoundExceptionin ModService when Mods folder doesn't existChanges
Test plan
This resolves "Unset Game Direct cause the crash when create new mod." on nexusmods