docs: rework the README hero off BusinessTheme, log the 2.0 template changes#285
Merged
Merged
Conversation
…changes BusinessTheme moved to the examples module, so the README "Hello world" no longer compiled. Inline the same palette and text styles as direct DocumentColor / DocumentTextStyle values — the hero renders identically, just self-contained — and drop BusinessTheme from the "Cinematic by default" feature bullet. Extend the v2.0.0 CHANGELOG entry with the classic-preset and BusinessTheme removals and the layered-package .v2-suffix drop. Docs only; the reworked hero snippet compiles against the engine, and the documentation guard tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
BusinessThememoved to the examples module (#279), so the README "Hello world" hero no longer compiled (it importedcom.demcha.compose.document.theme.BusinessTheme). Second 3-13 docs slice — the README + CHANGELOG.What
BusinessTheme.modern()+theme.*()with the same palette and text styles as directDocumentColor.rgb(...)/DocumentTextStyle.builder(...)values. The rendered hero is identical (same cream page, tan soft panel, gold accent strip, h1/body) — just self-contained. Verified: the snippet compiles against the engine.BusinessThemefrom "Cinematic by default." (soft panels, accent strips, transforms, charts, gradients remain first-class engine primitives).## v2.0.0 — Plannedentry with the classic-preset +BusinessThemeremovals and the layered-package.v2-suffix drop, in reader-first terms.Out of scope (next 3-13 slice)
api-stability.mdretier,which-template-system.mdslim rewrite, and thev1-classic/docs archive — including the README's remainingv1-classiclanding link (line 285), which is why the README still mentionsBusinessThemeandDocumentationCoverageTestis untouched here.Tests
Docs only. Hero snippet compiles (
javacagainst the engine classpath).DocumentationCoverageTest+VersionConsistencyGuardTest+CanonicalSurfaceGuardTest+PackageMapGuardTest+DocumentationExamplesTest— 34 tests, 0 failures.