refactor(templates): drop the v2 suffix from the cv package#283
Merged
Conversation
Last of the four per-family suffix drops. Move the cv.v2 sub-packages (components, data, presets, widgets), AUTHORS.md, and the author-guide package-info up to templates.cv, and rewrite every engine import and doc reference across the engine, tests, examples, and benchmarks. The two package-info files are merged: the short cv stub is dropped and the rich cv.v2 author guide is promoted, with its stale note about a now-removed Gen-2 cv.* stack cut. Pure rename — the visual parity test passes against the unchanged committed baselines, so every cv preset renders identically. The examples module keeps its own examples.templates.cv.v2 package (its source directory is unchanged); only its engine imports are repointed. Tests: ./mvnw verify javadoc:javadoc -pl . — 1378 tests, 0 failures, javadoc clean; examples + benchmarks compile; perf-smoke + examples-generation smoke (85) green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Last of the four per-family suffix drops (invoice ✅ → proposal ✅ → cover-letter ✅ → cv). With this, the layered templates carry no
v2package segment.What (136 files: 78 renames, 57 edits, 1 delete)
git mvthecv/v2sub-packages (components,data,presets,widgets) +AUTHORS.mdup totemplates/cv/(main + test); rewrite the engine FQNdocument.templates.cv.v2→document.templates.cvacross all 132 referencing files, plus the engine-source prose paths (cv/v2/widgets→cv/widgets, etc.) and the deferred cover-letter cross-imports (CvIdentity/CvName/SectionLookup).cv/package-info.javastub and promoted the richcv/v2author-guide up, cutting its stale note about a now-removed Gen-2cv.*stack.examples.templates.cv.v2package (its source dir is unchanged) — only its engine imports were repointed. Baselines resolve via a hardcodedcv-v2-layeredresource label, independent of the Java package.CvV2VisualParityTestpasses against the unchanged committed baselines — every CV preset renders identically. Independently cold-eye verified (examples-package integrity, package-info merge, baseline constant all held).Deferred to the docs/ledger pass (3-13)
Path links in
docs/*.md+examples/README.mdstill saycv/v2/...(broken markdown links only — not gated byverify/javadoc/smokes), thedocs/api-stability.md§4 tier rows, and the cosmeticV2-in-identifier names + examples' ownv2dirs.Tests
./mvnw verify javadoc:javadoc -pl .— 1378 tests, 0 failures, javadoc clean. Examples + benchmarks compile; perf-smoke + examples-generation smoke (85) green. japicmp report-only on this line.