refactor(templates): remove the freed Gen-2 substrate#278
Merged
Conversation
With the builtins and the classic cv/cover-letter families gone, their shared substrate packages have no remaining consumer: templates.blocks, templates.components (Header/Module), templates.themes (Spacing/Typography), templates.support.common, and templates.data.common. components used blocks and themes; nothing used components — the three are dead together. Delete those packages and their tests, plus the now-empty templates.support package-info and CanonicalTemplateComposerPdfBoundaryTest (it walked the deleted support directory for *TemplateComposer files that no longer exist) and its stale allowlist entry. Trim the data and top-level templates package-info prose that named the removed packages. Tests: ./mvnw verify javadoc:javadoc -pl . — 1403 tests, 0 failures, javadoc clean; examples + benchmarks compile; perf-smoke + examples-generation smoke (85) green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
With the builtins and the classic cv/cover-letter families removed, their shared substrate packages have no remaining consumer. Verified orphaned across all file types (no reflection /
META-INF/services/ string-FQN).What
Delete:
templates.blocks,templates.components(Header/Module),templates.themes(plural:Spacing/Typography) —componentsusedblocks+themes; nothing usedcomponents, so all three are dead together.templates.support.common(+ the now-emptytemplates.supportpackage-info).templates.data.common(Header/EmailYaml/LinkYml).CanonicalTemplateComposerPdfBoundaryTest— itFiles.walked the deletedtemplates/supportdir for*TemplateComposer.javafiles that no longer exist (subject-less) — and its stale allowlist entry.Trim the
data+ top-leveltemplatespackage-info prose that named the removed packages (and the stale "built-in templates" / "deprecated namespace" claims).Kept:
templates.core, all*/v2stacks,templates.api,data.{invoice,proposal,schedule}. Thecore.theme.{Spacing,Typography}name-twins are unrelated and untouched.Follow-up (not this PR): a lightweight PDF-boundary guard scoped to the surviving
templates/**v2 surface would restore the invariant the deleted test guarded (the old one's subject — the support composers — is gone).Tests
./mvnw verify javadoc:javadoc -pl .— 1403 tests, 0 failures, javadoc clean. Examples + benchmarks compile; benchmarkstest+ perf-smoke + examples-generation smoke (85) green. japicmp report-only on this line.