refactor(templates): remove the classic cover-letter family#276
Merged
Conversation
The Gen-2 cover-letter stack (coverletter.{presets,builder,spec,layouts} +
data.coverletter) is superseded by the layered coverletter.v2 surface. It is
removed before the classic CV family because each classic cover-letter preset
cross-references its paired cv.presets preset in Javadoc, which the javadoc
gate would reject once cv.presets is gone; CV does not reference cover-letter.
Delete the classic cover-letter packages, their tests, and the CoverLetterMock
fixture; repoint the cover-letter package-info at the v2 stack. Strip the
classic cover-letter helpers from TemplateTestSupport and ExampleDataFactory
(the v2 sample and sampleHeader stay) and the data.coverletter entry from the
data package-info. Also drop an orphaned classic cover-letter layout snapshot
that no test loads.
Tests: ./mvnw verify javadoc:javadoc -pl . — 1553 tests, 0 failures, javadoc
clean; examples + benchmarks compile; examples-generation smoke (85) green,
including the v2 cover-letter gallery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Gen-2 cover-letter stack (
coverletter.{presets,builder,spec,layouts}+data.coverletter) is superseded by the layeredcoverletter.v2surface.Removed before the classic CV family: each classic cover-letter preset has a
{@link …cv.presets.X}"paired CV preset" Javadoc cross-ref that the javadoc gate would reject oncecv.presetsis deleted. CV does not reference cover-letter, so cover-letter-first leaves CV removal clean. (Cover-letter also needs no benchmark repoint — the benchmarks render CV/invoice/proposal.)What
mock/CoverLetterMock. Keep + repointcoverletter/package-infoat the v2 stack (dropped@Deprecated). All ofcoverletter.v2is untouched (its presets are name-twins of the classic ones in a different package).TemplateTestSupport(coverLetter()/jobDetails(), only the deleted test called them) andExampleDataFactory(sampleCoverLetter()/sampleCoverLetterDocument(); the v2 sample +sampleHeader()stay). Dropdata.coverletterfrom the datapackage-info.cover_letter_standard.json) that no test loads.Tests
./mvnw verify javadoc:javadoc -pl .— 1553 tests, 0 failures, javadoc clean. Examples + benchmarks compile; examples-generation smoke (85) green, including the v2 cover-letter gallery. japicmp report-only on this line.