refactor(templates): remove the dead builtin composer substrate#275
Merged
Conversation
With the invoice/proposal builtins and the weekly-schedule builtin gone, their private support packages have no remaining caller: support.business (the invoice/proposal composers, styles, and layout policy) and support.schedule's WeeklyScheduleTemplateComposer, plus the singular templates.theme.WeeklyScheduleTheme it drove. Delete those packages. The shared support.common helpers and the data.schedule document spec (still consumed by examples + tests) stay. Trim the stale support and themes package-info prose that named the removed packages. Tests: ./mvnw verify javadoc:javadoc -pl . — 1602 tests, 0 failures, javadoc clean; examples + benchmarks compile; perf-smoke + examples generation smoke green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
With the invoice/proposal builtins and the weekly-schedule builtin removed, their private support packages have no remaining caller. Verified orphaned across all file types (no reflection /
META-INF/services/ string-FQN).What
Delete:
support/business— the invoice/proposal composers (InvoiceTemplateComposer,ProposalTemplateComposer),BusinessDocument{Styles,SceneStyles,LayoutPolicy}+ package-info.support/schedule/WeeklyScheduleTemplateComposer+ package-info, and the singulartemplates/theme/WeeklyScheduleThemeit drove.support.common(shared helpers) and thedata.scheduledocument spec (still consumed by examples + tests) stay. Trimmed the stalesupport+themespackage-info prose that named the removed packages.docs/architecture/package-map.md/overview.mdstill list these as live packages — that's part of the docs/ledger pass.Tests
./mvnw verify javadoc:javadoc -pl .— 1602 tests, 0 failures, javadoc clean. Examples + benchmarks compile; the perf-smoke (CurrentSpeedBenchmarksmoke) and examples-generation smoke (85) both green. japicmp runs report-only on this line.