refactor(templates): remove the V2 invoice/proposal builtins#274
Merged
Conversation
InvoiceTemplateV2 and ProposalTemplateV2 — the cinematic builtins on BusinessTheme — are superseded by the layered ModernInvoice / ModernProposal presets, which render the same specs through the generic DocumentTemplate<S> seam on a BrandTheme. With the builtins gone, the per-family api interfaces InvoiceTemplate / ProposalTemplate have no implementer. Delete the two V2 builtins, the InvoiceTemplate / ProposalTemplate interfaces, their unit and demo tests, and CustomBusinessThemeExample (it demoed custom theming the v2 invoice does not yet express). Drop the CustomBusinessTheme example registrations and repoint the surviving javadoc and showcase strings off the removed types. The visual parity tests keep rendering ModernInvoice / ModernProposal against their committed baselines. The builtins' private composer substrate (support/business) is removed in a follow-up. Tests: ./mvnw verify javadoc:javadoc -pl . — 1602 tests, 0 failures, javadoc clean; examples test-compile; benchmark gates + perf-smoke green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
InvoiceTemplateV2/ProposalTemplateV2— the cinematic builtins onBusinessTheme— are superseded by the layeredModernInvoice/ModernProposalpresets, which render the same specs through the genericDocumentTemplate<S>seam on aBrandTheme. With the builtins gone, the per-family interfacesapi/InvoiceTemplate+api/ProposalTemplatehave no implementer.What
builtins/{InvoiceTemplateV2,ProposalTemplateV2}+package-info, the orphanedapi/{InvoiceTemplate,ProposalTemplate}interfaces, their 2 unit tests + 3 demo tests, andCustomBusinessThemeExample(it demoed custom theming the v2 invoice doesn't yet express).GenerateAllExamples,ShowcaseMetadata, README) and repoint the surviving javadoc + showcase strings off the removed types.InvoiceV2VisualParityTest/ProposalV2VisualParityTestkeep renderingModernInvoice/ModernProposalagainst their committed baselines (the builtin reference was javadoc-only).The builtins' private composer substrate (
support/business) is removed in a follow-up. Remaining doc/prose mentions of the builtins (README cinematic sections,package-map.md,api-stability.md§4) are part of the docs/ledger pass.Tests
./mvnw verify javadoc:javadoc -pl .— 1602 tests, 0 failures, javadoc clean.examplestest-compile; benchmarkstest(39) + the perf-smoke run (CurrentSpeedBenchmark -Dgraphcompose.benchmark.profile=smoke) both green. japicmp runs report-only on this line.