feat(templates): layered proposal/v2 ModernProposal on the extracted core#269
Merged
Conversation
…core Add a proposal/v2 family mirroring invoice/v2: ModernProposal (DocumentTemplate<ProposalDocumentSpec>) renders a proposal on templates.core + a BrandTheme, porting the cinematic builtins/ProposalTemplateV2 look — hero, executive summary, FROM / TO parties, body sections, timeline + pricing tables, acceptance terms, and footer. - core.theme: BrandTheme.proposalModern() + Typography.proposalModern() (richer h1 / h2 / h3 scale); reuses the invoice palette + spacing — the two families share one modern business look. - ModernProposal fixes a latent bug in the builtin: its first page-flow (hero + summary + parties) was never built and silently dropped, so the cinematic proposal rendered with no header. The layered preset builds it, so the header renders. - Parties render inline (two-party layout, optional fields), not through the CV-shaped PartyIdentity. Table body cells inherit the DSL default to match the builtin. - example (on the cream page background) + a GenerateAllExamples row. - smoke test (5 cases) + ProposalV2VisualParityTest + blessed baseline. - data.proposal package-info: note it backs both the builtin and proposal/v2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Completes the Stage-2 invoice/proposal migration: a
proposal/v2layered family oncore+BrandTheme, mirroringinvoice/v2(#257 / #264), so the proposal family can render on the layered stack and eventually replace the cinematic builtin.What
BrandTheme.proposalModern()+Typography.proposalModern()(richer h1 / h2 / h3 scale). ReusesPalette.invoiceModern()+Spacing.invoiceModern()— invoice + proposal share one modern business look (a neutralbusinessModern()rename is a deferred cleanup; the invoice side is byte-unaffected).DocumentTemplate<ProposalDocumentSpec>): hero, executive summary, FROM / TO parties, body sections, timeline + pricing tables, acceptance terms, footer — all reading the theme.builtins/ProposalTemplateV2never.build()s its first page-flow, so the cinematic proposal silently drops its title / summary / parties (the PDF starts at "Scope").ModernProposalbuilds it, so the header renders. The visual-parity baseline is the corrected render. (A separate task is filed to fix the 1.x builtin.)core.PartyIdentity, same reasoning as invoice. Table body cells inherit the DSL default to match the builtin.GenerateAllExamplesrow.data.proposalpackage-info reframed (now backs both the builtin and proposal/v2).Tests
./mvnw verify javadoc:javadoc -pl .→ BUILD SUCCESS, 1625 tests, 0 failures; javadoc clean. The example renders the full proposal (header + sections + tables); visual parity green against the committed baseline.