fix(showcase): ship the example PDFs that 404 on the GitHub Pages site#267
Merged
Conversation
The showcase site links to 85 example previews but only 53 are committed; the other 32 — navigation, emoji, inline SVG/icons, layout, multi-section, charts, debug overlay and the engine-deck / feature-catalog / financial-report flagships — 404 on the live site. Root cause: the blanket *.pdf ignore whitelists the old docs/showcase and site/public/showcase locations but never web/showcase, where the live site now lives, so every newly added preview was silently ignored and left out of the release commit. - .gitignore: whitelist web/showcase/**/*.pdf, matching the older site copies, so showcase previews are tracked and future examples ship automatically. - Commit the 32 missing previews under web/showcase/pdf/** (regenerated with GenerateAllExamples). Verified every pdf path in web/examples.json (85) resolves to a committed file; the 53 already-tracked previews and examples.json are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The showcase site lists 85 example previews but only 53 PDFs are committed, so
32 cards 404 on the live site — e.g.
/showcase/pdf/features/debug/debug-overlay.pdf. The missing set is the wholerecent feature wave: in-document navigation, colour emoji, inline SVG / icons,
per-page layout, multi-section documents, charts, the debug overlay, and the
engine-deck / feature-catalog / financial-report flagships.
Root cause: the blanket
*.pdfignore whitelists the previous showcaselocations (
docs/showcase/**,site/public/showcase/**) but neverweb/showcase/**, where the live GitHub Pages site now lives. Every newly addedpreview was silently ignored and dropped from the release commit, so the 53
survivors are only those committed before the move.
What
.gitignore: add!web/showcase/**/*.pdfso showcase previews are trackedlike the older site copies — and future examples ship automatically.
web/showcase/pdf/**(regenerated viaGenerateAllExamples).No source changes;
web/examples.json, the 53 already-tracked previews and allscreenshots are untouched.
Tests
pdfpath inweb/examples.json(85/85) now resolves to a committedfile.
.gitignore+ 32.pdf; no other tracked file changed.Deploy
The live site refreshes only when this reaches
main(deploy-web.ymlruns onpush to
main). After this merges to develop, fast-forwardmain(asset-only —no version bump, no tag) and let
deploy-webrun, or dispatch it manually.Follow-up (separate PR)
ShowcaseMetadatahas no registration for ~26 of these examples, so their"View Code" links and card titles/descriptions fall back to generic values.
That registry cleanup is independent and does not block this 404 fix.