Scope endpoint deletion to the caller's authorized products - #15742
Open
svader0 wants to merge 1 commit into
Open
Scope endpoint deletion to the caller's authorized products#15742svader0 wants to merge 1 commit into
svader0 wants to merge 1 commit into
Conversation
Hardening to the endpoint (Location) delete paths. A Location row is shared by every product that records the same value, so both delete paths now route through one helper that removes only the references the caller's products own. Adds regression tests. No functional change for correctly-permissioned users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening / consistency improvement to endpoint (Location) delete handling.
A Location row is shared by every product that records the same value. Both delete paths now
route through one shared helper. The helper removes only the references the caller's products
own, and it deletes the row itself once nothing points at it any more.
Adds regression tests. No functional change for correctly-permissioned users.