prefetching locations when building dedupe candidate scope queryset#14483
Open
dogboat wants to merge 2 commits intoDefectDojo:bugfixfrom
Open
prefetching locations when building dedupe candidate scope queryset#14483dogboat wants to merge 2 commits intoDefectDojo:bugfixfrom
dogboat wants to merge 2 commits intoDefectDojo:bugfixfrom
Conversation
…ferently from endpoints when using v3
Member
valentijnscholten
left a comment
valentijnscholten
left a comment
There was a problem hiding this comment.
The PR description seems to suggest there is a bug that is fixed by this PR. Should the PR add a testcase to prove the bug is fixed and we don't regress in the future?
Contributor
Author
Good call, added a test for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
build_candidate_scope_queryset()function to handle the prefetch list differently when V3 locations are enabled to prevent crashes when updating locations on a finding. Previously, changing locations when editing a finding would cause a 500 when V3 locations are enabled; now it does not.