Repository navigation
ci: GitHub Actions with HDF5 1.14 and 1.12 from the LCG views on CVMFS - #1
Merged
Merged
Conversation
Stock Ubuntu runners only offer HDF5 1.10 through apt, which CMakeLists.txt refuses, so both jobs mount sft.cern.ch and source an LCG view: - hdf5-1_14: ubuntu-24.04, LCG_110 x86_64-ubuntu2404-gcc13-opt (HDF5 1.14.6) - hdf5-1_12: ubuntu-22.04, LCG_105 x86_64-ubuntu2204-gcc11-opt (HDF5 1.12.2) Each job runs ci/github-ci.sh, which configures with the new SPINE_READER_REQUIRE_PYTHON=ON (a missing Python 3 now fails the configuration instead of silently dropping the generated-model and golden-member checks), builds, and runs ctest. The same script is the local dry run, in CERN's SFT Ubuntu images on CVMFS (ci/EGM.md); both jobs pass there on this commit. ci/check_tag_version.sh refuses a release tag that differs from project(VERSION). It is meant to be run before pushing a tag; CI runs it again on tag pushes. The workflow has read-only permissions, no secrets, and pins both actions by commit SHA.
pgranger23
force-pushed
the
ci/github-actions
branch
from
November 5, 2026 21:08
eb4c01d to
01b2636
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of following SPINE releases automatically: CI for spine-reader, so that every later change (and the first release tag) is checked by it.
What this adds
.github/workflows/ci.yml, with two jobs on every push, pull request and manual dispatch:hdf5-1_14:ubuntu-24.04with LCG_110x86_64-ubuntu2404-gcc13-opt(HDF5 1.14.6, gcc 13, CMake 3.30, Python 3.13);hdf5-1_12:ubuntu-22.04with LCG_105x86_64-ubuntu2204-gcc11-opt(HDF5 1.12.2, gcc 11, CMake 3.26, Python 3.9).Stock runners only offer HDF5 1.10 through apt, which
CMakeLists.txtrefuses, so both jobs mountsft.cern.chwithcvmfs-contrib/github-action-cvmfs. The workflow haspermissions: contents: read, uses no secrets, and pinsactions/checkout(v7.0.1) and the CVMFS action (v5.6) by commit SHA.ci/github-ci.sh <view>: what each job runs (source the view, configure, build, ctest), and also the local dry run.SPINE_READER_REQUIRE_PYTHON(intests/CMakeLists.txt, default OFF, ON in CI): a missing Python 3 fails the configuration instead of silently droppingspine_reader_generated_modelandspine_reader_golden_members.ci/check_tag_version.sh vX.Y.Z: refuses a release tag that differs fromproject(VERSION). It is to be run before pushing a tag; thehdf5-1_14job runs it again on tag pushes, as a backstop.ci/EGM.md, the rootEGM.mdand the README describe all of the above, including the local dry-run commands.Checked before opening
Dry run of both jobs with
ci/github-ci.sh, in CERN's SFT Ubuntu 24.04 and 22.04 images on CVMFS (apptainer):spine_reader_real_filesis skipped as designed (no real files).GitHub's runner images are not the SFT ones, so this PR's own CI run is the final check.
-DSPINE_READER_REQUIRE_PYTHON=ONwith no usable Python: the configuration fails with "Could NOT find Python3". With the default OFF it only warns, as before.ci/check_tag_version.sh v0.1.0exits 0,v0.1.1exits 1, and no argument exits 2.No library or test code changes; the library's behaviour is unchanged.