Skip to content

ci: GitHub Actions with HDF5 1.14 and 1.12 from the LCG views on CVMFS - #1

Merged
pgranger23 merged 1 commit into
mainfrom
ci/github-actions
Nov 5, 2026
Merged

pgranger23 merged 1 commit into
mainfrom
ci/github-actions

Conversation

@pgranger23

@pgranger23 pgranger23 commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

First step of following SPINE releases automatically: CI for spine-reader, so that every later change (and the first release tag) is checked by it.

What this adds

  • .github/workflows/ci.yml, with two jobs on every push, pull request and manual dispatch:

    • hdf5-1_14: ubuntu-24.04 with LCG_110 x86_64-ubuntu2404-gcc13-opt (HDF5 1.14.6, gcc 13, CMake 3.30, Python 3.13);
    • hdf5-1_12: ubuntu-22.04 with LCG_105 x86_64-ubuntu2204-gcc11-opt (HDF5 1.12.2, gcc 11, CMake 3.26, Python 3.9).

    Stock runners only offer HDF5 1.10 through apt, which CMakeLists.txt refuses, so both jobs mount sft.cern.ch with cvmfs-contrib/github-action-cvmfs. The workflow has permissions: contents: read, uses no secrets, and pins actions/checkout (v7.0.1) and the CVMFS action (v5.6) by commit SHA.

  • ci/github-ci.sh <view>: what each job runs (source the view, configure, build, ctest), and also the local dry run.

  • SPINE_READER_REQUIRE_PYTHON (in tests/CMakeLists.txt, default OFF, ON in CI): a missing Python 3 fails the configuration instead of silently dropping spine_reader_generated_model and spine_reader_golden_members.

  • ci/check_tag_version.sh vX.Y.Z: refuses a release tag that differs from project(VERSION). It is to be run before pushing a tag; the hdf5-1_14 job runs it again on tag pushes, as a backstop.

  • ci/EGM.md, the root EGM.md and the README describe all of the above, including the local dry-run commands.

Checked before opening

  • Dry run of both jobs with ci/github-ci.sh, in CERN's SFT Ubuntu 24.04 and 22.04 images on CVMFS (apptainer):

    • LCG_110, gcc 13.3: the build succeeds; 4 ctest entries pass, and spine_reader_real_files is skipped as designed (no real files).
    • LCG_105, gcc 11.4: same result.

    GitHub's runner images are not the SFT ones, so this PR's own CI run is the final check.

  • -DSPINE_READER_REQUIRE_PYTHON=ON with no usable Python: the configuration fails with "Could NOT find Python3". With the default OFF it only warns, as before.

  • ci/check_tag_version.sh v0.1.0 exits 0, v0.1.1 exits 1, and no argument exits 2.

No library or test code changes; the library's behaviour is unchanged.

Stock Ubuntu runners only offer HDF5 1.10 through apt, which CMakeLists.txt
refuses, so both jobs mount sft.cern.ch and source an LCG view:

- hdf5-1_14: ubuntu-24.04, LCG_110 x86_64-ubuntu2404-gcc13-opt (HDF5 1.14.6)
- hdf5-1_12: ubuntu-22.04, LCG_105 x86_64-ubuntu2204-gcc11-opt (HDF5 1.12.2)

Each job runs ci/github-ci.sh, which configures with the new
SPINE_READER_REQUIRE_PYTHON=ON (a missing Python 3 now fails the
configuration instead of silently dropping the generated-model and
golden-member checks), builds, and runs ctest. The same script is the local
dry run, in CERN's SFT Ubuntu images on CVMFS (ci/EGM.md); both jobs pass
there on this commit.

ci/check_tag_version.sh refuses a release tag that differs from
project(VERSION). It is meant to be run before pushing a tag; CI runs it
again on tag pushes. The workflow has read-only permissions, no secrets,
and pins both actions by commit SHA.
@pgranger23
pgranger23 merged commit b274339 into main Nov 5, 2026
4 checks passed
@pgranger23
pgranger23 deleted the ci/github-actions branch November 5, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant