feat(Virtualizer): custom sizes management#46
Open
amen-souissi wants to merge 10 commits intomasterfrom
Open
Conversation
HyacintheK
reviewed
Mar 3, 2022
HyacintheK
reviewed
Mar 3, 2022
HyacintheK
reviewed
Mar 3, 2022
HyacintheK
reviewed
Mar 3, 2022
HyacintheK
reviewed
Mar 3, 2022
HyacintheK
reviewed
Mar 15, 2022
HyacintheK
reviewed
Mar 15, 2022
HyacintheK
reviewed
Mar 15, 2022
HyacintheK
reviewed
Mar 15, 2022
HyacintheK
reviewed
Mar 15, 2022
HyacintheK
reviewed
Mar 15, 2022
HyacintheK
reviewed
Mar 15, 2022
| while (result.length < numberOfIndexesToAdd && itemIndex > 0) { | ||
| if (!ignoredIndexes.includes(itemIndex) && itemIndex < maxLength) { | ||
| if (currentSize < maxSize) { | ||
| while (itemIndex > 0 && currentSize <= maxSize) { |
Contributor
There was a problem hiding this comment.
You can start from the first element in result
HyacintheK
reviewed
Mar 15, 2022
HyacintheK
reviewed
Mar 15, 2022
| while (itemIndex > 0 && currentSize <= maxSize) { | ||
| const itemSize = customSizes[itemIndex] || defaultItemSize; | ||
| const newSize = currentSize + itemSize - 10; | ||
| if (!localIgnoredIndexes[itemIndex] && itemIndex < maxLength && newSize <= maxSize) { |
Contributor
There was a problem hiding this comment.
use const in order to have a better understanding of it
HyacintheK
reviewed
Mar 15, 2022
HyacintheK
reviewed
Mar 15, 2022
HyacintheK
reviewed
Mar 15, 2022
HyacintheK
previously approved these changes
Mar 15, 2022
HyacintheK
reviewed
Oct 19, 2022
HyacintheK
reviewed
Oct 19, 2022
HyacintheK
reviewed
Oct 19, 2022
HyacintheK
reviewed
Oct 19, 2022
HyacintheK
reviewed
Oct 19, 2022
HyacintheK
reviewed
Oct 19, 2022
HyacintheK
previously approved these changes
Oct 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
custom sizes management
Upgrade versions (use react 18)
❤️ Thank you!