fix: honor case_sensitive flag in generate_merge_patch (#1007)#1058
Open
JIgar-maheshwari-dev wants to merge 1 commit into
Open
fix: honor case_sensitive flag in generate_merge_patch (#1007)#1058JIgar-maheshwari-dev wants to merge 1 commit into
JIgar-maheshwari-dev wants to merge 1 commit into
Conversation
Replace strcmp with compare_strings in cJSONUtils_GenerateMergePatch to ensure key comparisons respect the case_sensitive parameter. Fixes DaveGamble#1007 Signed-off-by: JIgar-maheshwari-dev <maheshwarijigar656@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1007
Overview
Fixes an inconsistency in
cJSONUtils_GenerateMergePatchwhere key comparisons ignored thecase_sensitiveparameter after sorting.Changes
strcmpat line 1391 incJSON_Utils.cwithcompare_strings(..., case_sensitive)to properly match keys whencase_sensitive == false.Verification
ENABLE_CJSON_UTILS=OnandENABLE_CJSON_TEST=On); all tests pass.