fix: add size_t overflow guard in ensure()#1057
Open
JIgar-maheshwari-dev wants to merge 1 commit into
Open
Conversation
Add a boundary check in ensure() before adding p->offset + 1 to needed. This prevents potential size_t wrap-around on 32-bit systems when handling large buffer offsets. Signed-off-by: JIgar-maheshwari-dev <maheshwarijigar656@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1007
Overview
Adds a boundary check to
ensure()incJSON.cto prevent potential integer wrap-around on 32-bit architectures.Changes
if (p->offset > SIZE_MAX - 1 - needed) return NULL;prior to calculatingneeded += p->offset + 1.Motivation
On 32-bit systems with large existing buffer offsets (
p->offset), addingp->offset + 1toneededcould exceedSIZE_MAXand wrap around, causingrealloc()to allocate an undersized buffer.Verification