Skip to content

fix: bump a volume mount's version when the secret behind it changes #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nilsonfh wants to merge 1 commit into from
Closed

fix: bump a volume mount's version when the secret behind it changes #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/services/secret-service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ async function updateSecretEndpoint (secretName, secretData, transaction) {
validateSecretData(nextType, secretData.data)

const secret = await SecretManager.updateSecret(secretName, nextType, secretData.data, transaction)
await _bumpVolumeMountsUsingSecret(secretName, transaction)
await _updateChangeTrackingForFogs(secretName, transaction)
await _updateMicroservicesUsingSecret(secretName, transaction)
return {
Expand Down Expand Up @@ -208,6 +209,26 @@ async function deleteSecretEndpoint (secretName, transaction) {
return {}
}

// A node only re-materialises a volume mount whose version is greater than the
// one it holds ("Skipping update - new version 1 not greater than current
// version 1" in the agent's journal), and nothing bumped that version when the
// secret behind the mount changed: every linked node kept the old content, so no
// rotation of keys, credentials or TLS material ever arrived.
//
// Bumped on every update rather than only when the data differs: a PATCH is an
// explicit instruction to set this secret, and the stored copy lives in the
// vault, so comparing stored with posted is not a hash of the request body.
async function _bumpVolumeMountsUsingSecret (secretName, transaction) {
const volumeMounts = await VolumeMountingManager.findAll({ secretName }, transaction)
for (const volumeMount of volumeMounts) {
await VolumeMountingManager.update(
{ name: volumeMount.name },
{ version: volumeMount.version + 1 },
transaction
)
}
}

async function _deleteVolumeMountsUsingSecret (secretName, transaction) {
const volumeMounts = await VolumeMountingManager.findAll({ secretName }, transaction)
if (volumeMounts.length > 0) {
Expand Down