Repository navigation
fix: request-validator hardening (#192, heuristic scope) - #199
Merged
Merged
Conversation
…mber/boolean validation, server-owned cache params (#192) - Collapse whitespace and inspect the whole value when it contains a quote - Validate number/float/double/boolean/integer/bool strictly - cacheTable/cacheSchema/cacheCatalog are assigned, not emplaced - Docs: bound {{ }} is the defence; the screen is a safety net - Real-binary tests: 85 cases - Refs #192 (structural binding of triple-brace values deliberately not done)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the crew review; reproduced against a real binary first. Scope chosen by you: heuristic hardening only (structural binding of triple-brace values is not done; the docs now state that bound
{{ }}is the real defence).Summary
x'<newline>OR 2>1<newline>OR n = 'xreturned every row on'{{{ params.name }}}'. The screen now collapses whitespace and inspects the whole value when it contains a quote.number/float/double/boolean(+integer/bool) were bindable-classified (skipping the screen) with no validation;0 OR truepassed. Now strictly validated.?cacheTable=...overrode the server-owned cache table/schema/catalog; now always the configured values.Behaviour change
A value with a single quote AND an SQL-looking char/word (
( ) = < > + * / % & | ;, or/and/like...) is rejected even for a bound{{ }}site (e.g.O'Brien (retired)); a lone apostrophe is fine;preventSqlInjection: falseopts out per field.Test plan
Refs #192 (stays open for the structural fix if you want it later)
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.