Skip to content

Add support for multi row reorder #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piradoiv wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for multi row reorder #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31edfe1
Add support for multi row reorder
piradoiv Mar 26, 2025
f84d6eb
Line styling
piradoiv Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions examples/initialisation/multiRowReorder.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?xml version="1.0" encoding="UTF-8" ?>
<dt-example table-type="sequence" table-class="display" order="10">
<title lib="RowReorder">Multi row reorder</title>

<css lib="datatables rowreorder select" />
<js lib="jquery datatables rowreorder select">
<![CDATA[
$('#example').DataTable({
select: true,
rowReorder: true,
selector: 'tr',
select: 'os',
});
]]>
</js>

<js-vanilla>
<![CDATA[
let table = new DataTable('#example', {
select: true,
rowReorder: true,
selector: 'tr',
select: 'os',
});
]]>
</js-vanilla>

<info><![CDATA[
The following example demonstrates how the RowReorder extension can work together with Select, if it's in use, in order to make multiple row reordering possible.
]]></info>

</dt-example>
41 changes: 37 additions & 4 deletions js/dataTables.rowReorder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,9 @@ $.extend(RowReorder.prototype, {
// Match the table and column widths - read all sizes before setting
// to reduce reflows
var tableWidth = target.outerWidth();
var tableHeight = target.outerHeight();
var tableHeight = target.toArray()
.map(function (el) { return $(el).outerHeight(); })
.reduce(function (accum, val) { return accum + val; });
var scrollBody = $($(this.s.dt.table().node()).parent());
var scrollWidth = scrollBody.width();
var scrollLeft = scrollBody.scrollLeft();
Expand Down Expand Up @@ -362,6 +364,26 @@ $.extend(RowReorder.prototype, {
start.offsetLeft = offset.left;
start.nodes = $.unique(dt.rows({ page: 'current' }).nodes().toArray());

var targetRow = dt.row($(target));
// Only execute this code if the Select extension is being used
if (typeof targetRow.select !== "undefined" && typeof targetRow.selected !== "undefined") {
// If we are dragging a row that is not selected, but there are other selected rows, we'll deselect
// them first, and then select the current target
var selectedRows = [];
$.merge(selectedRows, target.siblings('.selected'));
if (selectedRows.length > 0 && !targetRow.selected()) {
// We might want to remove the previous selection, unless the user is adding more keys by
// pressing keyboard combinations, in that case, let Select do its job
if (e.shiftKey || e.metaKey || e.ctrlKey) {
return;
}

dt.rows().deselect();
}

$.merge(target, target.siblings('.selected'));
}

this._cachePositions();
this._clone(target);
this._clonePosition(e);
Expand Down Expand Up @@ -518,7 +540,7 @@ $.extend(RowReorder.prototype, {
dataSrc: dataSrc,
nodes: diffNodes,
values: idDiff,
triggerRow: dt.row(this.dom.target),
triggerRow: dt.rows(this.dom.target),
originalEvent: e
}
];
Expand Down Expand Up @@ -602,12 +624,23 @@ $.extend(RowReorder.prototype, {
var nodes = $.unique(dt.rows({ page: 'current' }).nodes().toArray());
var insertPlacement = '';

var nodeInsertPoint = nodes[insertPoint];
if (insertPoint > this.s.lastInsert) {
this.dom.target.insertAfter(nodes[insertPoint - 1]);
var buffer = this.dom.target.length-1;

if (!nodes[insertPoint + buffer]) {
this.dom.target.appendTo(dt.table().body());
} else if ($(nodeInsertPoint).hasClass('dt-rowReorder-moving')) {
this.dom.target.insertBefore(nodes[insertPoint + buffer]);
} else {
this.dom.target.insertAfter(nodes[insertPoint + buffer - 1]);
}
insertPlacement = 'after';
}
else {
this.dom.target.insertBefore(nodes[insertPoint]);
if (!$(nodeInsertPoint).hasClass('dt-rowReorder-moving')) {
this.dom.target.insertBefore(nodeInsertPoint);
}
insertPlacement = 'before';
}

Expand Down