[HOLD] feat: show cloud share button and remove legacy share UI#1295
Open
wcchang1115 wants to merge 2 commits intomainfrom
Open
[HOLD] feat: show cloud share button and remove legacy share UI#1295wcchang1115 wants to merge 2 commits intomainfrom
wcchang1115 wants to merge 2 commits intomainfrom
Conversation
Reverts PR #1281 to make CloudShareButtonOss visible in the nav bar and remove the legacy TopLevelShare button and "Share to Cloud" menu items from RunResultPane. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Wei-Chun, Chang <wcchang@infuseai.io>
wcchang1115
changed the title
…ible-and-remove-legacy-share
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
What type of PR is this?
Feature (UI visibility change)
What this PR does / why we need it:
Reverts PR #1281 to make the cloud share feature visible for public release:
CloudShareButtonOssrendering in the nav bar right sectionTopLevelSharefrom the nav bar center sectionRunResultPaneWhich issue(s) this PR fixes:
Special notes for your reviewer:
This is an exact inverse of #1281. All cloud share implementation code (
CloudShareButtonOss,CloudUploadDialogOss, backend endpoints, API client) was already in place — this PR only changes UI visibility.Does this PR introduce a user-facing change?:
Yes — the Cloud Share button is now visible in the nav bar, replacing the legacy TopLevelShare button.
🤖 Generated with Claude Code