Skip to content

Package updates & linter/typing fixes - #30

Merged
aarthy-dk merged 1 commit into
DataKitchen:mainfrom
induane:pkg-and-dep-tweak
Sep 23, 2026
Merged

aarthy-dk merged 1 commit into
DataKitchen:mainfrom
induane:pkg-and-dep-tweak

Conversation

@induane

@induane induane commented Jun 19, 2025

Copy link
Copy Markdown
Contributor
  • Removed empty config.cfg hack (it was an ancient workaround for a problem that no longer exists)
  • Updated ruff formatter config to format as python3.13 (the version of python used by the project)
  • Fixed some outdated README.md text
  • Upgraded mypy version
  • Fixed type hint complaints from mypy
  • Updated pytest & pytest plugin versions (fixes several noisy deprecation warnings)

@induane
induane force-pushed the pkg-and-dep-tweak branch from 9b3f723 to 34815a2 Compare April 16, 2026 10:39
@induane

induane commented Apr 16, 2026

Copy link
Copy Markdown
Contributor Author

@rboni-dk @aarthy-dk @datakitchen-devops this has been up a spell (I just rebased it). Are you all active accepting commits?

Comment thread common/entity_services/helpers/filter_rules.py
Comment thread common/entity_services/helpers/filter_rules.py
Comment thread common/entity_services/helpers/filter_rules.py
@aarthy-dk

Copy link
Copy Markdown
Contributor

Apologies @induane, we lost track of this one - thanks for the ping!

I left some comments on your changes. Some newer fields in one of the files got dropped. Good to merge in after that is fixed.

- Removed empty config.cfg hack (it was an ancient workaround for a problem that no longer exists)
- Updated ruff formatter config to format as python3.13 (the version of python used by the project)
- Fixed some outdated readme text
- Upgraded mypy version
- Fixed type hint complaints from mypy
- Updated pytest & pytest plugin versions (fixes several noisy deprecation warnings)
@induane

induane commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

Apologies @induane, we lost track of this one - thanks for the ping!

I left some comments on your changes. Some newer fields in one of the files got dropped. Good to merge in after that is fixed.

Hey @aarthy-dk I updated the PR; it had been a spell so I reran the formatter as well and cleaned up some inconsistent line endings and the like that had crept in.

@aarthy-dk aarthy-dk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aarthy-dk
aarthy-dk merged commit 83e38e1 into DataKitchen:main Sep 23, 2026
@induane
induane deleted the pkg-and-dep-tweak branch September 23, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants