Add unit metadata to columns#2149
Merged
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change introduces a structured, column-level unit field as the long-term home for unit metadata in DJ. Previously unit lived only on
metricmetadataas a flat enum (MetricUnit) and only applied to metric output values. This PR adds the new field to columns, including on all associated column objects likeColumn(ORM),ColumnSpec(YAML),ColumnOutput(API). The legacymetricmetadata.unitpath continues to work unchanged; subsequent PRs will wire it through.Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan