Preserve Column Display Name + Script for Column Order#1755
Merged
shangyian merged 3 commits intoDataJunction:mainfrom Feb 15, 2026
Merged
Preserve Column Display Name + Script for Column Order#1755shangyian merged 3 commits intoDataJunction:mainfrom
shangyian merged 3 commits intoDataJunction:mainfrom
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
shangyian
changed the title
shangyian
force-pushed
the
fix-display-name
branch
from
20b47c7 to
0c07e48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes two bugs during YAML deployment around (a) column display name being reset to an inferred default based off of the column name and (b) the ordering of columns being wrong in the generated YAML file.
Column Display Name
We need to preserve each column's display name when deploying nodes.
Columns Order
There was previously an issue where column order index was not saved during YAML deployments. That meant that any nodes deployed from YAML weren't storing order at all, and so when a branch was created, would not inherit a set order.
This adds a script for the column ordering.
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan