Skip to content

Add non-blocking node deletion validation to deployments#1754

Merged
shangyian merged 3 commits intoDataJunction:mainfrom
shangyian:enable-missing-deps
Feb 15, 2026
Merged

Add non-blocking node deletion validation to deployments#1754
shangyian merged 3 commits intoDataJunction:mainfrom
shangyian:enable-missing-deps

Conversation

@shangyian
Copy link
Collaborator

@shangyian shangyian commented Feb 12, 2026

Summary

When deploying node deletions, we should allow deployments to proceed even when the deleted nodes have references, but mark those specific node deployments as failed. The overall deployment status will also be failed, providing clear feedback about what couldn't be deleted and why.

Previously, deleting a node during deployment, we would not validate if there were any downstream or dimension link references to this node. If any node had references, they would be rendered invalid, but we wouldn't make this obvious to the user as a part of the deployment process, so users would discover this issue much later, with no visibility into which deletion caused what failure and why.

This change adds a validation stage after node deletion. This validation is non-blocking and involves:

  1. Checking for references by querying for nodes that depend on nodes being deleted (via parent relationships or dimension links).
  2. Allowing the rest of the deployment to proceed and return individual deployment results
  3. Mark nodes with deleted node references as failed.
  4. Fail overall deployment

Test Plan

  • PR has an associated issue: #
  • make check passes
  • make test shows 100% unit test coverage

Deployment Plan

@netlify
Copy link

netlify bot commented Feb 12, 2026

Deploy Preview for thriving-cassata-78ae72 canceled.

Name Link
🔨 Latest commit 11f3770
🔍 Latest deploy log https://app.netlify.com/projects/thriving-cassata-78ae72/deploys/6991a61f128eb300086e832d

@shangyian shangyian changed the title Allow missing dependencies for branch deployment Changed node deletion validation to be non-blocking Feb 12, 2026
@shangyian shangyian changed the title Changed node deletion validation to be non-blocking Add non-blocking node deletion validation to deployments Feb 12, 2026
…g exceptions. This enables us to actually deploy any particular set of nodes and just display the status as failed rather than not deploying anything at all
@shangyian shangyian marked this pull request as ready for review February 15, 2026 12:04
@shangyian shangyian merged commit 2d72e67 into DataJunction:main Feb 15, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant