Add non-blocking node deletion validation to deployments#1754
Merged
shangyian merged 3 commits intoDataJunction:mainfrom Feb 15, 2026
Merged
Add non-blocking node deletion validation to deployments#1754shangyian merged 3 commits intoDataJunction:mainfrom
shangyian merged 3 commits intoDataJunction:mainfrom
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
b0955c1 to
4a1c1cb
Compare
…g exceptions. This enables us to actually deploy any particular set of nodes and just display the status as failed rather than not deploying anything at all
4a1c1cb to
11f3770
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When deploying node deletions, we should allow deployments to proceed even when the deleted nodes have references, but mark those specific node deployments as failed. The overall deployment status will also be failed, providing clear feedback about what couldn't be deleted and why.
Previously, deleting a node during deployment, we would not validate if there were any downstream or dimension link references to this node. If any node had references, they would be rendered invalid, but we wouldn't make this obvious to the user as a part of the deployment process, so users would discover this issue much later, with no visibility into which deletion caused what failure and why.
This change adds a validation stage after node deletion. This validation is non-blocking and involves:
Test Plan
make checkpassesmake testshows 100% unit test coverageDeployment Plan