Conversation
jonnypress
reviewed
Aug 2, 2021
code/gateway/dataaccess.q
Outdated
| // Use upserting logic to determine behaviour | ||
| options::default,o; | ||
| if[`ordering in key o;options[`ordering]: go each options`ordering]; | ||
| o::adjustqueries[o;partdict o]; |
Contributor
There was a problem hiding this comment.
Why are o and options global variables? Can't the pre-processing funtion just return a result?
code/gateway/kxdash.q
Outdated
| @@ -1,6 +1,5 @@ | |||
| \c 200 2000 | |||
Contributor
There was a problem hiding this comment.
don't think we want this
code/gateway/kxdash.q
Outdated
| } | ||
|
|
||
| //Define the current .z.ps as a new function to be called in dashps | ||
| .z.ops:@[.:;`.z.ps;{.:}]; |
Contributor
There was a problem hiding this comment.
don't use .z name space for custom functions
Also I think that should be value rather than .:
jonnypress
approved these changes
Nov 30, 2021
Contributor
|
@robertcoen can you squash and merge this if it's good to go? |
jonnypress
approved these changes
Feb 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow dataaccess queries to be executed from kx dashboards and also maintain TorQ's .z.ps functionality for queries made from kx dashboards.