Gitlab unify#7017
Draft
nccatoni wants to merge 25 commits into
Draft
Conversation
Contributor
|
|
|
dockerssi.yml and libinjection.yml were rendered by build_pipeline.py until commit b97ab0a moved docker/k8s SSI generation back into the SSI pipeline (gitlab_exporter.py). The Jinja2 templates and their tests became dead code, and the tests now fail because the corresponding CLI flags were also removed from build_pipeline.py. The --workflows flag on compute-workflow-parameters.py had a single call site in aws-ssi.yml that was reverted in the same commit, leaving the flag with no callers.
The pipeline covers all SSI workflows (aws_ssi, dockerssi, libinjection), not just AWS. Also update the stale header comment that incorrectly claimed Docker/K8s SSI scenarios run from main.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present