fix(auth): support --subdomain login for orgs on non-US1 regions#551
Open
haru0017 wants to merge 1 commit into
Open
fix(auth): support --subdomain login for orgs on non-US1 regions#551haru0017 wants to merge 1 commit into
haru0017 wants to merge 1 commit into
Conversation
Use the OAuth callback's domain parameter to determine the correct token exchange endpoint instead of the configured site. - Propagate domain through CallbackResult - Use effective_site for token exchange, token storage, and session storage - Fall back to configured site when domain is absent Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
haru0017
force-pushed
the
fix/oauth-subdomain-site-mismatch
branch
from
76e6dc2 to
4dcd6a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use the
domainparameter from the OAuth callback to determine the correct token exchange endpoint. Previously,--subdomainlogin failed withinvalid_grantfor orgs on non-US1 regions because the token exchange was always sent toapi.datadoghq.com.Motivation
Vanity subdomains can be on a different domain than the org's actual API endpoint (e.g. subdomain on datadoghq.com while the org is on us3.datadoghq.com). When using
--subdomain, the authorization URL is correct but the token exchange targets the wrong site. The OAuth callback already includes adomainparameter with the actual site, but it was only used for the success page HTML.Additional Notes
N/A
Checklist
Related Issues
Closes #550