feat(annotations): add dashboard/notebook annotations commands#547
Merged
platinummonkey merged 2 commits intoMay 30, 2026
Merged
Conversation
New pup annotations domain wrapping the Annotations API v2 (SDK #1631): list, get-page, create, update, delete. Registers the 5 annotation operations as unstable ops (162 -> 167). Co-Authored-By: Claude <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Annotations attach to a page (dashboard:<id> or notebook:<id>), so expose the actions under both `pup dashboards annotations` and `pup notebooks annotations` via a shared run_annotations dispatch, instead of a top-level `pup annotations` domain. Removing the top-level variant also fixes the alphabetical-order check in test_commands.rs. Co-Authored-By: Claude <noreply@anthropic.com>
74f55a8
into
chore/upgrade-dd-sdk-to-master
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Annotations API v2 (SDK #1631) to pup. Annotations attach to a page —
dashboard:<id>ornotebook:<id>— and mark moments/regions in time on dashboard and notebook widgets, so the commands are nested under bothpup dashboards annotationsandpup notebooks annotations(sharing one module), rather than a top-level domain.Changes
src/commands/annotations.rs— new module:list,get_page,create,update,deletesrc/commands/mod.rs— register the modulesrc/client.rs— register the 5 annotation ops as unstable (UNSTABLE_OPS162 → 167)src/main.rs—Annotationssubcommand added to bothDashboardActionsandNotebookActions, dispatched through a sharedrun_annotationshelperdocs/COMMANDS.md— documented under the dashboards and notebooks rowsNew commands
Testing
cargo testgreen,cargo fmt --checkclean,cargo clippyclean (no warnings in pup code). Top-level command alphabetical-order check passes (no new top-level command added).🤖 Generated with Claude Code