refactor(statsd)!: make client clonable#2222
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
📚 Documentation Check Results📦
|
🔒 Cargo Deny Results📦
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 395fb45 | Docs | Datadog PR Page | Give us feedback! |
158eed0 to
597364e
Compare
BenchmarksComparisonBenchmark execution time: 2026-07-13 12:28:40 Comparing candidate commit 395fb45 in PR branch Found 2 performance improvements and 2 performance regressions! Performance is the same for 20 metrics, 0 unstable metrics.
|
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 395fb45 | 1783944961 | vianney/statsd-client-refactor |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| trace_buffer/1_senders/10us_delay | execution_time | 56.323ms | 56.538ms ± 0.123ms | 56.519ms ± 0.067ms | 56.601ms | 56.745ms | 56.987ms | 57.061ms | 0.96% | 1.346 | 3.175 | 0.22% | 0.009ms | 1 | 200 |
| trace_buffer/1_senders/10us_delay | throughput | 15772.599op/s | 15918.558op/s ± 34.555op/s | 15923.730op/s ± 18.879op/s | 15940.969op/s | 15966.412op/s | 15973.796op/s | 15979.314op/s | 0.35% | -1.324 | 3.090 | 0.22% | 2.443op/s | 1 | 200 |
| trace_buffer/1_senders/1us_delay | execution_time | 50.028ms | 50.081ms ± 0.026ms | 50.079ms ± 0.011ms | 50.089ms | 50.130ms | 50.174ms | 50.184ms | 0.21% | 1.401 | 3.669 | 0.05% | 0.002ms | 1 | 200 |
| trace_buffer/1_senders/1us_delay | throughput | 17933.959op/s | 17971.011op/s ± 9.238op/s | 17971.434op/s ± 4.054op/s | 17976.247op/s | 17983.067op/s | 17988.557op/s | 17990.095op/s | 0.10% | -1.396 | 3.650 | 0.05% | 0.653op/s | 1 | 200 |
| trace_buffer/1_senders/no_delay | execution_time | 333.616µs | 339.981µs ± 4.158µs | 339.162µs ± 1.710µs | 341.108µs | 344.880µs | 352.725µs | 381.350µs | 12.44% | 5.401 | 48.188 | 1.22% | 0.294µs | 1 | 200 |
| trace_buffer/1_senders/no_delay | throughput | 2360036.236op/s | 2647576.145op/s ± 30507.009op/s | 2653599.191op/s ± 13321.560op/s | 2663716.746op/s | 2677507.963op/s | 2686601.112op/s | 2697710.681op/s | 1.66% | -4.694 | 38.802 | 1.15% | 2157.171op/s | 1 | 200 |
| trace_buffer/2_senders/10us_delay | execution_time | 56.689ms | 57.125ms ± 0.189ms | 57.114ms ± 0.147ms | 57.264ms | 57.438ms | 57.600ms | 57.623ms | 0.89% | 0.232 | -0.417 | 0.33% | 0.013ms | 1 | 200 |
| trace_buffer/2_senders/10us_delay | throughput | 31237.393op/s | 31510.002op/s ± 104.080op/s | 31515.733op/s ± 81.055op/s | 31593.479op/s | 31673.519op/s | 31718.494op/s | 31751.931op/s | 0.75% | -0.217 | -0.429 | 0.33% | 7.360op/s | 1 | 200 |
| trace_buffer/2_senders/1us_delay | execution_time | 50.057ms | 50.112ms ± 0.033ms | 50.108ms ± 0.019ms | 50.125ms | 50.177ms | 50.209ms | 50.239ms | 0.26% | 1.168 | 1.431 | 0.06% | 0.002ms | 1 | 200 |
| trace_buffer/2_senders/1us_delay | throughput | 35828.947op/s | 35919.665op/s ± 23.352op/s | 35922.546op/s ± 13.451op/s | 35936.225op/s | 35948.798op/s | 35954.265op/s | 35958.678op/s | 0.10% | -1.164 | 1.419 | 0.06% | 1.651op/s | 1 | 200 |
| trace_buffer/2_senders/no_delay | execution_time | 848.940µs | 887.682µs ± 18.216µs | 887.441µs ± 11.388µs | 898.520µs | 916.346µs | 934.268µs | 981.785µs | 10.63% | 0.841 | 2.857 | 2.05% | 1.288µs | 1 | 200 |
| trace_buffer/2_senders/no_delay | throughput | 1833394.411op/s | 2028590.143op/s ± 41023.288op/s | 2028303.824op/s ± 26025.083op/s | 2055483.183op/s | 2093199.226op/s | 2110006.057op/s | 2120290.004op/s | 4.54% | -0.609 | 1.880 | 2.02% | 2900.785op/s | 1 | 200 |
| trace_buffer/4_senders/10us_delay | execution_time | 57.290ms | 57.553ms ± 0.111ms | 57.552ms ± 0.069ms | 57.619ms | 57.756ms | 57.839ms | 57.931ms | 0.66% | 0.452 | 0.449 | 0.19% | 0.008ms | 1 | 200 |
| trace_buffer/4_senders/10us_delay | throughput | 62142.478op/s | 62551.369op/s ± 120.954op/s | 62552.247op/s ± 75.159op/s | 62630.988op/s | 62731.726op/s | 62805.692op/s | 62838.736op/s | 0.46% | -0.439 | 0.431 | 0.19% | 8.553op/s | 1 | 200 |
| trace_buffer/4_senders/1us_delay | execution_time | 50.088ms | 50.164ms ± 0.036ms | 50.156ms ± 0.015ms | 50.174ms | 50.237ms | 50.290ms | 50.303ms | 0.29% | 1.450 | 2.510 | 0.07% | 0.003ms | 1 | 200 |
| trace_buffer/4_senders/1us_delay | throughput | 71566.631op/s | 71764.001op/s ± 51.302op/s | 71776.648op/s ± 20.814op/s | 71793.717op/s | 71823.951op/s | 71842.280op/s | 71874.179op/s | 0.14% | -1.445 | 2.493 | 0.07% | 3.628op/s | 1 | 200 |
| trace_buffer/4_senders/no_delay | execution_time | 2.307ms | 2.478ms ± 0.053ms | 2.480ms ± 0.033ms | 2.515ms | 2.562ms | 2.584ms | 2.596ms | 4.67% | -0.364 | 0.142 | 2.14% | 0.004ms | 1 | 200 |
| trace_buffer/4_senders/no_delay | throughput | 1386897.593op/s | 1453401.884op/s ± 31411.232op/s | 1451613.740op/s ± 19522.284op/s | 1470112.204op/s | 1512409.211op/s | 1534969.327op/s | 1560283.504op/s | 7.49% | 0.496 | 0.334 | 2.16% | 2221.110op/s | 1 | 200 |
| trace_buffer/8_senders/10us_delay | execution_time | 57.613ms | 57.889ms ± 0.186ms | 57.823ms ± 0.097ms | 57.994ms | 58.267ms | 58.391ms | 58.510ms | 1.19% | 1.031 | 0.421 | 0.32% | 0.013ms | 1 | 200 |
| trace_buffer/8_senders/10us_delay | throughput | 123056.660op/s | 124377.048op/s ± 398.271op/s | 124517.047op/s ± 208.893op/s | 124679.261op/s | 124830.558op/s | 124923.949op/s | 124971.671op/s | 0.37% | -1.019 | 0.384 | 0.32% | 28.162op/s | 1 | 200 |
| trace_buffer/8_senders/1us_delay | execution_time | 50.196ms | 50.280ms ± 0.051ms | 50.267ms ± 0.026ms | 50.304ms | 50.390ms | 50.415ms | 50.502ms | 0.47% | 1.244 | 1.732 | 0.10% | 0.004ms | 1 | 200 |
| trace_buffer/8_senders/1us_delay | throughput | 142567.654op/s | 143198.468op/s ± 144.307op/s | 143235.100op/s ± 72.931op/s | 143294.035op/s | 143374.712op/s | 143390.007op/s | 143437.487op/s | 0.14% | -1.237 | 1.706 | 0.10% | 10.204op/s | 1 | 200 |
| trace_buffer/8_senders/no_delay | execution_time | 6.217ms | 6.551ms ± 0.105ms | 6.565ms ± 0.058ms | 6.618ms | 6.671ms | 6.729ms | 7.170ms | 9.21% | 0.287 | 5.747 | 1.60% | 0.007ms | 1 | 200 |
| trace_buffer/8_senders/no_delay | throughput | 1004221.029op/s | 1099385.464op/s ± 17597.959op/s | 1096683.979op/s ± 9701.248op/s | 1107849.476op/s | 1129798.003op/s | 1149011.873op/s | 1158143.597op/s | 5.60% | 0.046 | 4.324 | 1.60% | 1244.364op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| trace_buffer/1_senders/10us_delay | execution_time | [56.521ms; 56.555ms] or [-0.030%; +0.030%] | None | None | None |
| trace_buffer/1_senders/10us_delay | throughput | [15913.770op/s; 15923.347op/s] or [-0.030%; +0.030%] | None | None | None |
| trace_buffer/1_senders/1us_delay | execution_time | [50.077ms; 50.084ms] or [-0.007%; +0.007%] | None | None | None |
| trace_buffer/1_senders/1us_delay | throughput | [17969.731op/s; 17972.291op/s] or [-0.007%; +0.007%] | None | None | None |
| trace_buffer/1_senders/no_delay | execution_time | [339.405µs; 340.557µs] or [-0.170%; +0.170%] | None | None | None |
| trace_buffer/1_senders/no_delay | throughput | [2643348.167op/s; 2651804.123op/s] or [-0.160%; +0.160%] | None | None | None |
| trace_buffer/2_senders/10us_delay | execution_time | [57.099ms; 57.152ms] or [-0.046%; +0.046%] | None | None | None |
| trace_buffer/2_senders/10us_delay | throughput | [31495.578op/s; 31524.427op/s] or [-0.046%; +0.046%] | None | None | None |
| trace_buffer/2_senders/1us_delay | execution_time | [50.107ms; 50.116ms] or [-0.009%; +0.009%] | None | None | None |
| trace_buffer/2_senders/1us_delay | throughput | [35916.429op/s; 35922.901op/s] or [-0.009%; +0.009%] | None | None | None |
| trace_buffer/2_senders/no_delay | execution_time | [885.157µs; 890.207µs] or [-0.284%; +0.284%] | None | None | None |
| trace_buffer/2_senders/no_delay | throughput | [2022904.710op/s; 2034275.576op/s] or [-0.280%; +0.280%] | None | None | None |
| trace_buffer/4_senders/10us_delay | execution_time | [57.537ms; 57.568ms] or [-0.027%; +0.027%] | None | None | None |
| trace_buffer/4_senders/10us_delay | throughput | [62534.606op/s; 62568.132op/s] or [-0.027%; +0.027%] | None | None | None |
| trace_buffer/4_senders/1us_delay | execution_time | [50.159ms; 50.169ms] or [-0.010%; +0.010%] | None | None | None |
| trace_buffer/4_senders/1us_delay | throughput | [71756.891op/s; 71771.111op/s] or [-0.010%; +0.010%] | None | None | None |
| trace_buffer/4_senders/no_delay | execution_time | [2.471ms; 2.485ms] or [-0.297%; +0.297%] | None | None | None |
| trace_buffer/4_senders/no_delay | throughput | [1449048.589op/s; 1457755.179op/s] or [-0.300%; +0.300%] | None | None | None |
| trace_buffer/8_senders/10us_delay | execution_time | [57.863ms; 57.915ms] or [-0.045%; +0.045%] | None | None | None |
| trace_buffer/8_senders/10us_delay | throughput | [124321.852op/s; 124432.245op/s] or [-0.044%; +0.044%] | None | None | None |
| trace_buffer/8_senders/1us_delay | execution_time | [50.273ms; 50.287ms] or [-0.014%; +0.014%] | None | None | None |
| trace_buffer/8_senders/1us_delay | throughput | [143178.469op/s; 143218.468op/s] or [-0.014%; +0.014%] | None | None | None |
| trace_buffer/8_senders/no_delay | execution_time | [6.536ms; 6.565ms] or [-0.222%; +0.222%] | None | None | None |
| trace_buffer/8_senders/no_delay | throughput | [1096946.556op/s; 1101824.372op/s] or [-0.222%; +0.222%] | None | None | None |
Group 1
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 395fb45 | 1783944961 | vianney/statsd-client-refactor |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| write only interface | execution_time | 1.035µs | 1.049µs ± 0.004µs | 1.051µs ± 0.002µs | 1.052µs | 1.054µs | 1.058µs | 1.060µs | 0.91% | -0.814 | 0.759 | 0.39% | 0.000µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| write only interface | execution_time | [1.049µs; 1.050µs] or [-0.055%; +0.055%] | None | None | None |
Group 2
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 395fb45 | 1783944961 | vianney/statsd-client-refactor |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| two way interface | execution_time | 15.185µs | 15.662µs ± 0.422µs | 15.615µs ± 0.100µs | 15.718µs | 15.859µs | 16.510µs | 20.705µs | 32.59% | 9.230 | 103.174 | 2.69% | 0.030µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| two way interface | execution_time | [15.604µs; 15.720µs] or [-0.373%; +0.373%] | None | None | None |
Group 3
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | 395fb45 | 1783944961 | vianney/statsd-client-refactor |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | 8.431ms | 8.459ms ± 0.018ms | 8.456ms ± 0.013ms | 8.471ms | 8.491ms | 8.498ms | 8.525ms | 0.82% | 0.680 | -0.041 | 0.21% | 0.001ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | [8.457ms; 8.462ms] or [-0.029%; +0.029%] | None | None | None |
Baseline
Baseline benchmark details
Group 1
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | ade7821 | 1783728750 | main |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| trace_buffer/1_senders/10us_delay | execution_time | 56.340ms | 56.559ms ± 0.201ms | 56.525ms ± 0.076ms | 56.601ms | 56.815ms | 57.546ms | 57.565ms | 1.84% | 3.202 | 12.655 | 0.35% | 0.014ms | 1 | 200 |
| trace_buffer/1_senders/10us_delay | throughput | 15634.621op/s | 15912.684op/s ± 55.795op/s | 15922.285op/s ± 21.441op/s | 15943.405op/s | 15962.148op/s | 15972.390op/s | 15974.559op/s | 0.33% | -3.155 | 12.356 | 0.35% | 3.945op/s | 1 | 200 |
| trace_buffer/1_senders/1us_delay | execution_time | 50.030ms | 50.086ms ± 0.034ms | 50.082ms ± 0.013ms | 50.094ms | 50.154ms | 50.183ms | 50.191ms | 0.22% | 0.988 | 0.854 | 0.07% | 0.002ms | 1 | 200 |
| trace_buffer/1_senders/1us_delay | throughput | 17931.653op/s | 17969.090op/s ± 12.276op/s | 17970.555op/s ± 4.818op/s | 17976.138op/s | 17986.696op/s | 17988.778op/s | 17989.204op/s | 0.10% | -0.984 | 0.847 | 0.07% | 0.868op/s | 1 | 200 |
| trace_buffer/1_senders/no_delay | execution_time | 338.352µs | 345.652µs ± 4.891µs | 345.224µs ± 2.371µs | 347.479µs | 351.800µs | 354.647µs | 394.538µs | 14.28% | 5.172 | 48.207 | 1.41% | 0.346µs | 1 | 200 |
| trace_buffer/1_senders/no_delay | throughput | 2281150.573op/s | 2604261.551op/s ± 34552.997op/s | 2607005.218op/s ± 18008.556op/s | 2626599.546op/s | 2642781.285op/s | 2653613.554op/s | 2659949.347op/s | 2.03% | -4.274 | 36.598 | 1.32% | 2443.266op/s | 1 | 200 |
| trace_buffer/2_senders/10us_delay | execution_time | 56.556ms | 56.984ms ± 0.186ms | 56.962ms ± 0.128ms | 57.096ms | 57.304ms | 57.476ms | 57.523ms | 0.99% | 0.341 | -0.085 | 0.33% | 0.013ms | 1 | 200 |
| trace_buffer/2_senders/10us_delay | throughput | 31291.598op/s | 31588.176op/s ± 102.845op/s | 31600.189op/s ± 70.755op/s | 31653.573op/s | 31745.983op/s | 31785.239op/s | 31827.080op/s | 0.72% | -0.323 | -0.104 | 0.32% | 7.272op/s | 1 | 200 |
| trace_buffer/2_senders/1us_delay | execution_time | 50.062ms | 50.109ms ± 0.027ms | 50.107ms ± 0.016ms | 50.122ms | 50.164ms | 50.205ms | 50.210ms | 0.21% | 1.192 | 2.222 | 0.05% | 0.002ms | 1 | 200 |
| trace_buffer/2_senders/1us_delay | throughput | 35849.543op/s | 35921.490op/s ± 19.294op/s | 35923.182op/s ± 11.388op/s | 35934.707op/s | 35946.918op/s | 35951.576op/s | 35955.226op/s | 0.09% | -1.188 | 2.207 | 0.05% | 1.364op/s | 1 | 200 |
| trace_buffer/2_senders/no_delay | execution_time | 868.454µs | 928.714µs ± 17.105µs | 929.295µs ± 9.031µs | 938.365µs | 951.273µs | 966.379µs | 1010.926µs | 8.78% | -0.180 | 3.716 | 1.84% | 1.210µs | 1 | 200 |
| trace_buffer/2_senders/no_delay | throughput | 1780545.343op/s | 1938822.386op/s ± 35929.265op/s | 1936952.920op/s ± 18900.841op/s | 1955839.228op/s | 1994380.877op/s | 2059557.190op/s | 2072648.357op/s | 7.01% | 0.481 | 3.467 | 1.85% | 2540.583op/s | 1 | 200 |
| trace_buffer/4_senders/10us_delay | execution_time | 57.075ms | 57.391ms ± 0.148ms | 57.365ms ± 0.080ms | 57.464ms | 57.627ms | 57.871ms | 58.130ms | 1.33% | 1.168 | 3.293 | 0.26% | 0.010ms | 1 | 200 |
| trace_buffer/4_senders/10us_delay | throughput | 61929.711op/s | 62728.208op/s ± 161.821op/s | 62756.288op/s ± 87.979op/s | 62832.627op/s | 62960.489op/s | 63023.934op/s | 63075.166op/s | 0.51% | -1.138 | 3.162 | 0.26% | 11.442op/s | 1 | 200 |
| trace_buffer/4_senders/1us_delay | execution_time | 50.094ms | 50.162ms ± 0.031ms | 50.158ms ± 0.015ms | 50.175ms | 50.223ms | 50.269ms | 50.298ms | 0.28% | 1.513 | 3.459 | 0.06% | 0.002ms | 1 | 200 |
| trace_buffer/4_senders/1us_delay | throughput | 71573.357op/s | 71766.808op/s ± 43.957op/s | 71773.511op/s ± 20.936op/s | 71793.072op/s | 71820.827op/s | 71831.063op/s | 71865.330op/s | 0.13% | -1.507 | 3.437 | 0.06% | 3.108op/s | 1 | 200 |
| trace_buffer/4_senders/no_delay | execution_time | 2.116ms | 2.328ms ± 0.081ms | 2.333ms ± 0.051ms | 2.378ms | 2.460ms | 2.492ms | 2.519ms | 8.00% | -0.185 | 0.065 | 3.46% | 0.006ms | 1 | 200 |
| trace_buffer/4_senders/no_delay | throughput | 1429066.427op/s | 1548134.668op/s ± 54231.012op/s | 1543373.169op/s ± 33078.386op/s | 1579009.466op/s | 1641711.838op/s | 1696025.720op/s | 1701495.130op/s | 10.25% | 0.401 | 0.278 | 3.49% | 3834.712op/s | 1 | 200 |
| trace_buffer/8_senders/10us_delay | execution_time | 57.514ms | 57.818ms ± 0.179ms | 57.761ms ± 0.088ms | 57.888ms | 58.158ms | 58.288ms | 58.552ms | 1.37% | 1.147 | 1.147 | 0.31% | 0.013ms | 1 | 200 |
| trace_buffer/8_senders/10us_delay | throughput | 122968.131op/s | 124530.606op/s ± 384.048op/s | 124650.956op/s ± 191.179op/s | 124800.793op/s | 124975.350op/s | 125106.032op/s | 125186.236op/s | 0.43% | -1.131 | 1.086 | 0.31% | 27.156op/s | 1 | 200 |
| trace_buffer/8_senders/1us_delay | execution_time | 50.196ms | 50.292ms ± 0.055ms | 50.278ms ± 0.029ms | 50.317ms | 50.397ms | 50.489ms | 50.517ms | 0.48% | 1.384 | 2.278 | 0.11% | 0.004ms | 1 | 200 |
| trace_buffer/8_senders/1us_delay | throughput | 142526.611op/s | 143163.381op/s ± 157.484op/s | 143204.228op/s ± 82.472op/s | 143272.456op/s | 143341.319op/s | 143379.268op/s | 143438.621op/s | 0.16% | -1.376 | 2.248 | 0.11% | 11.136op/s | 1 | 200 |
| trace_buffer/8_senders/no_delay | execution_time | 6.180ms | 6.648ms ± 0.124ms | 6.683ms ± 0.066ms | 6.736ms | 6.791ms | 6.829ms | 6.861ms | 2.65% | -1.184 | 1.470 | 1.86% | 0.009ms | 1 | 200 |
| trace_buffer/8_senders/no_delay | throughput | 1049485.016op/s | 1083348.406op/s ± 20644.398op/s | 1077291.076op/s ± 10591.297op/s | 1093090.539op/s | 1122429.130op/s | 1153139.394op/s | 1165043.894op/s | 8.15% | 1.305 | 1.924 | 1.90% | 1459.779op/s | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| trace_buffer/1_senders/10us_delay | execution_time | [56.532ms; 56.587ms] or [-0.049%; +0.049%] | None | None | None |
| trace_buffer/1_senders/10us_delay | throughput | [15904.952op/s; 15920.417op/s] or [-0.049%; +0.049%] | None | None | None |
| trace_buffer/1_senders/1us_delay | execution_time | [50.081ms; 50.091ms] or [-0.009%; +0.009%] | None | None | None |
| trace_buffer/1_senders/1us_delay | throughput | [17967.388op/s; 17970.791op/s] or [-0.009%; +0.009%] | None | None | None |
| trace_buffer/1_senders/no_delay | execution_time | [344.974µs; 346.330µs] or [-0.196%; +0.196%] | None | None | None |
| trace_buffer/1_senders/no_delay | throughput | [2599472.838op/s; 2609050.264op/s] or [-0.184%; +0.184%] | None | None | None |
| trace_buffer/2_senders/10us_delay | execution_time | [56.958ms; 57.010ms] or [-0.045%; +0.045%] | None | None | None |
| trace_buffer/2_senders/10us_delay | throughput | [31573.923op/s; 31602.429op/s] or [-0.045%; +0.045%] | None | None | None |
| trace_buffer/2_senders/1us_delay | execution_time | [50.106ms; 50.113ms] or [-0.007%; +0.007%] | None | None | None |
| trace_buffer/2_senders/1us_delay | throughput | [35918.816op/s; 35924.164op/s] or [-0.007%; +0.007%] | None | None | None |
| trace_buffer/2_senders/no_delay | execution_time | [926.343µs; 931.084µs] or [-0.255%; +0.255%] | None | None | None |
| trace_buffer/2_senders/no_delay | throughput | [1933842.935op/s; 1943801.837op/s] or [-0.257%; +0.257%] | None | None | None |
| trace_buffer/4_senders/10us_delay | execution_time | [57.370ms; 57.411ms] or [-0.036%; +0.036%] | None | None | None |
| trace_buffer/4_senders/10us_delay | throughput | [62705.781op/s; 62750.635op/s] or [-0.036%; +0.036%] | None | None | None |
| trace_buffer/4_senders/1us_delay | execution_time | [50.158ms; 50.167ms] or [-0.008%; +0.008%] | None | None | None |
| trace_buffer/4_senders/1us_delay | throughput | [71760.716op/s; 71772.900op/s] or [-0.008%; +0.008%] | None | None | None |
| trace_buffer/4_senders/no_delay | execution_time | [2.317ms; 2.339ms] or [-0.481%; +0.481%] | None | None | None |
| trace_buffer/4_senders/no_delay | throughput | [1540618.771op/s; 1555650.564op/s] or [-0.485%; +0.485%] | None | None | None |
| trace_buffer/8_senders/10us_delay | execution_time | [57.793ms; 57.842ms] or [-0.043%; +0.043%] | None | None | None |
| trace_buffer/8_senders/10us_delay | throughput | [124477.380op/s; 124583.831op/s] or [-0.043%; +0.043%] | None | None | None |
| trace_buffer/8_senders/1us_delay | execution_time | [50.285ms; 50.300ms] or [-0.015%; +0.015%] | None | None | None |
| trace_buffer/8_senders/1us_delay | throughput | [143141.555op/s; 143185.207op/s] or [-0.015%; +0.015%] | None | None | None |
| trace_buffer/8_senders/no_delay | execution_time | [6.631ms; 6.666ms] or [-0.258%; +0.258%] | None | None | None |
| trace_buffer/8_senders/no_delay | throughput | [1080487.291op/s; 1086209.521op/s] or [-0.264%; +0.264%] | None | None | None |
Group 1
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | ade7821 | 1783728750 | main |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| write only interface | execution_time | 1.052µs | 1.066µs ± 0.004µs | 1.066µs ± 0.002µs | 1.068µs | 1.073µs | 1.075µs | 1.075µs | 0.77% | -0.482 | 0.489 | 0.42% | 0.000µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| write only interface | execution_time | [1.065µs; 1.066µs] or [-0.058%; +0.058%] | None | None | None |
Group 2
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | ade7821 | 1783728750 | main |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| two way interface | execution_time | 14.980µs | 15.548µs ± 0.172µs | 15.530µs ± 0.101µs | 15.633µs | 15.804µs | 16.047µs | 16.476µs | 6.09% | 1.202 | 4.807 | 1.11% | 0.012µs | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| two way interface | execution_time | [15.524µs; 15.571µs] or [-0.154%; +0.154%] | None | None | None |
Group 3
| cpu_model | git_commit_sha | git_commit_date | git_branch |
|---|---|---|---|
| Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz | ade7821 | 1783728750 | main |
| scenario | metric | min | mean ± sd | median ± mad | p75 | p95 | p99 | max | peak_to_median_ratio | skewness | kurtosis | cv | sem | runs | sample_size |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | 8.394ms | 8.426ms ± 0.017ms | 8.421ms ± 0.009ms | 8.433ms | 8.459ms | 8.480ms | 8.480ms | 0.70% | 1.245 | 1.357 | 0.20% | 0.001ms | 1 | 200 |
| scenario | metric | 95% CI mean | Shapiro-Wilk pvalue | Ljung-Box pvalue (lag=1) | Dip test pvalue |
|---|---|---|---|---|---|
| concentrator/add_spans_to_concentrator | execution_time | [8.424ms; 8.428ms] or [-0.028%; +0.028%] | None | None | None |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
b905f96 to
30d94f8
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30d94f86f0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Aaalibaba42
left a comment
There was a problem hiding this comment.
Mostly nits, I don't know dogstatsd enough to approve though, just looked at the code.
30d94f8 to
395fb45
Compare

What does this PR do?
Refactor of the dogstatsd client crate.
Main changes are:
actionclientandclient/sinkClienttoDogStatDClientto avoid renames when importing in other cratesnew,create_clientanddo_sendto be method of theDogStatsDClientDogStatsDClientto use aOnceLockand make the client handle clonableMotivation
I've encountered several issues with the current design when sharing the client with the StatsExporter in #2159 and when adding the SharedRuntime backed client #2224 .
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.