feat(native-spans)!: change buffer foundation#2046
Draft
yannham wants to merge 16 commits into
Draft
Conversation
Co-authored-by: Jules Wiriath <53870805+Aaalibaba42@users.noreply.github.com>
yannham
changed the title
|
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## yannham/span-vec-fields-integration #2046 +/- ##
=======================================================================
+ Coverage 72.77% 72.91% +0.14%
=======================================================================
Files 459 464 +5
Lines 76037 76360 +323
=======================================================================
+ Hits 55335 55678 +343
+ Misses 20702 20682 -20
🚀 New features to boost your workflow:
|
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
The trace_buffer benchmark was still using HashMap for Span meta, metrics, and meta_struct fields after the VecMap migration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The decoder functions were returning Vec<(K, V)> which callers immediately converted to VecMap via .into(). Return VecMap directly to avoid the unnecessary intermediate type. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add the supporting types for the change-buffer module behind a `change-buffer` feature flag: ChangeBuffer (raw memory wrapper), OpCode/BufferedOperation, SpanHeader (repr(C)), SmallTraceMap, Trace, and error types. These are the building blocks for ChangeBufferState which follows in the next commit. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
yannham
force-pushed
the
yannham/change-buffer-foundation
branch
from
8962592 to
66fb3e6
Compare
yannham
force-pushed
the
yannham/span-vec-fields-integration
branch
3 times, most recently
from
2d45a7f to
8f43f82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add foundation types for dd-trace-js change buffer: buffer, opcodes and trace. Follow up of #2043.
Motivation
See #2022. Required for the integration of native spans into dd-trace-js.
Additional Notes
This PR just introduces the types and doesn't use them yet, hence the
allow(unused).How to test the change?
Unit tests provided.