-
Notifications
You must be signed in to change notification settings - Fork 12
Update generator throttler to support block-based strategy #1675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
TheSafo
wants to merge
1
commit into
jsaf/add-config-tests
Choose a base branch
from
jsaf/block-based-limiter
base: jsaf/add-config-tests
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+942
−249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c4199fc to
6ed7dca
Compare
a5dc28f to
10ba2f9
Compare
10ba2f9 to
d724a4c
Compare
74c2f05 to
9ae8ce6
Compare
3c1df18 to
01c4cd3
Compare
01c4cd3 to
648642c
Compare
648642c to
a636e4c
Compare
a636e4c to
661d654
Compare
af8d207 to
cf2d888
Compare
867b097 to
e1d8abc
Compare
e1d8abc to
e73bb21
Compare
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

What does this PR do?
Enables configuring byte-based throttlers in generators to be based per block (e.g. 10 blocks per second instead of 100 MB/s).
Impl. details:
Motivation
When using payload generators where blocks are intentionally not the same size/close to maximum bytes, it can be helpful to reason about throughput per block. This allows us to do things like:
to simulate generating logs at 5x standard playback speed.
Related issues
A follow up pr (#1683) adds some flushing logic to BufWriter based generators that enables more regular flushing. A separate PR will introduce a new payload format to utilize block-based throttling.