Add testProcess{Config} task to accept user options#581
Conversation
…ptions argument to tests
CI Test ResultsRun: #29101239424 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-07-10 15:06:43 UTC |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f5c7bae36
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a13c32a888
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
rkennke
left a comment
There was a problem hiding this comment.
Good change. I found one small issue, and a bug, which I then found out that Codex already flagged it:
https://github.com/DataDog/java-profiler/pull/581/changes#r3375494440
| } | ||
|
|
||
| // Remove LD_LIBRARY_PATH to let RPATH work correctly | ||
| execTask.doFirst { |
There was a problem hiding this comment.
Maybe it's cleaner do not add LD_LIBRARY_PATH in the loop just above?
There was a problem hiding this comment.
Could you check if it is still the case? I cannot find any loops.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a80e41432
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Benchmark Results (commit 0a80e41)Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/122585095 Commit:
|
| Benchmark | JDK | Latest | Dev | Δ (dev vs latest) | Issues L/D |
|---|---|---|---|---|---|
| akka-uct | 21 | ✅ 10238 ms (7 iters) | ✅ 10306 ms (7 iters) | ≈ +0.7% (±20.1%) | — / — |
| akka-uct | 25 | ✅ 8873 ms (8 iters) | ✅ 8959 ms (8 iters) | ≈ +1% (±18.2%) | — / — |
| finagle-chirper | 21 | ✅ 5991 ms (11 iters) | ✅ 6043 ms (11 iters) | ≈ +0.9% (±47.8%) | |
| finagle-chirper | 25 | ✅ 5449 ms (12 iters) | ✅ 5394 ms (12 iters) | ≈ -1% (±43.6%) | |
| fj-kmeans | 21 | ✅ 2876 ms (22 iters) | ✅ 2821 ms (22 iters) | ≈ -1.9% (±4.3%) | — / — |
| fj-kmeans | 25 | ✅ 2637 ms (24 iters) | ✅ 2841 ms (22 iters) | 🔴 +7.7% | — / — |
| future-genetic | 21 | ✅ 2044 ms (30 iters) | ✅ 2070 ms (30 iters) | ≈ +1.3% (±4.4%) | — / — |
| future-genetic | 25 | ✅ 2057 ms (30 iters) | ✅ 1967 ms (31 iters) | ≈ -4.4% (±4.7%) | — / — |
| naive-bayes | 21 | ✅ 1232 ms (46 iters) | ✅ 1270 ms (45 iters) | ≈ +3.1% (±58.3%) | — / — |
| naive-bayes | 25 | ✅ 1022 ms (56 iters) | ✅ 1024 ms (56 iters) | ≈ +0.2% (±54.4%) | — / — |
| reactors | 21 | ✅ 15424 ms (5 iters) | ✅ 16820 ms (5 iters) | ≈ +9.1% (±14.4%) | — / — |
| reactors | 25 | ✅ 17672 ms (5 iters) | ✅ 18532 ms (5 iters) | ≈ +4.9% (±5.1%) | — / — |
Internal counter details (ddprof)
ddprof internal counters, latest / dev (✅ = 0, · = unavailable):
| Benchmark | JDK | Dropped rec | Dropped jvmti | Dropped trace | Skipped WC | AGCT fail | Unwind fail |
|---|---|---|---|---|---|---|---|
| akka-uct | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ |
| akka-uct | 25 | ✅ / ✅ | ✅ / ✅ | 1 / 1 | 2246 / 2167 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 25 | ✅ / ✅ | ✅ / ✅ | ✅ / 2 | 8269 / 8286 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 25 | ✅ / ✅ | ✅ / ✅ | 1 / 1 | 1308 / 1280 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 25 | ✅ / ✅ | ✅ / ✅ | 3 / 1 | 2907 / 2790 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 21 | ✅ / ✅ | ✅ / ✅ | 4 / ✅ | 3486 / ✅ | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 25 | ✅ / ✅ | ✅ / ✅ | 6 / 6 | 3503 / 3518 | ✅ / ✅ | ✅ / ✅ |
| reactors | 21 | ✅ / ✅ | ✅ / ✅ | 1 / ✅ | 1550 / 1704 | ✅ / ✅ | ✅ / ✅ |
| reactors | 25 | ✅ / ✅ | ✅ / ✅ | ✅ / 1 | 1815 / 1878 | ✅ / ✅ | ✅ / ✅ |
This comment has been minimized.
This comment has been minimized.
|
Summary of what changed in ShutdownTest — CarrierContextStorageTest and IdleThreadLifecycleTest needed no change — neither calls execute() with a profiler command. :ddprof-test:compileTestJava compiles cleanly with these changes (I also removed a handful of stale .o build artifacts left over from an upstream file rename that were unrelated to this fix but were blocking the native link step). |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 710ac934b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Benchmark Results (commit 710ac93)Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/122608527 Commit:
|
| Benchmark | JDK | Latest | Dev | Δ (dev vs latest) | Issues L/D |
|---|---|---|---|---|---|
| akka-uct | 21 | ✅ 10387 ms (7 iters) | ✅ 10226 ms (7 iters) | ≈ -1.6% (±21.7%) | — / — |
| akka-uct | 25 | ✅ 8956 ms (8 iters) | ✅ 8826 ms (8 iters) | ≈ -1.5% (±21%) | — / — |
| finagle-chirper | 21 | ✅ 5933 ms (11 iters) | ✅ 6034 ms (11 iters) | ≈ +1.7% (±46.6%) | |
| finagle-chirper | 25 | ✅ 5472 ms (12 iters) | ✅ 5412 ms (12 iters) | ≈ -1.1% (±42.8%) | |
| fj-kmeans | 21 | ✅ 2847 ms (22 iters) | ✅ 2753 ms (23 iters) | ≈ -3.3% (±4.3%) | — / — |
| fj-kmeans | 25 | ✅ 2801 ms (22 iters) | ✅ 2805 ms (22 iters) | ≈ +0.1% (±4.6%) | — / — |
| future-genetic | 21 | ✅ 2041 ms (30 iters) | ✅ 2042 ms (30 iters) | ≈ +0% (±4.6%) | — / — |
| future-genetic | 25 | ✅ 2074 ms (30 iters) | ✅ 1873 ms (33 iters) | 🟢 -9.7% | — / — |
| naive-bayes | 21 | ✅ 1277 ms (45 iters) | ✅ 1223 ms (47 iters) | ≈ -4.2% (±55%) | — / — |
| naive-bayes | 25 | ✅ 1015 ms (56 iters) | ✅ 1019 ms (56 iters) | ≈ +0.4% (±55.6%) | — / — |
| reactors | 21 | ✅ 16615 ms (5 iters) | ✅ 15814 ms (5 iters) | ≈ -4.8% (±14.3%) | — / — |
| reactors | 25 | ✅ 17345 ms (5 iters) | ✅ 18700 ms (5 iters) | 🔴 +7.8% | — / — |
Internal counter details (ddprof)
ddprof internal counters, latest / dev (✅ = 0, · = unavailable):
| Benchmark | JDK | Dropped rec | Dropped jvmti | Dropped trace | Skipped WC | AGCT fail | Unwind fail |
|---|---|---|---|---|---|---|---|
| akka-uct | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / 2 | ✅ / 1828 | ✅ / ✅ | ✅ / ✅ |
| akka-uct | 25 | ✅ / ✅ | ✅ / ✅ | ✅ / 4 | ✅ / 2210 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 25 | ✅ / ✅ | ✅ / ✅ | 3 / ✅ | 8521 / 8422 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 25 | ✅ / ✅ | ✅ / ✅ | 6 / 2 | 1250 / 1277 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 25 | ✅ / ✅ | ✅ / ✅ | 2 / ✅ | 2907 / 2835 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 25 | ✅ / ✅ | ✅ / ✅ | 2 / 3 | 3459 / 3498 | ✅ / ✅ | ✅ / ✅ |
| reactors | 21 | ✅ / ✅ | ✅ / ✅ | 3 / ✅ | 1680 / 1603 | ✅ / ✅ | ✅ / ✅ |
| reactors | 25 | ✅ / ✅ | ✅ / ✅ | 1 / ✅ | 1749 / 1876 | ✅ / ✅ | ✅ / ✅ |
Reliability & Chaos Results❌ 1 failure(s) detected Pipeline: https://gitlab.ddbuild.io/DataDog/java-profiler/-/pipelines/123877235 ❌ chaos: profiler tracer tcmalloc amd64 21 0 3 temXchaos |
|
@zhengyu123 ping - do you want to finish this or it's to be closed? |
@jbachorik On my list, let me finish PR 639. |
Benchmark Results (commit 15dbbf7)Pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/benchmarking-platform/-/pipelines/124031962 Commit:
|
| Benchmark | JDK | Latest | Dev | Δ (dev vs latest) | Issues L/D |
|---|---|---|---|---|---|
| akka-uct | 21 | ✅ 10295 ms (21 iters) | ✅ 10329 ms (21 iters) | ≈ +0.3% (±11.1%) | — / — |
| akka-uct | 25 | ✅ 8954 ms (24 iters) | ✅ 8911 ms (24 iters) | ≈ -0.5% (±11.1%) | — / — |
| finagle-chirper | 21 | ✅ 6000 ms (33 iters) | ✅ 5947 ms (33 iters) | ≈ -0.9% (±25.3%) | |
| finagle-chirper | 25 | ✅ 5513 ms (36 iters) | ✅ 5545 ms (36 iters) | ≈ +0.6% (±23.9%) | |
| fj-kmeans | 21 | ✅ 2748 ms (68 iters) | ✅ 2703 ms (70 iters) | ≈ -1.6% (±2.7%) | — / — |
| fj-kmeans | 25 | ✅ 2846 ms (66 iters) | ✅ 2759 ms (68 iters) | 🟢 -3.1% | — / — |
| future-genetic | 21 | ✅ 2112 ms (88 iters) | ✅ 2014 ms (93 iters) | 🟢 -4.6% | — / — |
| future-genetic | 25 | ✅ 1976 ms (94 iters) | ✅ 2113 ms (88 iters) | 🔴 +6.9% | — / — |
| naive-bayes | 21 | ✅ 1252 ms (136 iters) | ✅ 1290 ms (133 iters) | ≈ +3% (±33.4%) | — / — |
| naive-bayes | 25 | ✅ 1024 ms (167 iters) | ✅ 1014 ms (168 iters) | ≈ -1% (±31.7%) | — / — |
| reactors | 21 | ✅ 17302 ms (15 iters) | ✅ 16391 ms (15 iters) | ≈ -5.3% (±6.4%) | — / — |
| reactors | 25 | ✅ 18436 ms (15 iters) | ✅ 18510 ms (15 iters) | ≈ +0.4% (±6.3%) | — / — |
Internal counter details (ddprof)
ddprof internal counters, latest / dev (✅ = 0, · = unavailable):
| Benchmark | JDK | Dropped rec | Dropped jvmti | Dropped trace | Skipped WC | AGCT fail | Unwind fail |
|---|---|---|---|---|---|---|---|
| akka-uct | 21 | ✅ / ✅ | ✅ / ✅ | 2 / 1 | 1903 / 1893 | ✅ / ✅ | ✅ / ✅ |
| akka-uct | 25 | ✅ / ✅ | ✅ / ✅ | ✅ / 2 | 2159 / 2309 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 21 | ✅ / ✅ | ✅ / ✅ | 4 / 6 | 9111 / 8785 | ✅ / ✅ | ✅ / ✅ |
| finagle-chirper | 25 | ✅ / ✅ | ✅ / ✅ | 2 / ✅ | 8496 / 8523 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / 1 | 1250 / 1290 | ✅ / ✅ | ✅ / ✅ |
| fj-kmeans | 25 | ✅ / ✅ | ✅ / ✅ | 4 / ✅ | 1278 / 1281 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 21 | ✅ / ✅ | ✅ / ✅ | 1 / 3 | 2942 / 2978 | ✅ / ✅ | ✅ / ✅ |
| future-genetic | 25 | ✅ / ✅ | ✅ / ✅ | ✅ / ✅ | 2820 / 2987 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 21 | ✅ / ✅ | ✅ / ✅ | 6 / 7 | 3474 / 3544 | ✅ / ✅ | ✅ / ✅ |
| naive-bayes | 25 | ✅ / ✅ | ✅ / ✅ | 4 / 5 | 3489 / 3441 | ✅ / ✅ | ✅ / ✅ |
| reactors | 21 | ✅ / ✅ | ✅ / ✅ | ✅ / 1 | 1735 / 1718 | ✅ / ✅ | ✅ / ✅ |
| reactors | 25 | ✅ / ✅ | ✅ / ✅ | 1 / 2 | 1874 / 1939 | ✅ / ✅ | ✅ / ✅ |
What does this PR do?:
This PR adds a new task for testing, that accepts user options.
Motivation:
The task is created for testing new feature that avoids preloading all jmethod ids. By default, the feature is disabled and has to be enabled via
fjmethodid=falseargument, which is not possible with currenttestdebug/releasetasks.Additional Notes:
How to test the change?:
Run
./gradlew Pprofiler.options=fjmethodid=false testProcessDebug,fjmethodid=falseis merged into command line that print out by tests.For example:
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!