Skip to content

Conversation

@RTJL
Copy link

@RTJL RTJL commented Nov 4, 2025

What does this PR do?

Create a new integration for Grafana.

Motivation

What inspired you to submit this pull request?

I want to use Datadog to monitor the status of Grafana instances without exporting as custom metrics.

Review checklist

  • PR has a meaningful title or PR has the no-changelog label attached
  • Feature or bugfix has tests
  • Git history is clean
  • If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
  • If this PR includes a log pipeline, please add a description describing the remappers and processors.

Additional Notes

Anything else we should know when reviewing?

@RTJL RTJL requested review from a team as code owners November 4, 2025 00:47
@rtrieu rtrieu self-assigned this Nov 4, 2025
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I've left you some feedback and suggestions mainly around consistency and clarity.

@RTJL RTJL requested a review from a team as a code owner November 5, 2025 03:25
@RTJL RTJL force-pushed the add-grafana-integration branch from 514e33b to b9d8d5d Compare November 8, 2025 07:23
@RTJL RTJL requested a review from rtrieu November 14, 2025 04:26
@RTJL
Copy link
Author

RTJL commented Nov 19, 2025

hi @rtrieu, could i trouble you to take a look at it again? thanks!

rtrieu
rtrieu previously approved these changes Nov 19, 2025
Copy link
Member

@NouemanKHAL NouemanKHAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RTJL ,
Thank you for your contribution! I reviewed your PR, overall everything LGTM!
I left few comments to address CI validation errors and some nits.

@NouemanKHAL NouemanKHAL self-assigned this Nov 28, 2025
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed rtrieu’s stale review December 13, 2025 08:08

Review from rtrieu is dismissed. Related teams and files:

  • documentation
    • grafana/README.md
@RTJL RTJL force-pushed the add-grafana-integration branch from 7e17817 to 1781378 Compare December 13, 2025 08:28
@RTJL RTJL requested a review from NouemanKHAL December 13, 2025 08:40
@RTJL
Copy link
Author

RTJL commented Dec 13, 2025

hi @NouemanKHAL, have applied the suggestions and also rebased. can help take a look at it again? thanks!

rtrieu
rtrieu previously approved these changes Dec 17, 2025
python = ["3.13"]

[envs.default.env-vars]
DDEV_SKIP_GENERIC_TAGS_CHECK = "true"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RTJL Are there any metric tags that should be renamed instead?
If needed, you can follow the example here to add a rename_labels key to the config map, and add the mapping for tag and renamed_tag.

Example:
https://github.com/DataDog/integrations-core/blob/a41670ab152f0e49bd6b01833580a42951550ae5/linkerd/datadog_checks/linkerd/check.py#L30

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @NouemanKHAL, I've reviewed the metric tags and renamed the ones that were needed using the rename_labels mapping in the config, following the same pattern as the example you shared.

@RTJL RTJL force-pushed the add-grafana-integration branch from 1781378 to 8ec2537 Compare December 24, 2025 09:23
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed rtrieu’s stale review December 24, 2025 09:23

Review from rtrieu is dismissed. Related teams and files:

  • documentation
    • grafana/README.md
    • grafana/manifest.json
    • grafana/metadata.csv
@RTJL RTJL requested a review from NouemanKHAL December 24, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants