-
Notifications
You must be signed in to change notification settings - Fork 814
Add grafana integration #2844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add grafana integration #2844
Conversation
rtrieu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! I've left you some feedback and suggestions mainly around consistency and clarity.
514e33b to
b9d8d5d
Compare
|
hi @rtrieu, could i trouble you to take a look at it again? thanks! |
NouemanKHAL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RTJL ,
Thank you for your contribution! I reviewed your PR, overall everything LGTM!
I left few comments to address CI validation errors and some nits.
Review from rtrieu is dismissed. Related teams and files:
- documentation
- grafana/README.md
7e17817 to
1781378
Compare
|
hi @NouemanKHAL, have applied the suggestions and also rebased. can help take a look at it again? thanks! |
grafana/hatch.toml
Outdated
| python = ["3.13"] | ||
|
|
||
| [envs.default.env-vars] | ||
| DDEV_SKIP_GENERIC_TAGS_CHECK = "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @NouemanKHAL, I've reviewed the metric tags and renamed the ones that were needed using the rename_labels mapping in the config, following the same pattern as the example you shared.
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: Rosa Trieu <107086888+rtrieu@users.noreply.github.com>
Co-authored-by: NouemanKHAL <noueman.khal@gmail.com>
1781378 to
8ec2537
Compare
Review from rtrieu is dismissed. Related teams and files:
- documentation
- grafana/README.md
- grafana/manifest.json
- grafana/metadata.csv
What does this PR do?
Create a new integration for
Grafana.Motivation
What inspired you to submit this pull request?
I want to use Datadog to monitor the status of Grafana instances without exporting as custom metrics.
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?