Co-own base DBM database modules with agent-integrations - #24846
Open
eric-weaver wants to merge 1 commit into
Open
Co-own base DBM database modules with agent-integrations#24846eric-weaver wants to merge 1 commit into
eric-weaver wants to merge 1 commit into
Conversation
The DatabaseCheck base class, DBM health reporting, schema collection, and sql_commenter live in datadog_checks_base but are only consumed by the DBM integrations, so route their reviews to database-monitoring-agent the way db/utils.py, db/sql.py, and db/statement_metrics.py already are. Co-authored-by: Cursor <cursoragent@cursor.com>
evalya-impact-summaryevalya impact analysis |
sethsamuel
approved these changes
Aug 12, 2026
Contributor
There was a problem hiding this comment.
More details
Resolving every tracked path before and after the change showed ownership changes on exactly the seven intended DBM files, with both teams retained and no wildcard spillover elsewhere.
📊 Validated against 10 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 99b4b01 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
tkell
approved these changes
Aug 12, 2026
Kyle-Neale
approved these changes
Aug 12, 2026
Contributor
Validation ReportAll 21 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
@DataDog/database-monitoring-agentas a co-owner of thedatadog_checks_basemodules that only the DBM integrations consume, alongside the existing@DataDog/agent-integrationsownership:base/checks/db.py(DatabaseCheck)base/utils/db/health.pybase/utils/db/schemas.pybase/utils/db/sql_commenter.pyTheir tests are covered too:
tests/base/checks/test_database_check.py,tests/base/utils/db/test_schemas.py, andtests/base/utils/db/test_sql_commenter.py.health.pyneeds no new test entry because its tests live intests/base/utils/db/test_util.py, which the existing line already covers.Motivation
The Database monitoring block already co-owns
base/utils/db/utils.py,base/utils/db/sql.py,base/utils/db/statement_metrics.py, andbase/utils/db/query_metrics/, but four equally DBM-specific modules were missed and still route reviews solely to@DataDog/agent-integrations. An AST-based import scan across the repo confirms no non-DBM integration imports them, other thansap_hanareusing schema collection anddo_query_actionsreusing the SQL commenter, andgit logshows every one of them was authored and maintained exclusively by DBM engineers.Deliberately left out of scope:
base/utils/aws.py,base/utils/diagnose.py, andbase/utils/tracking.pyare also DBM-only consumers today, but are general-purpose enough that claiming them isn't clearly right.base/utils/db/timed_cache.pyis DBM-authored and db-related but entirely unused —TimedCachehas no importer anywhere except its own test — so it's a deletion candidate rather than an ownership question.The generic
QueryManagerplumbing (base/utils/db/core.py,query.py,transform.py,types.py) is intentionally untouched, sinceduckdb,ibm_i,proxysql,rethinkdb,singlestore,teradata,vertica, andvoltdball depend on it.ddev validate codeownerspasses. No agent-shipped files change, so no changelog entry is needed.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is mergedMade with Cursor