Pin kubernetes - #24840
Open
AAraKKe wants to merge 1 commit into
Open
Conversation
Contributor
Validation ReportAll 21 validations passed. Show details
|
evalya-impact-summaryevalya impact analysis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
kubernetesto the dependency update exclude list, so the automated dependency PRs stop proposing 36.x and we stay on 35.0.0.Motivation
kubernetes36 folded thekubernetes_asyncioproject into the package askubernetes.aioand madeaiohttpa hard requirement. Measured against the Agent's static quality gates, the bump costs +24.5 MiB on disk (wheel contents, with ELF stripping accounted for):Of that,
kubernetes/aio/alone is 18.77 MiB across 855 files, since the async client is a full duplicate of the generated sync client.That broke 16 static quality gates in https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/1944467427, triggered from #24817:
Every gate that embeds Python failed on the on-disk dimension. The Agent ratchets those limits down to current+1 MiB on each main commit, so there is no room to absorb a bump of this size without an approved size exception.
Nothing in this repo imports
kubernetes.aio. The three consumers (datadog_checks_base's kube leader election,kubevirt_api,kueue) all use the sync client, and upstream's own changelog marks the asyncio package as experimental. Holding at 35.0.0 also does not freeze the security-relevant transitive dependencies: 35 and 36 constrainurllib3,requestsandcertifiidentically and loosely, and we pin those ourselves inagent_requirements.in.This is a hold, not a resolution. Taking 36 eventually needs either pruning
kubernetes/aioat build time (which brings the bump down to about +3 M) or an approved quality gate exception, and that is tracked separately.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged