Skip to content

ibm_ace: fix KeyError when ACE omits resource identifier name - #24826

Draft
ian28223 wants to merge 2 commits into
masterfrom
ian.bucad/fix_ibm_ace_keyerror
Draft

ibm_ace: fix KeyError when ACE omits resource identifier name#24826
ian28223 wants to merge 2 commits into
masterfrom
ian.bucad/fix_ibm_ace_keyerror

Conversation

@ian28223

Copy link
Copy Markdown
Contributor

What does this PR do?

Makes Resource.parse_tags in the ibm_ace check tolerate a resourceIdentifier entry that has no name key, instead of raising an uncaught KeyError that fails the check on every run.

Motivation

ACE 12.0.9 has been observed omitting name on some resourceIdentifier entries (seen on JDBCConnectionPools), which causes:

KeyError: 'name'
  File ".../ibm_ace/resources.py", line 23, in parse_tags
    group = metric_data.pop('name')

This surfaced in AGENT-16758, a follow-on from AGENT-16703 (a separate SA_ONSTACK crash-loop issue) — after the customer worked around the crash-loop, the check started failing on every run with this KeyError instead.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

ACE 12.0.9 has been observed omitting `name` on some resourceIdentifier
entries (e.g. JDBCConnectionPools), causing an uncaught KeyError that
fails the check on every run (AGENT-16758).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@dd-octo-sts

dd-octo-sts Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Validation Report

Validation Description Status
qa-label Validate the pull request declares whether it needs QA for the next Agent release

Run ddev validate all changed --fix to attempt to auto-fix supported validations.

Passed validations (20)
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Aug 11, 2026

Copy link
Copy Markdown

Pipelines  Tests  Code Coverage

⚠️ Warnings

🚦 1 Pipeline job failed

Validate repository | Run Validations / Validate   View in Datadog   GitHub Actions

See error PR #24826 is missing an Agent-release QA decision label, which is required for this job to pass.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 94.52% (+6.11%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 95b8710 | Docs | Datadog PR Page | Give us feedback!

@cit-pr-commenter-54b7da

Copy link
Copy Markdown

evalya-impact-summary

evalya impact analysis
Impact analysis: 0 selected, 0 skipped (of 0 test tasks)
Publish tasks:   0 (always emitted)
Diff (3 files):
  ibm_ace/changelog.d/24826.fixed
  ibm_ace/datadog_checks/ibm_ace/resources.py
  ibm_ace/tests/test_unit.py

Debug a specific task: evalya plan impact --path <path> --task <task>

Learn more about CI impact filtering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant