ibm_ace: fix KeyError when ACE omits resource identifier name - #24826
Draft
ian28223 wants to merge 2 commits into
Draft
ibm_ace: fix KeyError when ACE omits resource identifier name#24826ian28223 wants to merge 2 commits into
ian28223 wants to merge 2 commits into
Conversation
ACE 12.0.9 has been observed omitting `name` on some resourceIdentifier entries (e.g. JDBCConnectionPools), causing an uncaught KeyError that fails the check on every run (AGENT-16758). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Validation Report
Run Passed validations (20)
|
|
evalya-impact-summaryevalya impact analysis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes
Resource.parse_tagsin theibm_acecheck tolerate aresourceIdentifierentry that has nonamekey, instead of raising an uncaughtKeyErrorthat fails the check on every run.Motivation
ACE 12.0.9 has been observed omitting
nameon someresourceIdentifierentries (seen onJDBCConnectionPools), which causes:This surfaced in AGENT-16758, a follow-on from AGENT-16703 (a separate
SA_ONSTACKcrash-loop issue) — after the customer worked around the crash-loop, the check started failing on every run with thisKeyErrorinstead.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged