Keep release tooling separate from source refs#23837
Open
dkirov-dd wants to merge 1 commit into
Open
Conversation
Keep release workflow tooling checked out separately from the source tree being released. This lets the workflow use current setup actions and release scripts while ddev tags and validates the requested source-repo-ref. Add source-repo-branch to manual release dispatches so stable versus pre-release validation follows the branch that contains source-repo-ref instead of the branch used to launch the workflow.
e341d1b to
efa988e
Compare
Contributor
Validation ReportAll 21 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Splits the release dispatch prepare job into two checkouts:
tooling/checks out currentintegrations-coreworkflow tooling under.github/.source/checks out the requestedsource-repo-ref, which is whereddev release tagand validation run.This keeps release pipeline tooling current while still tagging and validating the requested source ref.
This also adds a manual
source-repo-branchinput torelease-trigger.yml, passes it torelease-dispatch.yml, and verifies that the checked-out source ref is contained in that branch before tagging. The branch also drives stable (master/X.Y.x) versus pre-release (alpha/*,beta/*,rc/*) validation.Motivation
PR #23836 made
actions/checkouthonorsource-repo-ref, but that also made workflow-local tooling come from the older source ref. Manual releases from refs that predate.github/actions/setup-ddevthen fail because the composite action is not present in the workspace.The prepare job needs current workflow tooling but must run
ddevagainst the requested source tree. Separate checkouts preserve both requirements.For stable/pre-release validation, using
GITHUB_REFis incorrect for manual dispatches because it describes the branch that launched the workflow, not necessarily the branch containingsource-repo-ref. The newsource-repo-branchinput makes that context explicit and the dispatch workflow checks that the ref is actually contained in the provided branch.Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged