Skip to content

Submit general resource via checks base#23818

Draft
steveny91 wants to merge 4 commits into
masterfrom
sy/genresources-base-helper-v2
Draft

Submit general resource via checks base#23818
steveny91 wants to merge 4 commits into
masterfrom
sy/genresources-base-helper-v2

Conversation

@steveny91
Copy link
Copy Markdown
Contributor

@steveny91 steveny91 commented May 22, 2026

What does this PR do?

Add helper functions to submit data to general resources via EVP.

As part a 3 part process:
PR1 to add the forwarder: DataDog/datadog-agent#50963
PR2 to add the helper functions in checks: this PR
PR3 to onboard ArgoCD as to submit entity metadata: TBA

@datadog-official
Copy link
Copy Markdown
Contributor

datadog-official Bot commented May 22, 2026

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 3 Pipeline jobs failed

PR All | test / j3a8e004 (py3.13-linux-odbc-2019-ha) / SQL Server on Linux-py3.13-linux-odbc-2019-ha   View in Datadog   GitHub Actions

🔄 Retry job. This looks flaky and may succeed on retry. Unable to connect to SQL Server: TCP connection refused. Exception: OperationalError('HYT00', '[HYT00] [Microsoft][ODBC Driver 18 for SQL Server]Login timeout expired (0) (SQLDriverConnect)')

PR All | test / j5a9585a / IBM ACE   View in Datadog   GitHub Actions

🔄 Retry job. This looks flaky and may succeed on retry. Failed to make a client connection to queue manager 'QM1' using hostname 'ibm-ace-mq' on port '1414': MQCC=2; MQRC=2538.

Validate repository | Run Validations / Validate   View in Datadog   GitHub Actions

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. Missing required QA validation label for PR #23818. Must set either 'qa/required' or 'qa/skip-qa'.

🧪 6 Tests failed in 1 job

PR All | run   GitHub Actions

All test failures are known flaky — job may pass on retry.

❄️ Known flaky: test_config[Metric collection disabled] from test_config.py   View in Datadog (Fix with Cursor)
RetryError[<Future at 0x7f239411bc50 state=finished raised RetryError>]

Not introduced in this PR.

❄️ Known flaky: test_config[Resource stats collection disabled; message_flows enabled] from test_config.py   View in Datadog (Fix with Cursor)
RetryError[<Future at 0x7f239411bc50 state=finished raised RetryError>]

Not introduced in this PR.

View all 6 test failures

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 86.39%
Overall Coverage: 87.45%

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f934bd9 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 22, 2026

Validation Report

Validation Description Status
qa-label Validate the pull request declares whether it needs QA for the next Agent release

Run ddev validate all changed --fix to attempt to auto-fix supported validations.

Passed validations (20)
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and Codecov settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 86.39053% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.88%. Comparing base (c672979) to head (f934bd9).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant