[SVLS-8669] Update documentation about the Continuous Profiler in Serverless#35125
[SVLS-8669] Update documentation about the Continuous Profiler in Serverless#35125kathiehuang wants to merge 2 commits intomasterfrom
Conversation
2353c3f to
ed923db
Compare
jeff-morgan-dd
left a comment
There was a problem hiding this comment.
Approving, with one suggestion for several of the pages:
On the pages where Continuous Profiler is included as a numbered step (azure_container_apps/in_container/nodejs, for example) - the indentation gets inconsistent because of the numbered step followed immediately by the div. Flipping the div to go after the instructions resolves it - see this comment for an example.
I didn't make the edit or comment on every relevant page, but I recommend doing so on those last several pages where it's included as a numbered step.
|
|
||
| 6. **Enable profiling (preview)**. | ||
|
|
||
| <div class="alert alert-info"> |
There was a problem hiding this comment.
| <div class="alert alert-info"> | |
| To enable the [Continuous Profiler][4], set the environment variable `DD_PROFILING_ENABLED=true`. | |
| <div class="alert alert-info">Datadog's Continuous Profiler is available in preview for Azure Container Apps. | |
| </div> |
There was a problem hiding this comment.
The rendered indentation got a little funky on these pages where CP is included as a numbered step, I think on account of the div being right after the number. Flipping them like this resolves it - not a huge deal, but a little more consistent-looking.
Since we have "preview" in the step name, i don't think this sacrifices any emphasis on preview status.
| 6. **Enable profiling (preview)**. | ||
|
|
||
| <div class="alert alert-info"> | ||
| Datadog's Continuous Profiler is available in preview for Azure Container Apps. |
There was a problem hiding this comment.
| Datadog's Continuous Profiler is available in preview for Azure Container Apps. |
|
|
||
| <div class="alert alert-info"> | ||
| Datadog's Continuous Profiler is available in preview for Azure Container Apps. | ||
| </div> |
There was a problem hiding this comment.
| </div> |
| Datadog's Continuous Profiler is available in preview for Azure Container Apps. | ||
| </div> | ||
|
|
||
| To enable the [Continuous Profiler][4], set the environment variable `DD_PROFILING_ENABLED=true`. |
There was a problem hiding this comment.
| To enable the [Continuous Profiler][4], set the environment variable `DD_PROFILING_ENABLED=true`. |
|
|
||
| 6. **Enable profiling (preview)**. | ||
|
|
||
| <div class="alert alert-info"> |
There was a problem hiding this comment.
See edit above re: flipping the alert note and the text to make the indentation more consistent
What does this PR do? What is the motivation?
import ddtrace.autois needed in the app code for Google Cloud Run Functions Gen 2DD_PROFILING_ENABLEDneeds to be set in the application container rather than the sidecar containerMerge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.