Skip to content

Conversation

@deigote
Copy link
Contributor

@deigote deigote commented Nov 10, 2025

These newly added functions operate on the hstore type. Since the only place in the docs where hstore is mentioned is the section about Tags, this PR adds a new subsection there that documents hstore functions, loosely following Postgres' docs for description.

These newly added functions operate on the `hstore` type. Since the only place in the docs where `hstore` is mentioned is the section about `Tags`, this PR adds a new subsection there that documents `hstore` functions, loosely following [Postgres' docs](https://www.postgresql.org/docs/8.4/hstore.html) for description.
@deigote deigote requested review from a team as code owners November 10, 2025 10:19
@deigote deigote requested a review from cortop November 10, 2025 10:19
@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@zafikrat zafikrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Adding examples would make it even clearer, but that can be handled later under AQG-330.

Co-authored-by: Zakaria Fikrat <113985839+zafikrat@users.noreply.github.com>
@maycmlee maycmlee self-assigned this Nov 10, 2025
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

Co-authored-by: May Lee <may.lee@datadoghq.com>
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Feel free to merge if it's ready.

@deigote deigote merged commit 058f6f1 into master Nov 11, 2025
20 of 21 checks passed
@deigote deigote deleted the diego.toharia/AQG-443-document-ddsql-akeys-and-avals branch November 11, 2025 15:04
dussault-antoine pushed a commit that referenced this pull request Nov 13, 2025
* AQG-443: document DDSQL's `akeys` and `avals` functions

These newly added functions operate on the `hstore` type. Since the only place in the docs where `hstore` is mentioned is the section about `Tags`, this PR adds a new subsection there that documents `hstore` functions, loosely following [Postgres' docs](https://www.postgresql.org/docs/8.4/hstore.html) for description.

* AQG-443: use singular for tag when used in a genitive sentence

Co-authored-by: Zakaria Fikrat <113985839+zafikrat@users.noreply.github.com>

* AQG-443: use correct casing, verb time and order of function params

Co-authored-by: May Lee <may.lee@datadoghq.com>

---------

Co-authored-by: Zakaria Fikrat <113985839+zafikrat@users.noreply.github.com>
Co-authored-by: May Lee <may.lee@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants