-
Notifications
You must be signed in to change notification settings - Fork 1.2k
AQG-443: document DDSQL's akeys and avals functions
#32714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AQG-443: document DDSQL's akeys and avals functions
#32714
Conversation
These newly added functions operate on the `hstore` type. Since the only place in the docs where `hstore` is mentioned is the section about `Tags`, this PR adds a new subsection there that documents `hstore` functions, loosely following [Postgres' docs](https://www.postgresql.org/docs/8.4/hstore.html) for description.
Preview links (active after the
|
zafikrat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Adding examples would make it even clearer, but that can be handled later under AQG-330.
Co-authored-by: Zakaria Fikrat <113985839+zafikrat@users.noreply.github.com>
maycmlee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions
Co-authored-by: May Lee <may.lee@datadoghq.com>
maycmlee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Feel free to merge if it's ready.
* AQG-443: document DDSQL's `akeys` and `avals` functions These newly added functions operate on the `hstore` type. Since the only place in the docs where `hstore` is mentioned is the section about `Tags`, this PR adds a new subsection there that documents `hstore` functions, loosely following [Postgres' docs](https://www.postgresql.org/docs/8.4/hstore.html) for description. * AQG-443: use singular for tag when used in a genitive sentence Co-authored-by: Zakaria Fikrat <113985839+zafikrat@users.noreply.github.com> * AQG-443: use correct casing, verb time and order of function params Co-authored-by: May Lee <may.lee@datadoghq.com> --------- Co-authored-by: Zakaria Fikrat <113985839+zafikrat@users.noreply.github.com> Co-authored-by: May Lee <may.lee@datadoghq.com>
These newly added functions operate on the
hstoretype. Since the only place in the docs wherehstoreis mentioned is the section aboutTags, this PR adds a new subsection there that documentshstorefunctions, loosely following Postgres' docs for description.