-
Notifications
You must be signed in to change notification settings - Fork 469
chore(co): handle view methods #15268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We extend support in Code Origin for Spans to handle view methods, in addition to functions.
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 253 ± 3 ms. The average import time from base is: 259 ± 3 ms. The import time difference between this PR and base is: -6.1 ± 0.1 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate chore/co-handle-methods (24acbe6) with baseline main (53726a1) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.949µs (SLO: <10.000µs 📉 -50.5%) vs baseline: 📈 +14.5% Memory: ✅ 39.754MB (SLO: <41.000MB -3.0%) vs baseline: +4.8% ✅ ospathbasename_noaspectTime: ✅ 1.077µs (SLO: <10.000µs 📉 -89.2%) vs baseline: -0.4% Memory: ✅ 39.892MB (SLO: <41.000MB -2.7%) vs baseline: +5.1% ✅ ospathjoin_aspectTime: ✅ 6.199µs (SLO: <10.000µs 📉 -38.0%) vs baseline: +1.1% Memory: ✅ 39.852MB (SLO: <41.000MB -2.8%) vs baseline: +5.1% ✅ ospathjoin_noaspectTime: ✅ 2.303µs (SLO: <10.000µs 📉 -77.0%) vs baseline: -0.2% Memory: ✅ 39.833MB (SLO: <41.000MB -2.8%) vs baseline: +4.7% ✅ ospathnormcase_aspectTime: ✅ 3.963µs (SLO: <10.000µs 📉 -60.4%) vs baseline: 📈 +12.3% Memory: ✅ 39.813MB (SLO: <41.000MB -2.9%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 0.569µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -1.6% Memory: ✅ 39.911MB (SLO: <41.000MB -2.7%) vs baseline: +5.0% ✅ ospathsplit_aspectTime: ✅ 5.784µs (SLO: <10.000µs 📉 -42.2%) vs baseline: 📈 +17.8% Memory: ✅ 39.951MB (SLO: <41.000MB -2.6%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 1.595µs (SLO: <10.000µs 📉 -84.1%) vs baseline: -0.7% Memory: ✅ 39.872MB (SLO: <41.000MB -2.8%) vs baseline: +5.0% ✅ ospathsplitdrive_aspectTime: ✅ 3.723µs (SLO: <10.000µs 📉 -62.8%) vs baseline: +0.5% Memory: ✅ 39.872MB (SLO: <41.000MB -2.8%) vs baseline: +5.0% ✅ ospathsplitdrive_noaspectTime: ✅ 0.689µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -0.9% Memory: ✅ 39.774MB (SLO: <41.000MB -3.0%) vs baseline: +4.8% ✅ ospathsplitext_aspectTime: ✅ 4.614µs (SLO: <10.000µs 📉 -53.9%) vs baseline: +0.3% Memory: ✅ 39.813MB (SLO: <41.000MB -2.9%) vs baseline: +4.8% ✅ ospathsplitext_noaspectTime: ✅ 1.374µs (SLO: <10.000µs 📉 -86.3%) vs baseline: -1.1% Memory: ✅ 39.833MB (SLO: <41.000MB -2.8%) vs baseline: +4.5% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.384µs (SLO: <20.000µs 📉 -83.1%) vs baseline: 📈 +16.9% Memory: ✅ 34.623MB (SLO: <35.500MB -2.5%) vs baseline: +4.7% ✅ 1-count-metrics-100-timesTime: ✅ 203.406µs (SLO: <220.000µs -7.5%) vs baseline: +1.6% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +4.7% ✅ 1-distribution-metric-1-timesTime: ✅ 3.498µs (SLO: <20.000µs 📉 -82.5%) vs baseline: +8.5% Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +4.8% ✅ 1-distribution-metrics-100-timesTime: ✅ 216.787µs (SLO: <230.000µs -5.7%) vs baseline: +1.7% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.557µs (SLO: <20.000µs 📉 -87.2%) vs baseline: 📈 +16.2% Memory: ✅ 34.662MB (SLO: <35.500MB -2.4%) vs baseline: +5.1% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.864µs (SLO: <150.000µs -8.1%) vs baseline: +1.5% Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.106µs (SLO: <20.000µs 📉 -84.5%) vs baseline: +2.4% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +5.1% ✅ 1-rate-metrics-100-timesTime: ✅ 216.623µs (SLO: <250.000µs 📉 -13.4%) vs baseline: +1.0% Memory: ✅ 34.682MB (SLO: <35.500MB -2.3%) vs baseline: +5.2% ✅ 100-count-metrics-100-timesTime: ✅ 20.365ms (SLO: <22.000ms -7.4%) vs baseline: +0.9% Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +4.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.255ms (SLO: <2.300ms 🟡 -2.0%) vs baseline: -0.6% Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.431ms (SLO: <1.550ms -7.6%) vs baseline: +2.1% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +4.7% ✅ 100-rate-metrics-100-timesTime: ✅ 2.208ms (SLO: <2.550ms 📉 -13.4%) vs baseline: +0.6% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +4.7% ✅ flush-1-metricTime: ✅ 4.589µs (SLO: <20.000µs 📉 -77.1%) vs baseline: +2.7% Memory: ✅ 34.485MB (SLO: <35.500MB -2.9%) vs baseline: +4.4% ✅ flush-100-metricsTime: ✅ 173.556µs (SLO: <250.000µs 📉 -30.6%) vs baseline: +0.2% Memory: ✅ 34.623MB (SLO: <35.500MB -2.5%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.131ms (SLO: <2.500ms 📉 -14.8%) vs baseline: +0.1% Memory: ✅ 35.429MB (SLO: <36.500MB -2.9%) vs baseline: +5.0% 🟡 Near SLO Breach (2 suites)🟡 iastpropagation - 8/8✅ no-propagationTime: ✅ 48.651µs (SLO: <60.000µs 📉 -18.9%) vs baseline: ~same Memory: ✅ 39.459MB (SLO: <40.500MB -2.6%) vs baseline: +4.6% ✅ propagation_enabledTime: ✅ 168.614µs (SLO: <190.000µs 📉 -11.3%) vs baseline: +1.2% Memory: ✅ 39.400MB (SLO: <40.000MB 🟡 -1.5%) vs baseline: +4.7% ✅ propagation_enabled_100Time: ✅ 1.851ms (SLO: <2.300ms 📉 -19.5%) vs baseline: ~same Memory: ✅ 39.459MB (SLO: <40.000MB 🟡 -1.4%) vs baseline: +4.6% ✅ propagation_enabled_1000Time: ✅ 32.140ms (SLO: <34.550ms -7.0%) vs baseline: -0.4% Memory: ✅ 39.459MB (SLO: <40.000MB 🟡 -1.4%) vs baseline: +4.5% 🟡 span - 26/26✅ add-eventTime: ✅ 17.347ms (SLO: <22.500ms 📉 -22.9%) vs baseline: ~same Memory: ✅ 36.438MB (SLO: <53.000MB 📉 -31.2%) vs baseline: +4.6% ✅ add-metricsTime: ✅ 87.036ms (SLO: <93.500ms -6.9%) vs baseline: +0.7% Memory: ✅ 40.715MB (SLO: <53.000MB 📉 -23.2%) vs baseline: +4.6% ✅ add-tagsTime: ✅ 139.039ms (SLO: <155.000ms 📉 -10.3%) vs baseline: +0.3% Memory: ✅ 40.541MB (SLO: <53.000MB 📉 -23.5%) vs baseline: +4.8% ✅ get-contextTime: ✅ 16.024ms (SLO: <20.500ms 📉 -21.8%) vs baseline: +0.6% Memory: ✅ 36.230MB (SLO: <53.000MB 📉 -31.6%) vs baseline: +4.7% ✅ is-recordingTime: ✅ 16.254ms (SLO: <20.500ms 📉 -20.7%) vs baseline: -0.4% Memory: ✅ 36.191MB (SLO: <53.000MB 📉 -31.7%) vs baseline: +4.6% ✅ record-exceptionTime: ✅ 35.561ms (SLO: <40.000ms 📉 -11.1%) vs baseline: +1.3% Memory: ✅ 36.878MB (SLO: <53.000MB 📉 -30.4%) vs baseline: +4.4% ✅ set-statusTime: ✅ 17.772ms (SLO: <22.000ms 📉 -19.2%) vs baseline: +0.1% Memory: ✅ 36.295MB (SLO: <53.000MB 📉 -31.5%) vs baseline: +4.8% ✅ startTime: ✅ 16.133ms (SLO: <20.500ms 📉 -21.3%) vs baseline: +0.9% Memory: ✅ 36.279MB (SLO: <53.000MB 📉 -31.5%) vs baseline: +4.7% ✅ start-finishTime: ✅ 51.536ms (SLO: <52.500ms 🟡 -1.8%) vs baseline: +1.0% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +5.0% ✅ start-finish-telemetryTime: ✅ 52.376ms (SLO: <54.500ms -3.9%) vs baseline: +0.3% Memory: ✅ 34.623MB (SLO: <35.500MB -2.5%) vs baseline: +5.1% ✅ start-finish-traceid128Time: ✅ 54.000ms (SLO: <57.000ms -5.3%) vs baseline: -0.4% Memory: ✅ 34.583MB (SLO: <35.500MB -2.6%) vs baseline: +4.9% ✅ start-traceid128Time: ✅ 16.421ms (SLO: <22.500ms 📉 -27.0%) vs baseline: +0.8% Memory: ✅ 36.284MB (SLO: <53.000MB 📉 -31.5%) vs baseline: +4.7% ✅ update-nameTime: ✅ 16.488ms (SLO: <22.000ms 📉 -25.1%) vs baseline: +0.8% Memory: ✅ 36.459MB (SLO: <53.000MB 📉 -31.2%) vs baseline: +4.8%
|
Description
We extend support in Code Origin for Spans to handle view methods, in addition to functions.