build(deps): bump tests/FeatureFlags/ffe-system-test-data from 4446371 to a596df7#4018
Conversation
Bumps [tests/FeatureFlags/ffe-system-test-data](https://github.com/DataDog/ffe-system-test-data) from `4446371` to `a596df7`. - [Commits](DataDog/ffe-system-test-data@4446371...a596df7) --- updated-dependencies: - dependency-name: tests/FeatureFlags/ffe-system-test-data dependency-version: a596df75dca040c46078b768cd2536c67691523c dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d5918b20b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit 4446371bc1ca52bd526356927ef42d380145b118 | |||
| Subproject commit a596df75dca040c46078b768cd2536c67691523c | |||
There was a problem hiding this comment.
Assert result metadata from the fixtures
This bump pulls in upstream fixture changes whose expected result is no longer just the value (for example, missing-flag cases now carry errorCode: FLAG_NOT_FOUND/reason: ERROR, and the date-window fixture updates are reason-only), but our only consumer, tests/ext/ffe/system_test_data_evaluate.phpt, stops after comparing $details->getValue() at lines 154-163. With this submodule revision, PHP can still return stale reason/error metadata while the canonical fixture sweep reports failures=0; please assert getReason() and getErrorCode() when those keys are present.
Useful? React with 👍 / 👎.
|
Bumps tests/FeatureFlags/ffe-system-test-data from
4446371toa596df7.Commits
a596df7Merge pull request #17 from DataDog/leo.romanovsky/regex-shard-bound-fixturesce45493Add regex and shard-bound fixtures6c7f63bMerge pull request #16 from DataDog/leo.romanovsky/malformed-split-shards-fix...cf7d7d5Add missing split shards fixtured9d8020Merge pull request #15 from DataDog/leo.romanovsky/date-window-assignment-rea...e4803e3Fix temporal allocation reasons95ff628Fix date-window assignment reasons57e98f5Merge pull request #14 from DataDog/leo.romanovsky/add-regex-evaluation-cases6db17e8Add regex evaluation edge cases1db25ecMerge pull request #11 from DataDog/leo.romanovsky/ffe-malformed-config-casesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)