Skip to content

Incorporate the sidecar communication protocol changes from libdatadog#3695

Merged
bwoebi merged 28 commits intomasterfrom
bob/libdd-update
Mar 23, 2026
Merged

Incorporate the sidecar communication protocol changes from libdatadog#3695
bwoebi merged 28 commits intomasterfrom
bob/libdd-update

Conversation

@bwoebi
Copy link
Collaborator

@bwoebi bwoebi commented Mar 7, 2026

And updating tests with it.

@bwoebi bwoebi requested review from a team as code owners March 7, 2026 14:11
@datadog-datadog-prod-us1-2
Copy link

datadog-datadog-prod-us1-2 bot commented Mar 7, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 13 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest   View in Datadog   (Fix with Cursor)
Risky Test
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:60
testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest   View in Datadog   (Fix with Cursor)
Risky Test
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:60
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest   View in Datadog   (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69c1502b0000000000f7db7c83058e32
tid: 69c1502b00000000
hexProcessTraceId: 00f7db7c83058e32
hexProcessSpanId: 6009cb37df5cc30a
processTraceId: 69765647068139058
processSpanId: 6920285743262515978
View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 05dd5ba | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Mar 7, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-03-23 15:43:19

Comparing candidate commit 05dd5ba in PR branch bob/libdd-update with baseline commit b9a49fa in branch master.

Found 1 performance improvements and 16 performance regressions! Performance is the same for 175 metrics, 2 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟥 execution_time [+6.882µs; +7.718µs] or [+55.053%; +61.747%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟩 execution_time [-3.611µs; -2.729µs] or [-3.326%; -2.513%]

scenario:PDOBench/benchPDOOverhead

  • 🟥 execution_time [+18.569µs; +21.979µs] or [+8.499%; +10.059%]

scenario:PDOBench/benchPDOOverhead-opcache

  • 🟥 execution_time [+19.276µs; +22.357µs] or [+8.881%; +10.301%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟥 execution_time [+20.370µs; +24.078µs] or [+9.345%; +11.046%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

  • 🟥 execution_time [+15.630µs; +19.788µs] or [+7.115%; +9.008%]

scenario:PHPRedisBench/benchRedisOverhead

  • 🟥 execution_time [+98.980µs; +123.289µs] or [+11.673%; +14.540%]

scenario:PHPRedisBench/benchRedisOverhead-opcache

  • 🟥 execution_time [+97.971µs; +114.869µs] or [+11.096%; +13.010%]

scenario:SpanBench/benchDatadogAPI

  • 🟥 execution_time [+3.132µs; +4.473µs] or [+4.914%; +7.017%]

scenario:SpanBench/benchDatadogAPI-opcache

  • 🟥 execution_time [+2.933µs; +4.137µs] or [+4.602%; +6.491%]

scenario:SpanBench/benchOpenTelemetryAPI

  • 🟥 execution_time [+24.809µs; +36.204µs] or [+3.465%; +5.056%]

scenario:SpanBench/benchOpenTelemetryAPI-opcache

  • 🟥 execution_time [+18.242µs; +29.154µs] or [+2.737%; +4.373%]

scenario:SpanBench/benchOpenTelemetryInteroperability

  • 🟥 execution_time [+4.916µs; +7.951µs] or [+2.642%; +4.273%]

scenario:SymfonyBench/benchSymfonyDdprof

  • 🟥 execution_time [+325.061µs; +440.059µs] or [+3.713%; +5.027%]

scenario:SymfonyBench/benchSymfonyDdprof-opcache

  • 🟥 execution_time [+269.286µs; +402.394µs] or [+3.069%; +4.586%]

scenario:SymfonyBench/benchSymfonyOverhead

  • 🟥 execution_time [+294.782µs; +421.178µs] or [+3.596%; +5.138%]

scenario:SymfonyBench/benchSymfonyOverhead-opcache

  • 🟥 execution_time [+375.540µs; +493.460µs] or [+4.543%; +5.970%]

@bwoebi bwoebi force-pushed the bob/libdd-update branch from 33adecd to 01ce985 Compare March 7, 2026 16:05
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.74%. Comparing base (b9a49fa) to head (05dd5ba).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3695      +/-   ##
==========================================
- Coverage   68.77%   68.74%   -0.03%     
==========================================
  Files         166      166              
  Lines       19030    19030              
  Branches     1797     1797              
==========================================
- Hits        13087    13082       -5     
- Misses       5127     5135       +8     
+ Partials      816      813       -3     
Flag Coverage Δ
helper-rust-integration 78.82% <ø> (-0.03%) ⬇️
helper-rust-unit 49.17% <ø> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9a49fa...05dd5ba. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bwoebi bwoebi force-pushed the bob/libdd-update branch from 01ce985 to f9818fb Compare March 10, 2026 00:01
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/libdd-update branch from f9818fb to 8221b6f Compare March 11, 2026 19:47
@morrisonlevi morrisonlevi changed the title Update libdatadog to neweset Update libdatadog to newest Mar 11, 2026
@pr-commenter
Copy link

pr-commenter bot commented Mar 11, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-03-23 14:43:34

Comparing candidate commit 05dd5ba in PR branch bob/libdd-update with baseline commit b9a49fa in branch master.

Found 2 performance improvements and 3 performance regressions! Performance is the same for 25 metrics, 6 unstable metrics.

scenario:php-profiler-timeline-memory-control

  • 🟥 cpu_user_time [+33.310ms; +42.543ms] or [+5.523%; +7.053%]
  • 🟥 execution_time [+32.730ms; +40.809ms] or [+5.180%; +6.458%]

scenario:php-profiler-timeline-memory-with-profiler

  • 🟥 execution_time [+41.047ms; +58.783ms] or [+4.169%; +5.970%]

scenario:walk_stack/50

  • 🟩 wall_time [-866.515ns; -855.798ns] or [-5.314%; -5.248%]

scenario:walk_stack/99

  • 🟩 wall_time [-810.771ns; -806.686ns] or [-4.966%; -4.941%]

morrisonlevi and others added 7 commits March 12, 2026 09:02
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/libdd-update branch from ace997b to 5f42a8e Compare March 16, 2026 22:29
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/libdd-update branch 4 times, most recently from adf1aa4 to 2b42ae2 Compare March 17, 2026 02:38
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/libdd-update branch from 2b42ae2 to 992785f Compare March 17, 2026 14:32
bwoebi added 2 commits March 17, 2026 15:47
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/libdd-update branch from d815db9 to 4d4c6ec Compare March 21, 2026 02:29
…dd-update

* 'master' of github.com:DataDog/dd-trace-php:
  [loader] Fix zombie creation (#3683)
  Adds container tags support for DBM (#3708)
  Enables process tags propagation by default (#3706)
Fix windows panic at startup time

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
clippy

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/libdd-update branch 2 times, most recently from 4deda59 to d297ae2 Compare March 21, 2026 05:21
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/libdd-update branch from d297ae2 to ae57131 Compare March 21, 2026 06:27
bwoebi added 2 commits March 21, 2026 15:57
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/libdd-update branch 16 times, most recently from b23c9e8 to 8f5a908 Compare March 23, 2026 04:27
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
@bwoebi bwoebi force-pushed the bob/libdd-update branch from 8f5a908 to 05dd5ba Compare March 23, 2026 14:24
Copy link
Contributor

@Leiyks Leiyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bwoebi bwoebi merged commit c3f44f4 into master Mar 23, 2026
2079 of 2083 checks passed
@bwoebi bwoebi deleted the bob/libdd-update branch March 23, 2026 15:57
@github-actions github-actions bot added this to the 1.17.0 milestone Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants