-
Notifications
You must be signed in to change notification settings - Fork 359
fix: Stop using Azure's EventHubs batch spanContext map for storing DD span contexts #6943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6943 +/- ##
==========================================
+ Coverage 84.60% 84.83% +0.23%
==========================================
Files 505 515 +10
Lines 21165 22022 +857
==========================================
+ Hits 17907 18683 +776
- Misses 3258 3339 +81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Overall package sizeSelf size: 3.58 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BridgeAR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are sadly still failing
|
|
||
| const spawnEnv = { DD_TRACE_FLUSH_INTERVAL: '2000' } | ||
|
|
||
| // TODO: Fix this test / esm issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // TODO: Fix this test / esm issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is skipped again. As long as we pass the azure-functions tests we know my change is working.
BenchmarksBenchmark execution time: 2025-12-12 16:00:27 Comparing candidate commit f11e330 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 290 metrics, 30 unstable metrics. |
BridgeAR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a regression test that checks that ctx.batch._spanContexts is not changed anymore?
What does this PR do?
Motivation
Originally we used Azure's built in spanContext map to store span context for our span links. This could cause conflicts with Azure Application Inights if OTel is enabled, because Azure uses this map to generate their span links.
Plugin Checklist
Additional Notes