-
Notifications
You must be signed in to change notification settings - Fork 319
🍒 9909 - Fix npe on ConflatingMetricsAggregator when the resource is null #9938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(cherry picked from commit 6f71652)
|
🎯 Code Coverage 🔗 Commit SHA: 44c1e5f | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 12 performance improvements and 10 performance regressions! Performance is the same for 31 metrics, 12 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~44c1e5f367, baseline=1.56.0-SNAPSHOT~b99070a00c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.104 s) : 0, 1103665
Total [baseline] (10.679 s) : 0, 10678752
Agent [candidate] (1.039 s) : 0, 1038535
Total [candidate] (10.878 s) : 0, 10877985
section appsec
Agent [baseline] (1.289 s) : 0, 1289201
Total [baseline] (11.239 s) : 0, 11239224
Agent [candidate] (1.209 s) : 0, 1208717
Total [candidate] (10.949 s) : 0, 10949285
section iast
Agent [baseline] (1.256 s) : 0, 1255693
Total [baseline] (11.231 s) : 0, 11230882
Agent [candidate] (1.16 s) : 0, 1159838
Total [candidate] (11.167 s) : 0, 11166845
section profiling
Agent [baseline] (1.251 s) : 0, 1250659
Total [baseline] (11.146 s) : 0, 11146227
Agent [candidate] (1.188 s) : 0, 1188455
Total [candidate] (10.995 s) : 0, 10994806
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~44c1e5f367, baseline=1.56.0-SNAPSHOT~b99070a00c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (705.214 ms) : 0, 705214
BytebuddyAgent [candidate] (708.55 ms) : 0, 708550
GlobalTracer [baseline] (248.235 ms) : 0, 248235
GlobalTracer [candidate] (247.013 ms) : 0, 247013
AppSec [baseline] (32.287 ms) : 0, 32287
AppSec [candidate] (32.626 ms) : 0, 32626
Debugger [baseline] (69.116 ms) : 0, 69116
Debugger [candidate] (6.506 ms) : 0, 6506
Remote Config [baseline] (636.432 µs) : 0, 636
Remote Config [candidate] (688.664 µs) : 0, 689
Telemetry [baseline] (8.247 ms) : 0, 8247
Telemetry [candidate] (13.85 ms) : 0, 13850
Flare Poller [baseline] (3.793 ms) : 0, 3793
Flare Poller [candidate] (6.507 ms) : 0, 6507
section appsec
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.487 ms) : 0, 1487
BytebuddyAgent [baseline] (735.201 ms) : 0, 735201
BytebuddyAgent [candidate] (729.861 ms) : 0, 729861
GlobalTracer [baseline] (242.471 ms) : 0, 242471
GlobalTracer [candidate] (237.268 ms) : 0, 237268
IAST [baseline] (25.122 ms) : 0, 25122
IAST [candidate] (25.2 ms) : 0, 25200
AppSec [baseline] (175.191 ms) : 0, 175191
AppSec [candidate] (174.76 ms) : 0, 174760
Debugger [baseline] (61.647 ms) : 0, 61647
Debugger [candidate] (5.92 ms) : 0, 5920
Remote Config [baseline] (665.185 µs) : 0, 665
Remote Config [candidate] (637.698 µs) : 0, 638
Telemetry [baseline] (8.46 ms) : 0, 8460
Telemetry [candidate] (8.431 ms) : 0, 8431
Flare Poller [baseline] (3.915 ms) : 0, 3915
Flare Poller [candidate] (3.942 ms) : 0, 3942
section iast
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (839.567 ms) : 0, 839567
BytebuddyAgent [candidate] (823.218 ms) : 0, 823218
GlobalTracer [baseline] (238.884 ms) : 0, 238884
GlobalTracer [candidate] (233.708 ms) : 0, 233708
IAST [baseline] (30.329 ms) : 0, 30329
IAST [candidate] (34.134 ms) : 0, 34134
AppSec [baseline] (31.637 ms) : 0, 31637
AppSec [candidate] (27.034 ms) : 0, 27034
Debugger [baseline] (66.783 ms) : 0, 66783
Debugger [candidate] (6.043 ms) : 0, 6043
Remote Config [baseline] (556.426 µs) : 0, 556
Remote Config [candidate] (588.762 µs) : 0, 589
Telemetry [baseline] (7.875 ms) : 0, 7875
Telemetry [candidate] (8.294 ms) : 0, 8294
Flare Poller [baseline] (3.597 ms) : 0, 3597
Flare Poller [candidate] (4.096 ms) : 0, 4096
section profiling
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (741.181 ms) : 0, 741181
BytebuddyAgent [candidate] (736.195 ms) : 0, 736195
GlobalTracer [baseline] (225.3 ms) : 0, 225300
GlobalTracer [candidate] (223.204 ms) : 0, 223204
AppSec [baseline] (33.053 ms) : 0, 33053
AppSec [candidate] (34.311 ms) : 0, 34311
Debugger [baseline] (69.257 ms) : 0, 69257
Debugger [candidate] (10.667 ms) : 0, 10667
Remote Config [baseline] (665.186 µs) : 0, 665
Remote Config [candidate] (693.49 µs) : 0, 693
Telemetry [baseline] (8.123 ms) : 0, 8123
Telemetry [candidate] (10.63 ms) : 0, 10630
Flare Poller [baseline] (3.869 ms) : 0, 3869
Flare Poller [candidate] (4.251 ms) : 0, 4251
ProfilingAgent [baseline] (97.029 ms) : 0, 97029
ProfilingAgent [candidate] (110.652 ms) : 0, 110652
Profiling [baseline] (97.634 ms) : 0, 97634
Profiling [candidate] (111.299 ms) : 0, 111299
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~44c1e5f367, baseline=1.56.0-SNAPSHOT~b99070a00c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.111 s) : 0, 1111108
Total [baseline] (8.846 s) : 0, 8846401
Agent [candidate] (1.032 s) : 0, 1031991
Total [candidate] (8.666 s) : 0, 8665640
section iast
Agent [baseline] (1.241 s) : 0, 1240859
Total [baseline] (9.577 s) : 0, 9577164
Agent [candidate] (1.17 s) : 0, 1170228
Total [candidate] (9.353 s) : 0, 9352756
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~44c1e5f367, baseline=1.56.0-SNAPSHOT~b99070a00c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.468 ms) : 0, 1468
BytebuddyAgent [baseline] (711.3 ms) : 0, 711300
BytebuddyAgent [candidate] (703.929 ms) : 0, 703929
GlobalTracer [baseline] (249.801 ms) : 0, 249801
GlobalTracer [candidate] (245.298 ms) : 0, 245298
AppSec [baseline] (32.588 ms) : 0, 32588
AppSec [candidate] (32.202 ms) : 0, 32202
Debugger [baseline] (68.596 ms) : 0, 68596
Debugger [candidate] (6.374 ms) : 0, 6374
Remote Config [baseline] (637.034 µs) : 0, 637
Remote Config [candidate] (687.541 µs) : 0, 688
Telemetry [baseline] (8.136 ms) : 0, 8136
Telemetry [candidate] (15.933 ms) : 0, 15933
Flare Poller [baseline] (3.702 ms) : 0, 3702
Flare Poller [candidate] (4.939 ms) : 0, 4939
section iast
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.486 ms) : 0, 1486
BytebuddyAgent [baseline] (828.68 ms) : 0, 828680
BytebuddyAgent [candidate] (831.752 ms) : 0, 831752
GlobalTracer [baseline] (237.581 ms) : 0, 237581
GlobalTracer [candidate] (234.934 ms) : 0, 234934
IAST [baseline] (29.211 ms) : 0, 29211
IAST [candidate] (32.603 ms) : 0, 32603
AppSec [baseline] (32.271 ms) : 0, 32271
AppSec [candidate] (28.889 ms) : 0, 28889
Debugger [baseline] (65.08 ms) : 0, 65080
Debugger [candidate] (6.091 ms) : 0, 6091
Remote Config [baseline] (543.615 µs) : 0, 544
Remote Config [candidate] (598.012 µs) : 0, 598
Telemetry [baseline] (7.789 ms) : 0, 7789
Telemetry [candidate] (8.407 ms) : 0, 8407
Flare Poller [baseline] (3.53 ms) : 0, 3530
Flare Poller [candidate] (4.089 ms) : 0, 4089
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 3 performance regressions! Performance is the same for 13 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~44c1e5f367, baseline=1.56.0-SNAPSHOT~b99070a00c
dateFormat X
axisFormat %s
section baseline
no_agent (1.18 ms) : 1169, 1190
. : milestone, 1180,
iast (3.173 ms) : 3133, 3213
. : milestone, 3173,
iast_FULL (5.709 ms) : 5652, 5765
. : milestone, 5709,
iast_GLOBAL (3.681 ms) : 3619, 3743
. : milestone, 3681,
profiling (2.101 ms) : 2081, 2122
. : milestone, 2101,
tracing (1.802 ms) : 1788, 1816
. : milestone, 1802,
section candidate
no_agent (1.231 ms) : 1218, 1243
. : milestone, 1231,
iast (3.126 ms) : 3086, 3166
. : milestone, 3126,
iast_FULL (5.85 ms) : 5792, 5908
. : milestone, 5850,
iast_GLOBAL (3.598 ms) : 3546, 3651
. : milestone, 3598,
profiling (1.93 ms) : 1914, 1946
. : milestone, 1930,
tracing (1.792 ms) : 1778, 1805
. : milestone, 1792,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~44c1e5f367, baseline=1.56.0-SNAPSHOT~b99070a00c
dateFormat X
axisFormat %s
section baseline
no_agent (17.399 ms) : 17227, 17572
. : milestone, 17399,
appsec (18.599 ms) : 18409, 18789
. : milestone, 18599,
code_origins (18.976 ms) : 18786, 19167
. : milestone, 18976,
iast (18.741 ms) : 18556, 18926
. : milestone, 18741,
profiling (20.648 ms) : 20443, 20853
. : milestone, 20648,
tracing (17.721 ms) : 17544, 17898
. : milestone, 17721,
section candidate
no_agent (17.597 ms) : 17420, 17773
. : milestone, 17597,
appsec (20.683 ms) : 20472, 20894
. : milestone, 20683,
code_origins (19.242 ms) : 19051, 19434
. : milestone, 19242,
iast (17.648 ms) : 17474, 17821
. : milestone, 17648,
profiling (18.439 ms) : 18258, 18620
. : milestone, 18439,
tracing (18.558 ms) : 18375, 18741
. : milestone, 18558,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~44c1e5f367, baseline=1.56.0-SNAPSHOT~5dde230896
dateFormat X
axisFormat %s
section baseline
no_agent (1.482 ms) : 1471, 1494
. : milestone, 1482,
appsec (3.708 ms) : 3490, 3925
. : milestone, 3708,
iast (2.221 ms) : 2157, 2285
. : milestone, 2221,
iast_GLOBAL (2.266 ms) : 2202, 2330
. : milestone, 2266,
profiling (2.086 ms) : 2032, 2139
. : milestone, 2086,
tracing (2.028 ms) : 1978, 2077
. : milestone, 2028,
section candidate
no_agent (1.489 ms) : 1478, 1501
. : milestone, 1489,
appsec (3.657 ms) : 3444, 3870
. : milestone, 3657,
iast (2.225 ms) : 2161, 2288
. : milestone, 2225,
iast_GLOBAL (2.254 ms) : 2190, 2318
. : milestone, 2254,
profiling (2.06 ms) : 2009, 2112
. : milestone, 2060,
tracing (2.035 ms) : 1986, 2085
. : milestone, 2035,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~44c1e5f367, baseline=1.56.0-SNAPSHOT~5dde230896
dateFormat X
axisFormat %s
section baseline
no_agent (15.609 s) : 15609000, 15609000
. : milestone, 15609000,
appsec (14.645 s) : 14645000, 14645000
. : milestone, 14645000,
iast (18.555 s) : 18555000, 18555000
. : milestone, 18555000,
iast_GLOBAL (17.714 s) : 17714000, 17714000
. : milestone, 17714000,
profiling (15.823 s) : 15823000, 15823000
. : milestone, 15823000,
tracing (14.757 s) : 14757000, 14757000
. : milestone, 14757000,
section candidate
no_agent (15.256 s) : 15256000, 15256000
. : milestone, 15256000,
appsec (14.891 s) : 14891000, 14891000
. : milestone, 14891000,
iast (18.386 s) : 18386000, 18386000
. : milestone, 18386000,
iast_GLOBAL (18.102 s) : 18102000, 18102000
. : milestone, 18102000,
profiling (15.356 s) : 15356000, 15356000
. : milestone, 15356000,
tracing (15.466 s) : 15466000, 15466000
. : milestone, 15466000,
|
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Back-porting the approval
Pull request was closed
Backport #9909 to release/v1.55.x