Skip to content

Add metrics OpenTelemetry instrumentation entry mechanism #9908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add metrics OpenTelemetry instrumentation entry mechanism #9908

wants to merge 10 commits into from

Conversation

@cecile75
Copy link
Contributor

@cecile75 cecile75 commented Nov 6, 2025 •
edited
Loading

What Does This Do

Initial OpenTelemetry metrics instrumentation and stubbed types to support the OTel metrics API - tests will be added as the various stubs are replaced with real implementations

Motivation

OpenTelemetry Metrics API support

Additional Notes

Jira ticket: APMAPI-1671

@cecile75 cecile75 added type: enhancement Enhancements and improvements tag: no release notes Changes to exclude from release notes inst: opentelemetry OpenTelemetry instrumentation labels Nov 6, 2025
@datadog-official

This comment has been minimized.

Sign in to view
@pr-commenter
Copy link

pr-commenter bot commented Nov 6, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master cecile/otelmetrics13
git_commit_date 1763992896 1763995026
git_commit_sha c8bb444 b4d62f3
release_version 1.57.0-SNAPSHOT~c8bb44440b 1.55.0-SNAPSHOT~b4d62f343d
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1763996931 1763996931
ci_job_id 1253599942 1253599942
ci_pipeline_id 83807036 83807036
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-7dw7doip 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-7dw7doip 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~b4d62f343d, baseline=1.57.0-SNAPSHOT~c8bb44440b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.1 s) : 0, 1099636
Total [baseline] (10.817 s) : 0, 10817279
Agent [candidate] (1.103 s) : 0, 1102705
Total [candidate] (10.859 s) : 0, 10859365
section appsec
Agent [baseline] (1.282 s) : 0, 1282136
Total [baseline] (11.146 s) : 0, 11146216
Agent [candidate] (1.287 s) : 0, 1286832
Total [candidate] (11.133 s) : 0, 11132706
section iast
Agent [baseline] (1.24 s) : 0, 1239763
Total [baseline] (11.271 s) : 0, 11270829
Agent [candidate] (1.24 s) : 0, 1239578
Total [candidate] (11.262 s) : 0, 11261754
section profiling
Agent [baseline] (1.231 s) : 0, 1231088
Total [baseline] (11.125 s) : 0, 11125070
Agent [candidate] (1.234 s) : 0, 1233895
Total [candidate] (11.142 s) : 0, 11142131
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.1 s -
Agent appsec 1.282 s 182.5 ms (16.6%)
Agent iast 1.24 s 140.127 ms (12.7%)
Agent profiling 1.231 s 131.452 ms (12.0%)
Total tracing 10.817 s -
Total appsec 11.146 s 328.937 ms (3.0%)
Total iast 11.271 s 453.55 ms (4.2%)
Total profiling 11.125 s 307.791 ms (2.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.103 s -
Agent appsec 1.287 s 184.126 ms (16.7%)
Agent iast 1.24 s 136.873 ms (12.4%)
Agent profiling 1.234 s 131.19 ms (11.9%)
Total tracing 10.859 s -
Total appsec 11.133 s 273.341 ms (2.5%)
Total iast 11.262 s 402.389 ms (3.7%)
Total profiling 11.142 s 282.766 ms (2.6%) 
gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~b4d62f343d, baseline=1.57.0-SNAPSHOT~c8bb44440b

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.481 ms) : 0, 1481
crashtracking [candidate] (1.476 ms) : 0, 1476
BytebuddyAgent [baseline] (706.333 ms) : 0, 706333
BytebuddyAgent [candidate] (708.41 ms) : 0, 708410
GlobalTracer [baseline] (248.529 ms) : 0, 248529
GlobalTracer [candidate] (249.546 ms) : 0, 249546
AppSec [baseline] (31.955 ms) : 0, 31955
AppSec [candidate] (31.849 ms) : 0, 31849
Debugger [baseline] (64.043 ms) : 0, 64043
Debugger [candidate] (64.007 ms) : 0, 64007
Remote Config [baseline] (631.568 µs) : 0, 632
Remote Config [candidate] (622.988 µs) : 0, 623
Telemetry [baseline] (8.275 ms) : 0, 8275
Telemetry [candidate] (8.268 ms) : 0, 8268
Flare Poller [baseline] (3.68 ms) : 0, 3680
Flare Poller [candidate] (3.688 ms) : 0, 3688
section appsec
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.484 ms) : 0, 1484
BytebuddyAgent [baseline] (731.856 ms) : 0, 731856
BytebuddyAgent [candidate] (735.111 ms) : 0, 735111
GlobalTracer [baseline] (240.488 ms) : 0, 240488
GlobalTracer [candidate] (241.9 ms) : 0, 241900
IAST [baseline] (24.812 ms) : 0, 24812
IAST [candidate] (24.829 ms) : 0, 24829
AppSec [baseline] (174.515 ms) : 0, 174515
AppSec [candidate] (174.235 ms) : 0, 174235
Debugger [baseline] (61.257 ms) : 0, 61257
Debugger [candidate] (61.487 ms) : 0, 61487
Remote Config [baseline] (674.586 µs) : 0, 675
Remote Config [candidate] (675.046 µs) : 0, 675
Telemetry [baseline] (8.198 ms) : 0, 8198
Telemetry [candidate] (8.102 ms) : 0, 8102
Flare Poller [baseline] (3.925 ms) : 0, 3925
Flare Poller [candidate] (4.024 ms) : 0, 4024
section iast
crashtracking [baseline] (1.493 ms) : 0, 1493
crashtracking [candidate] (1.476 ms) : 0, 1476
BytebuddyAgent [baseline] (831.81 ms) : 0, 831810
BytebuddyAgent [candidate] (832.636 ms) : 0, 832636
GlobalTracer [baseline] (238.058 ms) : 0, 238058
GlobalTracer [candidate] (237.036 ms) : 0, 237036
IAST [baseline] (28.365 ms) : 0, 28365
IAST [candidate] (29.215 ms) : 0, 29215
AppSec [baseline] (33.026 ms) : 0, 33026
AppSec [candidate] (32.133 ms) : 0, 32133
Debugger [baseline] (60.62 ms) : 0, 60620
Debugger [candidate] (60.558 ms) : 0, 60558
Remote Config [baseline] (538.57 µs) : 0, 539
Remote Config [candidate] (541.401 µs) : 0, 541
Telemetry [baseline] (7.575 ms) : 0, 7575
Telemetry [candidate] (7.585 ms) : 0, 7585
Flare Poller [baseline] (3.467 ms) : 0, 3467
Flare Poller [candidate] (3.554 ms) : 0, 3554
section profiling
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (733.118 ms) : 0, 733118
BytebuddyAgent [candidate] (734.344 ms) : 0, 734344
GlobalTracer [baseline] (222.833 ms) : 0, 222833
GlobalTracer [candidate] (222.53 ms) : 0, 222530
AppSec [baseline] (32.052 ms) : 0, 32052
AppSec [candidate] (32.333 ms) : 0, 32333
Debugger [baseline] (63.437 ms) : 0, 63437
Debugger [candidate] (64.264 ms) : 0, 64264
Remote Config [baseline] (656.902 µs) : 0, 657
Remote Config [candidate] (662.12 µs) : 0, 662
Telemetry [baseline] (7.904 ms) : 0, 7904
Telemetry [candidate] (8.162 ms) : 0, 8162
Flare Poller [baseline] (3.749 ms) : 0, 3749
Flare Poller [candidate] (3.803 ms) : 0, 3803
ProfilingAgent [baseline] (96.789 ms) : 0, 96789
ProfilingAgent [candidate] (97.251 ms) : 0, 97251
Profiling [baseline] (97.375 ms) : 0, 97375
Profiling [candidate] (97.83 ms) : 0, 97830
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~b4d62f343d, baseline=1.57.0-SNAPSHOT~c8bb44440b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.103 s) : 0, 1102619
Total [baseline] (8.829 s) : 0, 8828795
Agent [candidate] (1.103 s) : 0, 1102991
Total [candidate] (8.913 s) : 0, 8912702
section iast
Agent [baseline] (1.239 s) : 0, 1239221
Total [baseline] (9.58 s) : 0, 9579631
Agent [candidate] (1.24 s) : 0, 1239723
Total [candidate] (9.583 s) : 0, 9582716
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.103 s -
Agent iast 1.239 s 136.602 ms (12.4%)
Total tracing 8.829 s -
Total iast 9.58 s 750.836 ms (8.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.103 s -
Agent iast 1.24 s 136.732 ms (12.4%)
Total tracing 8.913 s -
Total iast 9.583 s 670.014 ms (7.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~b4d62f343d, baseline=1.57.0-SNAPSHOT~c8bb44440b

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.494 ms) : 0, 1494
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (709.209 ms) : 0, 709209
BytebuddyAgent [candidate] (708.657 ms) : 0, 708657
GlobalTracer [baseline] (249.321 ms) : 0, 249321
GlobalTracer [candidate] (249.589 ms) : 0, 249589
AppSec [baseline] (32.023 ms) : 0, 32023
AppSec [candidate] (32.0 ms) : 0, 32000
Debugger [baseline] (63.209 ms) : 0, 63209
Debugger [candidate] (63.829 ms) : 0, 63829
Remote Config [baseline] (631.155 µs) : 0, 631
Remote Config [candidate] (629.297 µs) : 0, 629
Telemetry [baseline] (8.117 ms) : 0, 8117
Telemetry [candidate] (8.173 ms) : 0, 8173
Flare Poller [baseline] (3.634 ms) : 0, 3634
Flare Poller [candidate] (3.708 ms) : 0, 3708
section iast
crashtracking [baseline] (1.495 ms) : 0, 1495
crashtracking [candidate] (1.493 ms) : 0, 1493
BytebuddyAgent [baseline] (832.095 ms) : 0, 832095
BytebuddyAgent [candidate] (832.655 ms) : 0, 832655
GlobalTracer [baseline] (237.582 ms) : 0, 237582
GlobalTracer [candidate] (237.408 ms) : 0, 237408
AppSec [baseline] (32.435 ms) : 0, 32435
AppSec [candidate] (30.56 ms) : 0, 30560
Debugger [baseline] (59.999 ms) : 0, 59999
Debugger [candidate] (59.887 ms) : 0, 59887
Remote Config [baseline] (558.078 µs) : 0, 558
Remote Config [candidate] (558.974 µs) : 0, 559
Telemetry [baseline] (7.632 ms) : 0, 7632
Telemetry [candidate] (7.632 ms) : 0, 7632
Flare Poller [baseline] (3.487 ms) : 0, 3487
Flare Poller [candidate] (3.582 ms) : 0, 3582
IAST [baseline] (29.1 ms) : 0, 29100
IAST [candidate] (31.145 ms) : 0, 31145
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master cecile/otelmetrics13
git_commit_date 1763992896 1763995026
git_commit_sha c8bb444 b4d62f3
release_version 1.57.0-SNAPSHOT~c8bb44440b 1.55.0-SNAPSHOT~b4d62f343d
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1763997327 1763997327
ci_job_id 1253599943 1253599943
ci_pipeline_id 83807036 83807036
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-9j0tb56u 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-9j0tb56u 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 20 metrics, 15 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:insecure-bank:profiling:high_load worse
[+40.264µs; +170.289µs] or [+2.476%; +10.470%]		 unstable
[+282.040µs; +1087.229µs] or [+6.378%; +24.585%]		 unstable
[-480.723op/s; +66.161op/s] or [-20.860%; +2.871%]		 1.732ms 5.107ms 2097.188op/s 1.626ms 4.422ms 2304.469op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~b4d62f343d, baseline=1.57.0-SNAPSHOT~c8bb44440b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.206 ms) : 1194, 1218
.   : milestone, 1206,
iast (3.25 ms) : 3200, 3300
.   : milestone, 3250,
iast_FULL (5.765 ms) : 5707, 5823
.   : milestone, 5765,
iast_GLOBAL (3.606 ms) : 3553, 3659
.   : milestone, 3606,
profiling (1.957 ms) : 1940, 1974
.   : milestone, 1957,
tracing (1.812 ms) : 1798, 1827
.   : milestone, 1812,
section candidate
no_agent (1.201 ms) : 1189, 1213
.   : milestone, 1201,
iast (3.288 ms) : 3241, 3335
.   : milestone, 3288,
iast_FULL (5.773 ms) : 5715, 5831
.   : milestone, 5773,
iast_GLOBAL (3.637 ms) : 3566, 3708
.   : milestone, 3637,
profiling (2.158 ms) : 2138, 2178
.   : milestone, 2158,
tracing (1.81 ms) : 1795, 1825
.   : milestone, 1810,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.206 ms [1.194 ms, 1.218 ms] -
iast 3.25 ms [3.2 ms, 3.3 ms] 2.044 ms (169.5%)
iast_FULL 5.765 ms [5.707 ms, 5.823 ms] 4.559 ms (378.0%)
iast_GLOBAL 3.606 ms [3.553 ms, 3.659 ms] 2.4 ms (199.0%)
profiling 1.957 ms [1.94 ms, 1.974 ms] 750.97 µs (62.3%)
tracing 1.812 ms [1.798 ms, 1.827 ms] 606.354 µs (50.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.201 ms [1.189 ms, 1.213 ms] -
iast 3.288 ms [3.241 ms, 3.335 ms] 2.087 ms (173.8%)
iast_FULL 5.773 ms [5.715 ms, 5.831 ms] 4.572 ms (380.7%)
iast_GLOBAL 3.637 ms [3.566 ms, 3.708 ms] 2.436 ms (202.8%)
profiling 2.158 ms [2.138 ms, 2.178 ms] 956.918 µs (79.7%)
tracing 1.81 ms [1.795 ms, 1.825 ms] 609.082 µs (50.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~b4d62f343d, baseline=1.57.0-SNAPSHOT~c8bb44440b
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.768 ms) : 18581, 18956
.   : milestone, 18768,
appsec (18.523 ms) : 18337, 18710
.   : milestone, 18523,
code_origins (17.654 ms) : 17479, 17829
.   : milestone, 17654,
iast (17.82 ms) : 17644, 17996
.   : milestone, 17820,
profiling (19.444 ms) : 19249, 19639
.   : milestone, 19444,
tracing (17.772 ms) : 17593, 17951
.   : milestone, 17772,
section candidate
no_agent (18.78 ms) : 18592, 18969
.   : milestone, 18780,
appsec (18.689 ms) : 18500, 18878
.   : milestone, 18689,
code_origins (17.69 ms) : 17516, 17863
.   : milestone, 17690,
iast (17.549 ms) : 17374, 17723
.   : milestone, 17549,
profiling (19.079 ms) : 18888, 19271
.   : milestone, 19079,
tracing (17.717 ms) : 17541, 17893
.   : milestone, 17717,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.768 ms [18.581 ms, 18.956 ms] -
appsec 18.523 ms [18.337 ms, 18.71 ms] -245.105 µs (-1.3%)
code_origins 17.654 ms [17.479 ms, 17.829 ms] -1.115 ms (-5.9%)
iast 17.82 ms [17.644 ms, 17.996 ms] -948.378 µs (-5.1%)
profiling 19.444 ms [19.249 ms, 19.639 ms] 675.557 µs (3.6%)
tracing 17.772 ms [17.593 ms, 17.951 ms] -996.594 µs (-5.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.78 ms [18.592 ms, 18.969 ms] -
appsec 18.689 ms [18.5 ms, 18.878 ms] -91.4 µs (-0.5%)
code_origins 17.69 ms [17.516 ms, 17.863 ms] -1.091 ms (-5.8%)
iast 17.549 ms [17.374 ms, 17.723 ms] -1.232 ms (-6.6%)
profiling 19.079 ms [18.888 ms, 19.271 ms] 298.767 µs (1.6%)
tracing 17.717 ms [17.541 ms, 17.893 ms] -1.063 ms (-5.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master cecile/otelmetrics13
git_commit_date 1763992896 1763995026
git_commit_sha c8bb444 b4d62f3
release_version 1.57.0-SNAPSHOT~c8bb44440b 1.55.0-SNAPSHOT~b4d62f343d
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1763997249 1763997249
ci_job_id 1253599944 1253599944
ci_pipeline_id 83807036 83807036
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-srkryovm 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-srkryovm 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~b4d62f343d, baseline=1.57.0-SNAPSHOT~c8bb44440b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
.   : milestone, 1478,
appsec (2.475 ms) : 2424, 2527
.   : milestone, 2475,
iast (2.23 ms) : 2165, 2295
.   : milestone, 2230,
iast_GLOBAL (2.27 ms) : 2205, 2335
.   : milestone, 2270,
profiling (2.087 ms) : 2035, 2140
.   : milestone, 2087,
tracing (2.061 ms) : 2010, 2112
.   : milestone, 2061,
section candidate
no_agent (1.48 ms) : 1468, 1491
.   : milestone, 1480,
appsec (2.481 ms) : 2428, 2533
.   : milestone, 2481,
iast (2.229 ms) : 2164, 2294
.   : milestone, 2229,
iast_GLOBAL (2.265 ms) : 2199, 2330
.   : milestone, 2265,
profiling (2.083 ms) : 2030, 2136
.   : milestone, 2083,
tracing (2.057 ms) : 2005, 2108
.   : milestone, 2057,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.478 ms [1.467 ms, 1.49 ms] -
appsec 2.475 ms [2.424 ms, 2.527 ms] 997.006 µs (67.4%)
iast 2.23 ms [2.165 ms, 2.295 ms] 751.709 µs (50.8%)
iast_GLOBAL 2.27 ms [2.205 ms, 2.335 ms] 791.457 µs (53.5%)
profiling 2.087 ms [2.035 ms, 2.14 ms] 609.033 µs (41.2%)
tracing 2.061 ms [2.01 ms, 2.112 ms] 582.435 µs (39.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.48 ms [1.468 ms, 1.491 ms] -
appsec 2.481 ms [2.428 ms, 2.533 ms] 1.001 ms (67.7%)
iast 2.229 ms [2.164 ms, 2.294 ms] 749.705 µs (50.7%)
iast_GLOBAL 2.265 ms [2.199 ms, 2.33 ms] 785.195 µs (53.1%)
profiling 2.083 ms [2.03 ms, 2.136 ms] 603.688 µs (40.8%)
tracing 2.057 ms [2.005 ms, 2.108 ms] 577.042 µs (39.0%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~b4d62f343d, baseline=1.57.0-SNAPSHOT~c8bb44440b
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.481 s) : 15481000, 15481000
.   : milestone, 15481000,
appsec (14.861 s) : 14861000, 14861000
.   : milestone, 14861000,
iast (18.102 s) : 18102000, 18102000
.   : milestone, 18102000,
iast_GLOBAL (17.867 s) : 17867000, 17867000
.   : milestone, 17867000,
profiling (14.604 s) : 14604000, 14604000
.   : milestone, 14604000,
tracing (14.828 s) : 14828000, 14828000
.   : milestone, 14828000,
section candidate
no_agent (15.668 s) : 15668000, 15668000
.   : milestone, 15668000,
appsec (14.745 s) : 14745000, 14745000
.   : milestone, 14745000,
iast (18.588 s) : 18588000, 18588000
.   : milestone, 18588000,
iast_GLOBAL (18.052 s) : 18052000, 18052000
.   : milestone, 18052000,
profiling (15.237 s) : 15237000, 15237000
.   : milestone, 15237000,
tracing (15.0 s) : 15000000, 15000000
.   : milestone, 15000000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.481 s [15.481 s, 15.481 s] -
appsec 14.861 s [14.861 s, 14.861 s] -620.0 ms (-4.0%)
iast 18.102 s [18.102 s, 18.102 s] 2.621 s (16.9%)
iast_GLOBAL 17.867 s [17.867 s, 17.867 s] 2.386 s (15.4%)
profiling 14.604 s [14.604 s, 14.604 s] -877.0 ms (-5.7%)
tracing 14.828 s [14.828 s, 14.828 s] -653.0 ms (-4.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.668 s [15.668 s, 15.668 s] -
appsec 14.745 s [14.745 s, 14.745 s] -923.0 ms (-5.9%)
iast 18.588 s [18.588 s, 18.588 s] 2.92 s (18.6%)
iast_GLOBAL 18.052 s [18.052 s, 18.052 s] 2.384 s (15.2%)
profiling 15.237 s [15.237 s, 15.237 s] -431.0 ms (-2.8%)
tracing 15.0 s [15.0 s, 15.0 s] -668.0 ms (-4.3%)

@cecile75 cecile75 marked this pull request as ready for review November 12, 2025 14:35
@cecile75 cecile75 requested review from a team as code owners November 12, 2025 14:35
@cecile75 cecile75 requested review from mcculls and removed request for a team November 12, 2025 14:35
mcculls
mcculls reviewed Nov 13, 2025
View reviewed changes
...agent-otel/otel-shim/src/main/java/datadog/opentelemetry/shim/metrics/OtelMeterProvider.java Outdated
Comment on lines 19 to 23
private final Map<String, List<Meter>> meters;

public OtelMeterProvider() {
this.meters = new HashMap<>();
}
Copy link
Contributor

@mcculls mcculls Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private final Map<String, List<Meter>> meters;
public OtelMeterProvider() {
this.meters = new HashMap<>();
}
private final Map<String, List<Meter>> scopedMeters = new ConcurrentHashMap();

Users may call this from different threads, so the map needs to handle concurrent updates.

Also final fields can be assigned in the same line, avoiding the need to do that in the constructor.

This can mean you can drop the constructor completely, making the code more concise.

Lastly I would call this field scopedMeters because it holds meters indexed by scope.

(This helps make the code clearer later on when you query scopedMeters and store the list of meters for that scope in a variable called meters)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcculls mcculls mcculls left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

inst: opentelemetry OpenTelemetry instrumentation tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cecile75 @mcculls