Add NativeLoader listener support #9903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adding test to CompositeLibraryLoadingListener
- adding test of NativeLoader.Builder listener related methods
- adding end-to-end test for preloading listener support
- checking platformSpec overrides
- checking component support
- added tests for temporary file creation - exposed a problem with TestLibraryLoadingListener errors getting swallowed in CompositeLibraryLoadingListener - adding failure tracking into TestLibraryLoadingListener that is checked in assertDone
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
dougqh
added
comp: core
dougqh
commented
Nov 5, 2025
| this.loadImpl(null, libName, EMPTY_LISTENERS); | ||
| } | ||
|
|
||
| public void load(String libName, LibraryLoadingListener... scopedListeners) |
Contributor
Author
There was a problem hiding this comment.
This is probably the most questionable part.
I decided it would be nice for each caller to listen to just its libraries, so I added the ability to tack on a listener that is scoped to a single library.
dougqh
commented
Nov 5, 2025
components/native-loader/src/main/java/datadog/nativeloader/LibraryLoadingListener.java
Show resolved
Hide resolved
dougqh
commented
Nov 5, 2025
| String optionalComponent, | ||
| String libName, | ||
| LibraryLoadException optionalCause) {} | ||
|
|
Contributor
Author
There was a problem hiding this comment.
We'll probably end up tweaking the methods for temp file notification if/when we add in pluggable temp file managers.
dougqh
commented
Nov 5, 2025
components/native-loader/src/test/java/datadog/nativeloader/NativeLoaderTest.java
Show resolved
Hide resolved
Contributor
|
🎯 Code Coverage 🔗 Commit SHA: 5fff446 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~5fff446671, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.11 s) : 0, 1110461
Total [baseline] (10.789 s) : 0, 10789124
Agent [candidate] (1.101 s) : 0, 1100591
Total [candidate] (10.72 s) : 0, 10720116
section appsec
Agent [baseline] (1.29 s) : 0, 1289605
Total [baseline] (11.151 s) : 0, 11150560
Agent [candidate] (1.285 s) : 0, 1285130
Total [candidate] (11.238 s) : 0, 11238258
section iast
Agent [baseline] (1.24 s) : 0, 1239740
Total [baseline] (11.203 s) : 0, 11203428
Agent [candidate] (1.235 s) : 0, 1235163
Total [candidate] (11.143 s) : 0, 11142703
section profiling
Agent [baseline] (1.228 s) : 0, 1227941
Total [baseline] (11.098 s) : 0, 11097537
Agent [candidate] (1.227 s) : 0, 1227272
Total [candidate] (11.041 s) : 0, 11040794
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~5fff446671, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (713.136 ms) : 0, 713136
BytebuddyAgent [candidate] (706.607 ms) : 0, 706607
GlobalTracer [baseline] (250.516 ms) : 0, 250516
GlobalTracer [candidate] (248.687 ms) : 0, 248687
AppSec [baseline] (32.817 ms) : 0, 32817
AppSec [candidate] (32.318 ms) : 0, 32318
Debugger [baseline] (64.961 ms) : 0, 64961
Debugger [candidate] (64.422 ms) : 0, 64422
Remote Config [baseline] (651.511 µs) : 0, 652
Remote Config [candidate] (634.224 µs) : 0, 634
Telemetry [baseline] (8.257 ms) : 0, 8257
Telemetry [candidate] (8.169 ms) : 0, 8169
Flare Poller [baseline] (3.772 ms) : 0, 3772
Flare Poller [candidate] (3.682 ms) : 0, 3682
section appsec
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (735.916 ms) : 0, 735916
BytebuddyAgent [candidate] (731.27 ms) : 0, 731270
GlobalTracer [baseline] (242.595 ms) : 0, 242595
GlobalTracer [candidate] (242.007 ms) : 0, 242007
IAST [baseline] (25.387 ms) : 0, 25387
IAST [candidate] (25.118 ms) : 0, 25118
AppSec [baseline] (175.168 ms) : 0, 175168
AppSec [candidate] (174.425 ms) : 0, 174425
Debugger [baseline] (61.379 ms) : 0, 61379
Debugger [candidate] (62.766 ms) : 0, 62766
Remote Config [baseline] (653.58 µs) : 0, 654
Remote Config [candidate] (663.466 µs) : 0, 663
Telemetry [baseline] (8.367 ms) : 0, 8367
Telemetry [candidate] (8.534 ms) : 0, 8534
Flare Poller [baseline] (3.852 ms) : 0, 3852
Flare Poller [candidate] (4.028 ms) : 0, 4028
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (831.001 ms) : 0, 831001
BytebuddyAgent [candidate] (827.287 ms) : 0, 827287
GlobalTracer [baseline] (238.078 ms) : 0, 238078
GlobalTracer [candidate] (237.411 ms) : 0, 237411
IAST [baseline] (30.12 ms) : 0, 30120
IAST [candidate] (30.194 ms) : 0, 30194
AppSec [baseline] (31.726 ms) : 0, 31726
AppSec [candidate] (31.399 ms) : 0, 31399
Debugger [baseline] (60.986 ms) : 0, 60986
Debugger [candidate] (61.214 ms) : 0, 61214
Remote Config [baseline] (553.755 µs) : 0, 554
Remote Config [candidate] (543.558 µs) : 0, 544
Telemetry [baseline] (7.638 ms) : 0, 7638
Telemetry [candidate] (7.617 ms) : 0, 7617
Flare Poller [baseline] (3.465 ms) : 0, 3465
Flare Poller [candidate] (3.443 ms) : 0, 3443
section profiling
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.432 ms) : 0, 1432
BytebuddyAgent [baseline] (730.692 ms) : 0, 730692
BytebuddyAgent [candidate] (729.957 ms) : 0, 729957
GlobalTracer [baseline] (222.122 ms) : 0, 222122
GlobalTracer [candidate] (221.623 ms) : 0, 221623
AppSec [baseline] (32.294 ms) : 0, 32294
AppSec [candidate] (32.219 ms) : 0, 32219
Debugger [baseline] (62.651 ms) : 0, 62651
Debugger [candidate] (63.169 ms) : 0, 63169
Remote Config [baseline] (637.65 µs) : 0, 638
Remote Config [candidate] (646.785 µs) : 0, 647
Telemetry [baseline] (7.913 ms) : 0, 7913
Telemetry [candidate] (7.95 ms) : 0, 7950
Flare Poller [baseline] (3.746 ms) : 0, 3746
Flare Poller [candidate] (3.692 ms) : 0, 3692
ProfilingAgent [baseline] (96.834 ms) : 0, 96834
ProfilingAgent [candidate] (96.921 ms) : 0, 96921
Profiling [baseline] (97.408 ms) : 0, 97408
Profiling [candidate] (97.499 ms) : 0, 97499
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~5fff446671, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1097632
Total [baseline] (8.819 s) : 0, 8818740
Agent [candidate] (1.105 s) : 0, 1105475
Total [candidate] (8.854 s) : 0, 8853879
section iast
Agent [baseline] (1.237 s) : 0, 1237341
Total [baseline] (9.539 s) : 0, 9539297
Agent [candidate] (1.239 s) : 0, 1238848
Total [candidate] (9.552 s) : 0, 9551786
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~5fff446671, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (705.255 ms) : 0, 705255
BytebuddyAgent [candidate] (710.379 ms) : 0, 710379
GlobalTracer [baseline] (247.419 ms) : 0, 247419
GlobalTracer [candidate] (250.051 ms) : 0, 250051
AppSec [baseline] (32.577 ms) : 0, 32577
AppSec [candidate] (32.72 ms) : 0, 32720
Debugger [baseline] (63.881 ms) : 0, 63881
Debugger [candidate] (63.371 ms) : 0, 63371
Remote Config [baseline] (656.05 µs) : 0, 656
Remote Config [candidate] (702.861 µs) : 0, 703
Telemetry [baseline] (8.093 ms) : 0, 8093
Telemetry [candidate] (8.267 ms) : 0, 8267
Flare Poller [baseline] (3.644 ms) : 0, 3644
Flare Poller [candidate] (3.725 ms) : 0, 3725
section iast
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (829.756 ms) : 0, 829756
BytebuddyAgent [candidate] (830.614 ms) : 0, 830614
GlobalTracer [baseline] (237.332 ms) : 0, 237332
GlobalTracer [candidate] (238.405 ms) : 0, 238405
IAST [baseline] (27.421 ms) : 0, 27421
IAST [candidate] (30.892 ms) : 0, 30892
AppSec [baseline] (34.245 ms) : 0, 34245
AppSec [candidate] (30.56 ms) : 0, 30560
Debugger [baseline] (60.58 ms) : 0, 60580
Debugger [candidate] (60.338 ms) : 0, 60338
Remote Config [baseline] (556.292 µs) : 0, 556
Remote Config [candidate] (547.075 µs) : 0, 547
Telemetry [baseline] (7.706 ms) : 0, 7706
Telemetry [candidate] (7.741 ms) : 0, 7741
Flare Poller [baseline] (3.48 ms) : 0, 3480
Flare Poller [candidate] (3.488 ms) : 0, 3488
LoadParameters
See matching parameters
SummaryFound 6 performance improvements and 2 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~5fff446671, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section baseline
no_agent (1.185 ms) : 1173, 1196
. : milestone, 1185,
iast (3.25 ms) : 3203, 3296
. : milestone, 3250,
iast_FULL (5.606 ms) : 5551, 5661
. : milestone, 5606,
iast_GLOBAL (3.812 ms) : 3750, 3873
. : milestone, 3812,
profiling (2.124 ms) : 2105, 2143
. : milestone, 2124,
tracing (1.797 ms) : 1783, 1812
. : milestone, 1797,
section candidate
no_agent (1.213 ms) : 1201, 1225
. : milestone, 1213,
iast (3.197 ms) : 3115, 3280
. : milestone, 3197,
iast_FULL (6.065 ms) : 6003, 6126
. : milestone, 6065,
iast_GLOBAL (3.568 ms) : 3478, 3658
. : milestone, 3568,
profiling (1.981 ms) : 1964, 1998
. : milestone, 1981,
tracing (1.838 ms) : 1823, 1854
. : milestone, 1838,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~5fff446671, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section baseline
no_agent (17.874 ms) : 17692, 18056
. : milestone, 17874,
appsec (20.021 ms) : 19815, 20227
. : milestone, 20021,
code_origins (17.929 ms) : 17753, 18104
. : milestone, 17929,
iast (17.588 ms) : 17412, 17763
. : milestone, 17588,
profiling (19.707 ms) : 19510, 19904
. : milestone, 19707,
tracing (17.552 ms) : 17376, 17727
. : milestone, 17552,
section candidate
no_agent (17.112 ms) : 16941, 17284
. : milestone, 17112,
appsec (18.82 ms) : 18628, 19012
. : milestone, 18820,
code_origins (17.702 ms) : 17528, 17877
. : milestone, 17702,
iast (17.729 ms) : 17553, 17904
. : milestone, 17729,
profiling (18.606 ms) : 18420, 18791
. : milestone, 18606,
tracing (17.67 ms) : 17491, 17848
. : milestone, 17670,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~5fff446671, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (3.693 ms) : 3479, 3906
. : milestone, 3693,
iast (2.232 ms) : 2168, 2297
. : milestone, 2232,
iast_GLOBAL (2.28 ms) : 2215, 2344
. : milestone, 2280,
profiling (2.09 ms) : 2036, 2143
. : milestone, 2090,
tracing (2.042 ms) : 1992, 2092
. : milestone, 2042,
section candidate
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.671 ms) : 3456, 3886
. : milestone, 3671,
iast (2.226 ms) : 2161, 2290
. : milestone, 2226,
iast_GLOBAL (2.262 ms) : 2198, 2326
. : milestone, 2262,
profiling (2.09 ms) : 2036, 2144
. : milestone, 2090,
tracing (2.061 ms) : 2010, 2112
. : milestone, 2061,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~5fff446671, baseline=1.56.0-SNAPSHOT~640a4bd02b
dateFormat X
axisFormat %s
section baseline
no_agent (15.022 s) : 15022000, 15022000
. : milestone, 15022000,
appsec (14.629 s) : 14629000, 14629000
. : milestone, 14629000,
iast (18.624 s) : 18624000, 18624000
. : milestone, 18624000,
iast_GLOBAL (17.969 s) : 17969000, 17969000
. : milestone, 17969000,
profiling (15.002 s) : 15002000, 15002000
. : milestone, 15002000,
tracing (14.713 s) : 14713000, 14713000
. : milestone, 14713000,
section candidate
no_agent (15.292 s) : 15292000, 15292000
. : milestone, 15292000,
appsec (14.702 s) : 14702000, 14702000
. : milestone, 14702000,
iast (18.164 s) : 18164000, 18164000
. : milestone, 18164000,
iast_GLOBAL (18.188 s) : 18188000, 18188000
. : milestone, 18188000,
profiling (15.012 s) : 15012000, 15012000
. : milestone, 15012000,
tracing (14.722 s) : 14722000, 14722000
. : milestone, 14722000,
|
- passing underlying cause rather than LibraryLoadException - adding more implied assertions to TestLibraryLoadingListener - using LibCheck throughout TestLibraryLoadingListener
- adding temp file creation failure test
- checking temp file creation failure
dougqh
commented
Nov 6, 2025
| try (URLClassLoader classLoader = createClassLoader(jar)) { | ||
| NativeLoader loader = | ||
| NativeLoader.builder().fromClassLoader(classLoader).tempDir(noWriteDir).build(); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I'm not sure I like the listener callbacks here.
Right now...
- you get a successful resolution because the source URL was found
- then you get a failed temp file creation
I feel both those make sense, but there's not a listener call back to indicate that the overall resolveDynamic call still failed. I think it might be nice to have one; thoughts?
- exposed oversight in CompositeLibraryLoadingListener not implementing onLoadFailure - added loading failure tests - exposed missing / incomplete load variants in NativeLoader
…-trace-java into dougqh/native-loader-listener
Made order of PlatformSpec, component, libName consistent Changed component -> optionalComponent for clarity
component -> optionalComponent
Adding coverage for exceptions in LibraryResolver and PathLocator
- checking that proper exceptions are passed to listener - covering NativeLoader.isPlatformSupported
- removed unused parameter in onTempFileCreationFailure - fixed oversight in Composite listener coverage - intended to use a shuffled set of listeners with errant & nop listeners injected - also provides full coverage of default methods on LibraryLoadingListener
AlexeyKuznetsov-DD
approved these changes
Nov 7, 2025
PerfectSlayer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Adds listener support throughout NativeLoader, so calling code be informed of...
Motivation
Primarily so calling code can log library loading activity
Additional Notes
Listeners can be added via NativeLoader.Builder to listen to all library loading
Listeners can also be added as 1-off to a resolveDynamic or load call and are scoped to that one library
The intention of the 1-off capability is to allow each component to just log activity for its library
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]