-
Notifications
You must be signed in to change notification settings - Fork 319
Fix NullPointerException in AppSecRequestContext#close #9902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NullPointerException in AppSecRequestContext#close #9902
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: b15b7af | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~b15b7af0f3, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047155
Total [baseline] (10.842 s) : 0, 10842293
Agent [candidate] (1.046 s) : 0, 1045584
Total [candidate] (10.756 s) : 0, 10756442
section appsec
Agent [baseline] (1.222 s) : 0, 1222379
Total [baseline] (10.878 s) : 0, 10877783
Agent [candidate] (1.224 s) : 0, 1223943
Total [candidate] (10.854 s) : 0, 10854175
section iast
Agent [baseline] (1.179 s) : 0, 1179451
Total [baseline] (11.173 s) : 0, 11172717
Agent [candidate] (1.185 s) : 0, 1185394
Total [candidate] (11.158 s) : 0, 11157704
section profiling
Agent [baseline] (1.196 s) : 0, 1195930
Total [baseline] (10.906 s) : 0, 10905940
Agent [candidate] (1.2 s) : 0, 1199826
Total [candidate] (10.975 s) : 0, 10974811
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~b15b7af0f3, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (704.475 ms) : 0, 704475
BytebuddyAgent [candidate] (703.448 ms) : 0, 703448
GlobalTracer [baseline] (246.183 ms) : 0, 246183
GlobalTracer [candidate] (245.932 ms) : 0, 245932
AppSec [baseline] (32.308 ms) : 0, 32308
AppSec [candidate] (32.231 ms) : 0, 32231
Debugger [baseline] (6.386 ms) : 0, 6386
Debugger [candidate] (6.347 ms) : 0, 6347
Remote Config [baseline] (705.129 µs) : 0, 705
Remote Config [candidate] (705.419 µs) : 0, 705
Telemetry [baseline] (12.747 ms) : 0, 12747
Telemetry [candidate] (14.302 ms) : 0, 14302
Flare Poller [baseline] (8.142 ms) : 0, 8142
Flare Poller [candidate] (6.533 ms) : 0, 6533
section appsec
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (729.133 ms) : 0, 729133
BytebuddyAgent [candidate] (730.616 ms) : 0, 730616
GlobalTracer [baseline] (237.397 ms) : 0, 237397
GlobalTracer [candidate] (238.073 ms) : 0, 238073
IAST [baseline] (24.763 ms) : 0, 24763
IAST [candidate] (24.826 ms) : 0, 24826
AppSec [baseline] (175.389 ms) : 0, 175389
AppSec [candidate] (174.835 ms) : 0, 174835
Debugger [baseline] (6.018 ms) : 0, 6018
Debugger [candidate] (6.038 ms) : 0, 6038
Remote Config [baseline] (641.004 µs) : 0, 641
Remote Config [candidate] (649.852 µs) : 0, 650
Telemetry [baseline] (8.585 ms) : 0, 8585
Telemetry [candidate] (8.615 ms) : 0, 8615
Flare Poller [baseline] (4.037 ms) : 0, 4037
Flare Poller [candidate] (3.967 ms) : 0, 3967
section iast
crashtracking [baseline] (1.444 ms) : 0, 1444
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (828.244 ms) : 0, 828244
BytebuddyAgent [candidate] (833.238 ms) : 0, 833238
GlobalTracer [baseline] (234.925 ms) : 0, 234925
GlobalTracer [candidate] (235.054 ms) : 0, 235054
IAST [baseline] (30.653 ms) : 0, 30653
IAST [candidate] (31.706 ms) : 0, 31706
AppSec [baseline] (30.374 ms) : 0, 30374
AppSec [candidate] (29.882 ms) : 0, 29882
Debugger [baseline] (5.991 ms) : 0, 5991
Debugger [candidate] (6.064 ms) : 0, 6064
Remote Config [baseline] (605.684 µs) : 0, 606
Remote Config [candidate] (607.649 µs) : 0, 608
Telemetry [baseline] (8.388 ms) : 0, 8388
Telemetry [candidate] (8.48 ms) : 0, 8480
Flare Poller [baseline] (4.153 ms) : 0, 4153
Flare Poller [candidate] (4.167 ms) : 0, 4167
section profiling
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (732.031 ms) : 0, 732031
BytebuddyAgent [candidate] (734.503 ms) : 0, 734503
GlobalTracer [baseline] (222.492 ms) : 0, 222492
GlobalTracer [candidate] (222.928 ms) : 0, 222928
AppSec [baseline] (32.105 ms) : 0, 32105
AppSec [candidate] (32.428 ms) : 0, 32428
Debugger [baseline] (7.593 ms) : 0, 7593
Debugger [candidate] (8.347 ms) : 0, 8347
Remote Config [baseline] (715.368 µs) : 0, 715
Remote Config [candidate] (1.512 ms) : 0, 1512
Telemetry [baseline] (15.497 ms) : 0, 15497
Telemetry [candidate] (13.986 ms) : 0, 13986
Flare Poller [baseline] (4.127 ms) : 0, 4127
Flare Poller [candidate] (4.235 ms) : 0, 4235
ProfilingAgent [baseline] (110.557 ms) : 0, 110557
ProfilingAgent [candidate] (110.936 ms) : 0, 110936
Profiling [baseline] (111.24 ms) : 0, 111240
Profiling [candidate] (111.629 ms) : 0, 111629
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~b15b7af0f3, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.048 s) : 0, 1048480
Total [baseline] (8.655 s) : 0, 8654838
Agent [candidate] (1.048 s) : 0, 1047632
Total [candidate] (8.618 s) : 0, 8618048
section iast
Agent [baseline] (1.179 s) : 0, 1179178
Total [baseline] (9.241 s) : 0, 9240825
Agent [candidate] (1.178 s) : 0, 1178082
Total [candidate] (9.271 s) : 0, 9270533
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~b15b7af0f3, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (705.562 ms) : 0, 705562
BytebuddyAgent [candidate] (704.765 ms) : 0, 704765
GlobalTracer [baseline] (246.165 ms) : 0, 246165
GlobalTracer [candidate] (246.501 ms) : 0, 246501
AppSec [baseline] (32.474 ms) : 0, 32474
AppSec [candidate] (32.387 ms) : 0, 32387
Debugger [baseline] (6.426 ms) : 0, 6426
Debugger [candidate] (6.394 ms) : 0, 6394
Remote Config [baseline] (717.862 µs) : 0, 718
Remote Config [candidate] (710.885 µs) : 0, 711
Telemetry [baseline] (15.1 ms) : 0, 15100
Telemetry [candidate] (14.96 ms) : 0, 14960
Flare Poller [baseline] (5.866 ms) : 0, 5866
Flare Poller [candidate] (5.786 ms) : 0, 5786
section iast
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (828.175 ms) : 0, 828175
BytebuddyAgent [candidate] (826.996 ms) : 0, 826996
GlobalTracer [baseline] (234.459 ms) : 0, 234459
GlobalTracer [candidate] (234.605 ms) : 0, 234605
IAST [baseline] (34.386 ms) : 0, 34386
IAST [candidate] (32.32 ms) : 0, 32320
AppSec [baseline] (26.969 ms) : 0, 26969
AppSec [candidate] (28.811 ms) : 0, 28811
Debugger [baseline] (5.997 ms) : 0, 5997
Debugger [candidate] (6.051 ms) : 0, 6051
Remote Config [baseline] (591.86 µs) : 0, 592
Remote Config [candidate] (596.469 µs) : 0, 596
Telemetry [baseline] (8.252 ms) : 0, 8252
Telemetry [candidate] (8.371 ms) : 0, 8371
Flare Poller [baseline] (4.176 ms) : 0, 4176
Flare Poller [candidate] (4.105 ms) : 0, 4105
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~b15b7af0f3, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section baseline
no_agent (19.335 ms) : 19135, 19536
. : milestone, 19335,
appsec (18.816 ms) : 18625, 19006
. : milestone, 18816,
code_origins (17.778 ms) : 17599, 17956
. : milestone, 17778,
iast (18.884 ms) : 18690, 19077
. : milestone, 18884,
profiling (18.916 ms) : 18724, 19108
. : milestone, 18916,
tracing (17.727 ms) : 17552, 17903
. : milestone, 17727,
section candidate
no_agent (19.541 ms) : 19337, 19746
. : milestone, 19541,
appsec (20.949 ms) : 20739, 21159
. : milestone, 20949,
code_origins (17.879 ms) : 17700, 18059
. : milestone, 17879,
iast (17.832 ms) : 17654, 18009
. : milestone, 17832,
profiling (18.579 ms) : 18388, 18770
. : milestone, 18579,
tracing (17.708 ms) : 17534, 17881
. : milestone, 17708,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~b15b7af0f3, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section baseline
no_agent (1.195 ms) : 1183, 1206
. : milestone, 1195,
iast (3.109 ms) : 3068, 3150
. : milestone, 3109,
iast_FULL (5.674 ms) : 5618, 5729
. : milestone, 5674,
iast_GLOBAL (3.579 ms) : 3524, 3633
. : milestone, 3579,
profiling (2.008 ms) : 1991, 2026
. : milestone, 2008,
tracing (1.78 ms) : 1765, 1795
. : milestone, 1780,
section candidate
no_agent (1.21 ms) : 1198, 1222
. : milestone, 1210,
iast (3.284 ms) : 3236, 3331
. : milestone, 3284,
iast_FULL (5.607 ms) : 5552, 5663
. : milestone, 5607,
iast_GLOBAL (3.591 ms) : 3532, 3650
. : milestone, 3591,
profiling (1.994 ms) : 1977, 2011
. : milestone, 1994,
tracing (1.805 ms) : 1789, 1820
. : milestone, 1805,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~b15b7af0f3, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.46 ms) : 2409, 2511
. : milestone, 2460,
iast (2.218 ms) : 2154, 2282
. : milestone, 2218,
iast_GLOBAL (2.264 ms) : 2200, 2328
. : milestone, 2264,
profiling (2.063 ms) : 2012, 2115
. : milestone, 2063,
tracing (2.021 ms) : 1972, 2071
. : milestone, 2021,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.458 ms) : 2407, 2508
. : milestone, 2458,
iast (2.212 ms) : 2148, 2275
. : milestone, 2212,
iast_GLOBAL (2.263 ms) : 2199, 2328
. : milestone, 2263,
profiling (2.086 ms) : 2033, 2139
. : milestone, 2086,
tracing (2.024 ms) : 1975, 2073
. : milestone, 2024,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~b15b7af0f3, baseline=1.56.0-SNAPSHOT~8db72c0988
dateFormat X
axisFormat %s
section baseline
no_agent (14.916 s) : 14916000, 14916000
. : milestone, 14916000,
appsec (14.987 s) : 14987000, 14987000
. : milestone, 14987000,
iast (18.164 s) : 18164000, 18164000
. : milestone, 18164000,
iast_GLOBAL (17.99 s) : 17990000, 17990000
. : milestone, 17990000,
profiling (15.295 s) : 15295000, 15295000
. : milestone, 15295000,
tracing (14.671 s) : 14671000, 14671000
. : milestone, 14671000,
section candidate
no_agent (15.392 s) : 15392000, 15392000
. : milestone, 15392000,
appsec (14.732 s) : 14732000, 14732000
. : milestone, 14732000,
iast (18.366 s) : 18366000, 18366000
. : milestone, 18366000,
iast_GLOBAL (18.06 s) : 18060000, 18060000
. : milestone, 18060000,
profiling (14.764 s) : 14764000, 14764000
. : milestone, 14764000,
tracing (14.927 s) : 14927000, 14927000
. : milestone, 14927000,
|
|
solved in #9923 |
What Does This Do
Added defensive null checks before calling clear() on requestHeaders, responseHeaders, and persistentData in the close() method, following the same pattern already used for the derivatives field.
Motivation
Error tracking report
stack trace
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APPSEC-59884