-
Notifications
You must be signed in to change notification settings - Fork 362
Add Azure Durable Functions tracing support #12618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jcstorms1
wants to merge
10
commits into
master
Choose a base branch
from
storms/azure-durable-fx-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1ecaa96
Add Azure Durable Functions worker instrumentation
jcstorms1 f6cb9cf
Add Azure Functions worker code owner
jcstorms1 376c24d
Convert Azure Functions worker tests to JUnit
jcstorms1 12dec94
Fix Durable Functions replay edge cases
jcstorms1 8cd74a3
Fix Azure Functions replay error handling
jcstorms1 e159a3d
Address Azure Functions review feedback
jcstorms1 ab2c863
Sort Azure Functions helper classes
jcstorms1 868f14c
Scope Azure sampling workaround to durable functions
jcstorms1 675b1ca
Align Azure worker test fixture with SPI
jcstorms1 96637fd
Harden durable function replay tracing
jcstorms1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
dd-java-agent/instrumentation/azure-functions-worker-2.7/build.gradle.kts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import groovy.lang.Closure | ||
|
|
||
| plugins { | ||
| id("dd-trace-java.module.instrumentation") | ||
| } | ||
|
|
||
| muzzle { | ||
| pass { | ||
| group = "com.microsoft.azure.functions" | ||
| module = "azure-functions-java-spi" | ||
| versions = "[1.0.0,)" | ||
| extraDependency("com.microsoft.azure.functions:azure-functions-java-core-library:1.2.0") | ||
| } | ||
| } | ||
|
|
||
| fun addTestSuiteForDir(name: String, directory: String) { | ||
| (project.extra["addTestSuiteForDir"] as Closure<*>).call(name, directory) | ||
| } | ||
|
|
||
| addTestSuiteForDir("latestDepTest", "test") | ||
|
|
||
| dependencies { | ||
| compileOnly("com.microsoft.azure.functions:azure-functions-java-core-library:1.2.0") | ||
| compileOnly("com.microsoft.azure.functions:azure-functions-java-spi:1.0.0") | ||
|
|
||
| testImplementation("com.microsoft.azure.functions:azure-functions-java-core-library:1.2.0") | ||
| testImplementation("com.microsoft.azure.functions:azure-functions-java-spi:1.0.0") | ||
| testImplementation(libs.bundles.mockito) | ||
|
|
||
| add( | ||
| "latestDepTestImplementation", | ||
| "com.microsoft.azure.functions:azure-functions-java-core-library:+" | ||
| ) | ||
| add( | ||
| "latestDepTestImplementation", | ||
| "com.microsoft.azure.functions:azure-functions-java-spi:+" | ||
| ) | ||
| } | ||
130 changes: 130 additions & 0 deletions
130
dd-java-agent/instrumentation/azure-functions-worker-2.7/gradle.lockfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| # This is a Gradle generated file for dependency locking. | ||
| # Manual edits can break the build and are not advised. | ||
| # This file is expected to be part of source control. | ||
| # To regenerate this file, run: ./gradlew :dd-java-agent:instrumentation:azure-functions-worker-2.7:dependencies --write-locks | ||
| cafe.cryptography:curve25519-elisabeth:0.1.0=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| cafe.cryptography:ed25519-elisabeth:0.1.0=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| ch.qos.logback:logback-classic:1.2.13=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| ch.qos.logback:logback-core:1.2.13=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.blogspot.mydailyjava:weak-lock-free:0.17=buildTimeInstrumentationPlugin,compileClasspath,latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,muzzleTooling,runtimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.datadoghq.okhttp3:okhttp:3.12.15=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.datadoghq.okio:okio:1.17.6=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.datadoghq:dd-instrument-java:0.0.5=buildTimeInstrumentationPlugin,compileClasspath,latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,muzzleBootstrap,muzzleTooling,runtimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.datadoghq:dd-javac-plugin-client:0.2.2=buildTimeInstrumentationPlugin,compileClasspath,latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,muzzleBootstrap,muzzleTooling,runtimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.datadoghq:java-dogstatsd-client:4.4.5=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| com.datadoghq:sketches-java:0.8.3=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| com.github.javaparser:javaparser-core:3.25.6=codenarc | ||
| com.github.jnr:jffi:1.3.15=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| com.github.jnr:jnr-a64asm:1.0.0=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| com.github.jnr:jnr-constants:0.10.4=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| com.github.jnr:jnr-enxio:0.32.20=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| com.github.jnr:jnr-ffi:2.2.19=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| com.github.jnr:jnr-posix:3.1.22=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| com.github.jnr:jnr-unixsocket:0.38.25=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| com.github.jnr:jnr-x86asm:1.0.2=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| com.github.spotbugs:spotbugs-annotations:4.10.3=compileClasspath,spotbugs | ||
| com.github.spotbugs:spotbugs:4.10.3=spotbugs | ||
| com.github.stephenc.jcip:jcip-annotations:1.0-1=spotbugs | ||
| com.google.auto.service:auto-service-annotations:1.1.1=annotationProcessor,compileClasspath,latestDepTestAnnotationProcessor,latestDepTestCompileClasspath,testAnnotationProcessor,testCompileClasspath | ||
| com.google.auto.service:auto-service:1.1.1=annotationProcessor,latestDepTestAnnotationProcessor,testAnnotationProcessor | ||
| com.google.auto:auto-common:1.2.1=annotationProcessor,latestDepTestAnnotationProcessor,testAnnotationProcessor | ||
| com.google.code.findbugs:jsr305:3.0.2=annotationProcessor,compileClasspath,latestDepTestAnnotationProcessor,latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,spotbugs,testAnnotationProcessor,testCompileClasspath,testRuntimeClasspath | ||
| com.google.code.gson:gson:2.14.0=spotbugs | ||
| com.google.errorprone:error_prone_annotations:2.18.0=annotationProcessor,latestDepTestAnnotationProcessor,testAnnotationProcessor | ||
| com.google.errorprone:error_prone_annotations:2.47.0=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.google.errorprone:error_prone_annotations:2.48.0=spotbugs | ||
| com.google.guava:failureaccess:1.0.1=annotationProcessor,latestDepTestAnnotationProcessor,testAnnotationProcessor | ||
| com.google.guava:failureaccess:1.0.3=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.google.guava:guava:32.0.1-jre=annotationProcessor,latestDepTestAnnotationProcessor,testAnnotationProcessor | ||
| com.google.guava:guava:33.6.0-jre=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava=annotationProcessor,latestDepTestAnnotationProcessor,latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testAnnotationProcessor,testCompileClasspath,testRuntimeClasspath | ||
| com.google.j2objc:j2objc-annotations:2.8=annotationProcessor,latestDepTestAnnotationProcessor,testAnnotationProcessor | ||
| com.google.j2objc:j2objc-annotations:3.1=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.google.re2j:re2j:1.8=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| com.microsoft.azure.functions:azure-functions-java-core-library:1.2.0=compileClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.microsoft.azure.functions:azure-functions-java-core-library:1.3.0=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath | ||
| com.microsoft.azure.functions:azure-functions-java-spi:1.0.0=compileClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.microsoft.azure.functions:azure-functions-java-spi:1.1.0=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath | ||
| com.squareup.moshi:moshi:1.11.0=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.squareup.okhttp3:logging-interceptor:3.12.12=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.squareup.okhttp3:okhttp:3.12.12=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.squareup.okio:okio:1.17.5=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| com.thoughtworks.qdox:qdox:1.12.1=codenarc | ||
| commons-fileupload:commons-fileupload:1.5=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| commons-io:commons-io:2.11.0=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| commons-io:commons-io:2.21.0=spotbugs | ||
| de.thetaphi:forbiddenapis:3.10=compileClasspath,latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| io.leangen.geantyref:geantyref:1.3.16=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| io.sqreen:libsqreen:17.5.0=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| javax.servlet:javax.servlet-api:3.1.0=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| jaxen:jaxen:2.0.6=spotbugs | ||
| junit:junit:4.13.2=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| net.bytebuddy:byte-buddy-agent:1.18.12=buildTimeInstrumentationPlugin,compileClasspath,latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,muzzleTooling,runtimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| net.bytebuddy:byte-buddy:1.18.12=buildTimeInstrumentationPlugin,compileClasspath,latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,muzzleTooling,runtimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| net.java.dev.jna:jna-platform:5.8.0=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| net.java.dev.jna:jna:5.8.0=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| net.sf.saxon:Saxon-HE:12.10=spotbugs | ||
| org.apache.ant:ant-antlr:1.10.14=codenarc | ||
| org.apache.ant:ant-junit:1.10.14=codenarc | ||
| org.apache.bcel:bcel:6.12.0=spotbugs | ||
| org.apache.commons:commons-lang3:3.20.0=spotbugs | ||
| org.apache.commons:commons-text:1.15.0=spotbugs | ||
| org.apache.logging.log4j:log4j-api:2.26.1=spotbugs | ||
| org.apache.logging.log4j:log4j-core:2.26.1=spotbugs | ||
| org.apiguardian:apiguardian-api:1.1.2=latestDepTestCompileClasspath,testCompileClasspath | ||
| org.checkerframework:checker-qual:3.33.0=annotationProcessor,latestDepTestAnnotationProcessor,testAnnotationProcessor | ||
| org.codehaus.groovy:groovy-ant:3.0.23=codenarc | ||
| org.codehaus.groovy:groovy-docgenerator:3.0.23=codenarc | ||
| org.codehaus.groovy:groovy-groovydoc:3.0.23=codenarc | ||
| org.codehaus.groovy:groovy-json:3.0.23=codenarc | ||
| org.codehaus.groovy:groovy-json:3.0.25=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.codehaus.groovy:groovy-templates:3.0.23=codenarc | ||
| org.codehaus.groovy:groovy-xml:3.0.23=codenarc | ||
| org.codehaus.groovy:groovy:3.0.23=codenarc | ||
| org.codehaus.groovy:groovy:3.0.25=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.codenarc:CodeNarc:3.7.0=codenarc | ||
| org.dom4j:dom4j:2.2.0=spotbugs | ||
| org.gmetrics:GMetrics:2.1.0=codenarc | ||
| org.hamcrest:hamcrest-core:1.3=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| org.hamcrest:hamcrest:3.0=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.jctools:jctools-core-jdk11:4.0.6=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| org.jctools:jctools-core:4.0.6=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| org.jspecify:jspecify:1.0.0=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.junit.jupiter:junit-jupiter-api:5.14.1=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.junit.jupiter:junit-jupiter-engine:5.14.1=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| org.junit.jupiter:junit-jupiter-params:5.14.1=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.junit.jupiter:junit-jupiter:5.14.1=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.junit.platform:junit-platform-commons:1.14.1=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.junit.platform:junit-platform-engine:1.14.1=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.junit.platform:junit-platform-launcher:1.14.1=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| org.junit.platform:junit-platform-runner:1.14.1=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| org.junit.platform:junit-platform-suite-api:1.14.1=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| org.junit.platform:junit-platform-suite-commons:1.14.1=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| org.junit:junit-bom:5.14.1=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.junit:junit-bom:6.1.2=spotbugs | ||
| org.mockito:mockito-core:4.4.0=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.mockito:mockito-junit-jupiter:4.4.0=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.objenesis:objenesis:3.3=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.opentest4j:opentest4j:1.3.0=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.ow2.asm:asm-analysis:9.10.1=spotbugs | ||
| org.ow2.asm:asm-analysis:9.7.1=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| org.ow2.asm:asm-commons:9.10.1=latestDepTestRuntimeClasspath,spotbugs,testRuntimeClasspath | ||
| org.ow2.asm:asm-tree:9.10.1=latestDepTestRuntimeClasspath,spotbugs,testRuntimeClasspath | ||
| org.ow2.asm:asm-util:9.10.1=spotbugs | ||
| org.ow2.asm:asm-util:9.7.1=latestDepTestRuntimeClasspath,testRuntimeClasspath | ||
| org.ow2.asm:asm:9.10.1=buildTimeInstrumentationPlugin,compileClasspath,latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,muzzleTooling,runtimeClasspath,spotbugs,testCompileClasspath,testRuntimeClasspath | ||
| org.slf4j:jcl-over-slf4j:1.7.30=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.slf4j:jul-to-slf4j:1.7.30=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.slf4j:log4j-over-slf4j:1.7.30=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.slf4j:slf4j-api:1.7.30=buildTimeInstrumentationPlugin,compileClasspath,muzzleBootstrap,muzzleTooling,runtimeClasspath | ||
| org.slf4j:slf4j-api:1.7.32=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.slf4j:slf4j-api:2.0.17=spotbugsSlf4j | ||
| org.slf4j:slf4j-api:2.0.18=spotbugs | ||
| org.slf4j:slf4j-simple:2.0.17=spotbugsSlf4j | ||
| org.snakeyaml:snakeyaml-engine:2.9=buildTimeInstrumentationPlugin,latestDepTestRuntimeClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath | ||
| org.spockframework:spock-bom:2.4-groovy-3.0=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.spockframework:spock-core:2.4-groovy-3.0=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.tabletest:tabletest-junit:1.2.2=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.tabletest:tabletest-parser:1.2.1=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | ||
| org.xmlresolver:xmlresolver:5.3.3=spotbugs | ||
| empty=spotbugsPlugins |
34 changes: 34 additions & 0 deletions
34
...ain/java/datadog/trace/instrumentation/azure/functions/worker/AsciiStringInputStream.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package datadog.trace.instrumentation.azure.functions.worker; | ||
|
|
||
| import java.io.InputStream; | ||
|
|
||
| /** Exposes an ASCII string as a stream without copying it into a byte array. */ | ||
| public final class AsciiStringInputStream extends InputStream { | ||
| private final String value; | ||
| private int position; | ||
|
|
||
| public AsciiStringInputStream(String value) { | ||
| this.value = value; | ||
| } | ||
|
|
||
| @Override | ||
| public int read() { | ||
| return position < value.length() ? value.charAt(position++) : -1; | ||
| } | ||
|
|
||
| @Override | ||
| public int read(byte[] buffer, int offset, int length) { | ||
| if (length == 0) { | ||
| return 0; | ||
| } | ||
| if (position >= value.length()) { | ||
| return -1; | ||
| } | ||
| final int count = Math.min(length, value.length() - position); | ||
| for (int index = 0; index < count; index++) { | ||
| buffer[offset + index] = (byte) value.charAt(position + index); | ||
| } | ||
| position += count; | ||
| return count; | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The muzzle
passblock only declares compatibility againstazure-functions-java-spi, but the actually-instrumented type —com.microsoft.azure.functions.worker.chain.FunctionExecutionMiddleware— lives in the internal worker runtime, not this SPI artifact.azure-functions-java-spionly ships the SPI interfaces (Middleware,MiddlewareContext,MiddlewareChain) underinternal.spi.middleware;FunctionExecutionMiddlewareis the built-in worker-runtime implementation, which isn't published by this artifact (the test suite has to fabricate a stub for it, since no real dependency provides it).If a future Azure Functions Java worker release changes
FunctionExecutionMiddleware.invoke(...)'s signature, muzzle CI — which only checksazure-functions-java-spiversions — would report no incompatibility, but theElementMatcherwould silently stop matching in production, and durable function tracing would go dark with no build or runtime signal. Sibling instrumentations likeazure-functions-1.2.2andaws-java-lambda-handler-1.2instrument only types fully contained within their declared muzzle-pass artifact.🤖 Generated with Claude Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I improved the test to use Azure's Middleware SPI contract. It still cannot detect the internal class being renamed, but that seems unlikely.